[Bug 22750] New: ControlSpy message parameters listboxes don't have frames
http://bugs.winehq.org/show_bug.cgi?id=22750 Summary: ControlSpy message parameters listboxes don't have frames Product: Wine Version: 1.1.44 Platform: x86 OS/Version: Linux Status: NEW Keywords: regression Severity: trivial Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: bunglehead(a)gmail.com This is a recent regression - frames around listboxes are missed. I'm attaching screenshots to describe this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.microsoft.com/do | |wnloads/details.aspx?displa | |ylang=en&FamilyID=19d4294d- | |0531-4ec2-8b27-2e463b315f16 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-05-17 18:28:38 --- Created an attachment (id=28051) --> (http://bugs.winehq.org/attachment.cgi?id=28051) running wine-1.1.44-245-g943eefc -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-05-17 18:29:23 --- Created an attachment (id=28052) --> (http://bugs.winehq.org/attachment.cgi?id=28052) running native system -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum(a)codeweavers.com Component|-unknown |user32 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-05-17 19:32:16 --- The problem goes away if I revert this commit: commit 897f11d33178f1c5b591ba1a516e79ec8834055e Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri May 7 17:16:41 2010 -0500 user32: Don't use DLGTEMPLATE's ExStyle when creating dialogs. Test looks "a bit" incomplete for such change. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |minor -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 --- Comment #4 from Andrew Eikum <aeikum(a)codeweavers.com> 2010-05-18 13:35:20 --- So of course this is more complicated than I hoped. Apparently I haven't learned to not trust MSDN yet... When a window is created with CreateDialogIndirectParam, it can have whatever exStyle, but the effects of some of the flags are ignored. However, future calls to GetWindowLong(GWL_EXSTYLE) yield the same exStyle flags as you passed in, meaning the original exStyle hangs around; the ignored flags aren't simply masked out. This means it's possible to have a dialog with WS_EX_MDICHILD despite not having an MDI owner window. Great. As expected, hacking around the MDI sanity checks in CreateWindowEx just leads to crashes later, as Wine treats the window as you'd expect for an MDICHILD. A hack to get both cases working is just to mask out the WS_EX_MDICHILD, but that's obviously incorrect based on the above. If a fix is not found for this before 1.2, I suggest reverting my original commit (897f11d33178). Better to have the majority of cases working than the obscure minority case I was attempting to fix. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-05-18 14:06:18 --- Ok, please submit all testcases you made to get at this point. I agree that this should be reverted cause a change is a bit suspicious and affects all applications with dialogues. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 --- Comment #6 from Andrew Eikum <aeikum(a)codeweavers.com> 2010-05-18 15:57:04 --- Created an attachment (id=28067) --> (http://bugs.winehq.org/attachment.cgi?id=28067) Test case for dialogs with WS_EX_MDICHILD and no MDI owner Added an attachment of a half-complete test illustrating comment #4. The test was structured with the assumption that GetWindowLong would reflect the ignored flags, which it doesn't. It demonstrates Wine failing to create the pseudo-MDICHILD dialog before 897f11d33178f, and the ExStyle's persistence which fails after 897f11d33178f. I'll submit a revert patch to wine-patches. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-05-19 10:37:40 --- Ok, regression fixed with commit revert (17789c16369c06f4d740d80c868d13a90c7164dd ). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22750 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> 2010-05-21 14:40:25 --- Closing bugs fixed in 1.2-rc1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org