[Bug 42802] New: GetAutoRotationState is not implemented
https://bugs.winehq.org/show_bug.cgi?id=42802 Bug ID: 42802 Summary: GetAutoRotationState is not implemented Product: Wine Version: 2.5 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: vitaliy-bugzilla(a)kievinfo.com Distribution: --- Have a game (Muv-Luv) that appears to be calling this function: wine: Call from 0x7bc57a30 to unimplemented function USER32.dll.GetAutoRotationState, aborting wine: Unimplemented function USER32.dll.GetAutoRotationState called at address 0x7bc57a30 (thread 00fd), starting debugger... According to documentation (https://msdn.microsoft.com/en-us/library/windows/desktop/dn629265(v=vs.85).a...) shouldn't be that difficult to have bare minimum implementation of it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GetAutoRotationState is not |Muv-Luv needs function |implemented |USER32.dll.GetAutoRotationS | |tate -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 Gijs Vermeulen <acescopezz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acescopezz(a)gmail.com --- Comment #1 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to Vitaliy Margolen from comment #0)
Have a game (Muv-Luv) that appears to be calling this function: wine: Call from 0x7bc57a30 to unimplemented function USER32.dll.GetAutoRotationState, aborting wine: Unimplemented function USER32.dll.GetAutoRotationState called at address 0x7bc57a30 (thread 00fd), starting debugger...
According to documentation (https://msdn.microsoft.com/en-us/library/windows/desktop/dn629265(v=vs.85). aspx) shouldn't be that difficult to have bare minimum implementation of it.
I can't find this function in the .spec file. It seems that the user32.dll .spec file might need to be updated. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #2 from Austin English <austinenglish(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #1)
(In reply to Vitaliy Margolen from comment #0)
Have a game (Muv-Luv) that appears to be calling this function: wine: Call from 0x7bc57a30 to unimplemented function USER32.dll.GetAutoRotationState, aborting wine: Unimplemented function USER32.dll.GetAutoRotationState called at address 0x7bc57a30 (thread 00fd), starting debugger...
According to documentation (https://msdn.microsoft.com/en-us/library/windows/desktop/dn629265(v=vs.85). aspx) shouldn't be that difficult to have bare minimum implementation of it.
I can't find this function in the .spec file. It seems that the user32.dll .spec file might need to be updated.
Yes, it does. Unrelated, but I'm working on updating the specfiles to something newer. Related, I made a (n untested) stub for this, I'll attach it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #3 from Austin English <austinenglish(a)gmail.com> --- Created attachment 57889 --> https://bugs.winehq.org/attachment.cgi?id=57889 stub -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #4 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to Austin English from comment #3)
Created attachment 57889 [details] stub
He linked the wrong function. It needs this function: https://msdn.microsoft.com/en-us/library/windows/desktop/dn629264(v=vs.85).a... (as seen in title) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #5 from Matteo Bruni <matteo.mystral(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #4)
(In reply to Austin English from comment #3)
Created attachment 57889 [details] stub
He linked the wrong function. It needs this function: https://msdn.microsoft.com/en-us/library/windows/desktop/dn629264(v=vs.85). aspx
(as seen in title)
Notice that MSDN has a typo for the function name in the "Syntax" box. The rest seems correct but in general never trust MSDN, check the PSDK instead. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #6 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to Matteo Bruni from comment #5)
(In reply to Gijs Vermeulen from comment #4)
(In reply to Austin English from comment #3)
Created attachment 57889 [details] stub
He linked the wrong function. It needs this function: https://msdn.microsoft.com/en-us/library/windows/desktop/dn629264(v=vs.85). aspx
(as seen in title)
Notice that MSDN has a typo for the function name in the "Syntax" box. The rest seems correct but in general never trust MSDN, check the PSDK instead.
I see, my bad, sorry for the noise. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #7 from Matteo Bruni <matteo.mystral(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #6)
(In reply to Matteo Bruni from comment #5)
Notice that MSDN has a typo for the function name in the "Syntax" box. The rest seems correct but in general never trust MSDN, check the PSDK instead.
I see, my bad, sorry for the noise.
No, you are right, the attached stub won't help with the game (well, unless it also needs GetDisplayAutoRotationPreferences() after GetAutoRotationState()). I was essentially trying to add upon it and my comment was mostly directed to Austin. Sorry for the confusion... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #8 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to Vitaliy Margolen from comment #0)
-snip-
Could you try this patch: https://source.winehq.org/patches/data/132934 (In reply to Matteo Bruni from comment #7)
-snip-
You don't have to say sorry, thanks for clearing that up :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 fjfrackiewicz(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fjfrackiewicz(a)gmail.com --- Comment #9 from fjfrackiewicz(a)gmail.com --- BTW, this bug is a duplicate of bug 42106 which has a staged patch... Sorry for being "that guy"... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #10 from Vitaliy Margolen <vitaliy-bugzilla(a)kievinfo.com> --- (In reply to fjfrackiewicz from comment #9)
BTW, this bug is a duplicate of bug 42106 which has a staged patch... Strange, search did not find that bug. My bad.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #11 from Vitaliy Margolen <vitaliy-bugzilla(a)kievinfo.com> --- Patch from bug 42106 does indeed work here. BTW the game works fine on Windows 7 as well. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #12 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to Vitaliy Margolen from comment #11)
Patch from bug 42106 does indeed work here. BTW the game works fine on Windows 7 as well.
Please mark this as a dupe of bug 42106 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 Vitaliy Margolen <vitaliy-bugzilla(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #13 from Vitaliy Margolen <vitaliy-bugzilla(a)kievinfo.com> --- Duplicate *** This bug has been marked as a duplicate of bug 42106 *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 Vitaliy Margolen <vitaliy-bugzilla(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #14 from Vitaliy Margolen <vitaliy-bugzilla(a)kievinfo.com> --- Closing -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42802 --- Comment #15 from Austin English <austinenglish(a)gmail.com> --- Stub was committed: https://source.winehq.org/git/wine.git/commitdiff/d8db5e04bd6434f08859772e7c... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org