[Bug 39998] New: WINED3DFMT_B5G5R5X1_UNORM to WINED3DFMT_B5G5R5A1_UNORM
https://bugs.winehq.org/show_bug.cgi?id=39998 Bug ID: 39998 Summary: WINED3DFMT_B5G5R5X1_UNORM to WINED3DFMT_B5G5R5A1_UNORM Product: Wine Version: 1.9.1 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs(a)winehq.org Reporter: robert(a)hurst-ri.us Distribution: --- Created attachment 53441 --> https://bugs.winehq.org/attachment.cgi?id=53441 WINED3DFMT_B5G5R5X1_UNORM to WINED3DFMT_B5G5R5A1_UNORM All multimedia works in Medieval: Total War (AppDB Id=4109) with the exception of the Strategy Mode's territory surface map -- it renders black. There seems to be ongoing development (julliard?) in this space, happy to test! :) In-game scrolling repeats the surface_convert_format conversion function artifact, as recorded in the attachment. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.kucia(a)gmail.com --- Comment #1 from Józef Kucia <joseph.kucia(a)gmail.com> --- Created attachment 53450 --> https://bugs.winehq.org/attachment.cgi?id=53450 Add conversion from B5G5R5X1 to B5G5R5A1 Does this patch help? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #2 from joaopa <jeremielapuree(a)yahoo.fr> --- Still a bug in current wine? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Robert Hurst <robert(a)hurst-ri.us> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|1.9.1 |1.9.5 --- Comment #3 from Robert Hurst <robert(a)hurst-ri.us> --- Greetings, I have Fedora packaging for wine-1.9.5 installed now, and yes, it is still a 'bug' with the same graphic conversion information printing: fixme:winediag:start_process Wine Staging 1.9.5 is a testing version containing experimental patches. fixme:winediag:start_process Please mention your exact version when filing bug reports on winehq.org. ... fixme:d3d_surface:surface_convert_format Cannot find a conversion function from format WINED3DFMT_B5G5R5X1_UNORM to WINED3DFMT_B5G5R5A1_UNORM. ... repeats ... Unfortunately, I attempted and only got so far building this out from source myself to include the added patch presented here. Perhaps a maintainer could review it and determine that it looks harmless enough to just add it for the downstream packagers? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|1.9.5 |1.9.1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 --- Comment #4 from Józef Kucia <joseph.kucia(a)gmail.com> --- (In reply to Robert Hurst from comment #3)
Unfortunately, I attempted and only got so far building this out from source myself to include the added patch presented here. Perhaps a maintainer could review it and determine that it looks harmless enough to just add it for the downstream packagers?
A +d3d9 log could be useful to get the patch committed upstream. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|WINED3DFMT_B5G5R5X1_UNORM |Medieval: Total War needs |to |conversion from B5G5R5X1 to |WINED3DFMT_B5G5R5A1_UNORM |B5G5R5A1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 --- Comment #5 from Robert Hurst <robert(a)hurst-ri.us> --- Created attachment 54131 --> https://bugs.winehq.org/attachment.cgi?id=54131 env WINEDEBUG="fixme-all,+d3d_surface,+d3d9" winefile 2> medieval_tw.log Hope this helps. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Robert Hurst <robert(a)hurst-ri.us> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #6 from Robert Hurst <robert(a)hurst-ri.us> --- OUTSTANDING!! winediag:start_process Wine Staging 1.9.8 is a testing version containing experimental patches. No more conversion messages and the surface map renders beautifully, thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 --- Comment #7 from Bruno Jesus <00cpxxx(a)gmail.com> --- (In reply to Robert Hurst from comment #6)
OUTSTANDING!!
winediag:start_process Wine Staging 1.9.8 is a testing version containing experimental patches.
No more conversion messages and the surface map renders beautifully, thank you!
I can't really find the patch in Wine-git nor Staging, so I'm unsure if it was committed. I believe Józef will be able to tell. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED Ever confirmed|0 |1 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> --- Right, let's reopen for now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 --- Comment #9 from Henri Verbeet <hverbeet(a)gmail.com> --- 425e84dac5c87f6b1e7d89b363017a045e4c0626 added a generic fallback for cases where there's no dedicated conversion function. It may still be a good idea to add the dedicated function. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #10 from winetest(a)luukku.com --- (In reply to Henri Verbeet from comment #9)
425e84dac5c87f6b1e7d89b363017a045e4c0626 added a generic fallback for cases where there's no dedicated conversion function. It may still be a good idea to add the dedicated function.
The suggested patch still applies. patching file dlls/wined3d/surface.c Hunk #1 succeeded at 1398 (offset -785 lines). Hunk #2 succeeded at 1531 (offset -785 lines). wine 1.9.22 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Evgeny Burmentyev [:virus_found] <vir.found(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vir.found(a)gmail.com --- Comment #11 from Evgeny Burmentyev [:virus_found] <vir.found(a)gmail.com> --- Will the patch be applied at all? Still not in 2.7 release. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Robert Hurst <robert(a)hurst-ri.us> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #12 from Robert Hurst <robert(a)hurst-ri.us> --- I can confirm that all rendering is now working with latest package release, wine-2.9-1.fc25.x86_64 -- thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |425e84dac5c87f6b1e7d89b3630 | |17a045e4c0626 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39998 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.10. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org