[Bug 10239] New: Internet Explorer bar is broken after the rewrite of the rebar layout code
http://bugs.winehq.org/show_bug.cgi?id=10239 Summary: Internet Explorer bar is broken after the rewrite of the rebar layout code Product: Wine Version: 0.9.48. Platform: PC-x86-64 OS/Version: Linux Status: NEW Keywords: regression Severity: normal Priority: P2 Component: Wine-Rebar AssignedTo: wine-bugs(a)winehq.org ReportedBy: dmitry(a)codeweavers.com CC: mikolaj.zalewski(a)gmail.com Internet Explorer 6.0 is no more able to correctly display/repaint any of its side bars, Search (Ctrl+E) is one of them. This regression is caused by f0a7a74666e2cf9aa1213ea638c4d899f86f19e2 is first bad commit commit f0a7a74666e2cf9aa1213ea638c4d899f86f19e2 Author: Mikołaj Zalewski <mikolaj(a)zalewski.pl> Date: Mon Feb 19 13:56:51 2007 +0100 comctl32: rebar: Rewrite the layout code. :040000 040000 59bad04cfbbf08b1ccc9870617437ac288330f62 bcd4e073b71f9b0ddcddea85e3c2ad0539f1cb8f M dlls -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 --- Comment #1 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2007-10-30 02:41:57 --- It worked before the rewrite? I think I checked that it didn't work before the rewrite so didn't try very hard to make it work after it. But I will look into it (as far as I remember one of the things that is missing is the RBBS_VARHEIGHT). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 --- Comment #2 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2007-10-30 06:09:32 --- Yes, it worked before your patch, otherwise I wouldn't be able to perform a regression test, therefore the 'regression' keyword was added. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 --- Comment #3 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2007-12-06 02:56:30 --- Any progress on this? Should I just send a patch reverting the buggy rewrite? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 --- Comment #4 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2007-12-10 04:35:17 --- I hope this week I will have time to look into it. As for reverting the rewrite you should look at the bugs that were fixed by it - IMO it would be very hard to fix that without a rewrite as the old code contained some fundamental flaws (e.g. AFAIR it often confused the child size with the band size) or at least it should be easier to fix this bug in the new code then to fix something in the old. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 --- Comment #5 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2007-12-19 22:36:43 --- Mikolaj, any progress on this bug? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Wine-Rebar |wine-comctl32 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhs(a)hp.com --- Comment #6 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-01-04 23:07:28 --- *** Bug 11045 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 --- Comment #7 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2008-01-31 13:56:31 --- Created an attachment (id=10551) --> (http://bugs.winehq.org/attachment.cgi?id=10551) patch I've had some time to look into it and this patch seems to fix it. However I will have to test it a bit more. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 --- Comment #8 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-02-22 22:22:36 --- Mikolaj, have you had time to finish the patch? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 --- Comment #9 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2008-02-23 11:21:23 --- Yes. After warming up on easier patches now I'm working on the Rebar layouting code. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 --- Comment #10 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2008-02-26 15:52:30 --- Created an attachment (id=10992) --> (http://bugs.winehq.org/attachment.cgi?id=10992) patch for hidden bands bug I've posted patches that adds RBS_AUTOSIZE support (the serie starts at http://www.winehq.org/pipermail/wine-patches/2008-February/050726.html). I couldn't make them pixel-for-pixel compatible with Windows but for the simple IE rebars this should be more than enough. After applying them IE have some minor problems on sidebands other than search because of hidden bands - it's similar to bug #9450. The attached patch fixes them - I'll check if it solves all the problem and if it does I'll submit it. With this patch all the Search/Favorites/Media sidebands work. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #11 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-02-27 08:48:28 --- Mikolaj, with your patches in today's GIT IE side bars look good again. Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10239 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> 2008-03-07 11:28:30 --- Closing bugs fixed in 0.9.57. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org