[Bug 40301] New: Wrong DTM_GETRANGE message result
https://bugs.winehq.org/show_bug.cgi?id=40301 Bug ID: 40301 Summary: Wrong DTM_GETRANGE message result Product: Wine Version: 1.8.1 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: vz-wine(a)zeitlins.org Distribution: --- Looking at http://source.winehq.org/source/dlls/comctl32/datetime.c#1575 you can see this line: return ret ? ret : 1; /* bug emulation */ I'm not sure which bug does it mean and the commit which added it (see https://github.com/wine-mirror/wine/commit/63fe9d449#diff-60ef36c9d147674ec5...) doesn't go into the details, but this behaviour seems to buggy as it returns GDTR_MIN, implying that the minimum bound of the range is set, even when it is not the case. Currently this results in asserts when creating wxDatePickerCtrl from wxWidgets with WINE (while it works correctly under native Windows) and while I'll work around this in wxWidgets itself, I think this is still a bug in WINE and could result in problems in the other applications as well and should be fixed in it. The fix, of course, is trivial: just "return ret" (or avoid the temporary variable and fold the return with the previous line). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- Hi. For this particular workaround we have a test for MCM_GETRANGE, that's marked as broken(), but I'm not sure we want to keep trying to cover for this case, especially since widely used toolkit is affected. In fact it's possible it's some leftovers from old times, and Monthcal got fixed, while Datetime was left as is. I looked a bit at Monthcal range handling and it's broken in several ways, I'll submit some fixes soon (will try to make it happen this week). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- Please retest with current Wine from git, this should be fixed now with http://source.winehq.org/git/wine.git/?a=commit;h=68701440227f3230a18aad9821... and http://source.winehq.org/git/wine.git/?a=commit;h=a62d17874423a13eb7a39edf71.... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 --- Comment #3 from VZ <vz-wine(a)zeitlins.org> --- Sorry, I'm not sure if I can find time to build Wine from git soon, but looking at the changes it definitely seems like this should have fixed the problem. Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- Sure, you can retest when 1.9.6 is out. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- Please retest with 1.9.6 so we can close this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Wrong DTM_GETRANGE message |wxDatePickerCtrl |result |(wxWidgets) generates an | |assert on DTM_GETRANGE | |message result -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- Hi, VZ. Please retest with 1.9.6 or newer (1.9.8 is already out), or provide a test application so I can verify if this fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 --- Comment #7 from VZ <vz-wine(a)zeitlins.org> --- Sorry for the delay, I'll set up a chroot with Debian unstable which does have 1.9.8 and retest soon. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 --- Comment #8 from VZ <vz-wine(a)zeitlins.org> --- I've tested with 1.9.8 (wine32-development from Debian Stretch) and can confirm that the problem is gone, thanks! There are still problems with the appearance of the date picker control, but I'll report this separately, when I have time to debug them a little. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |a62d17874423a13eb7a39edf71b | |9fcd549b85e4a --- Comment #9 from Nikolay Sivov <bunglehead(a)gmail.com> --- Thanks for testing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.11. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mstefani(a)redhat.com Target Milestone|--- |1.8.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #11 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40301 martha simons <marthasimons9999(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marthasimons9999(a)gmail.com --- Comment #12 from martha simons <marthasimons9999(a)gmail.com> --- Thanks for fixed 1.8.4. ---- #40301 https://goo.gl/LhppLn -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org