[Bug 10363] New: wineprefixcreate: user' s profile shell folders should symlink to $XDG_XXX_DIR
http://bugs.winehq.org/show_bug.cgi?id=10363 Summary: wineprefixcreate: user's profile shell folders should symlink to $XDG_XXX_DIR Product: Wine Version: 0.9.48. Platform: Other OS/Version: other Status: NEW Severity: enhancement Priority: P2 Component: wine-binary AssignedTo: wine-bugs(a)winehq.org ReportedBy: scott(a)open-vote.org xdg-users-dirs permits the usage of "well known" directories, for instance: $XDG_DOCUMENTS_DIR, $XDG_MUSIC_DIR, $XDG_PICTURES_DIR, $XDG_VIDEOS_DIR For the time being wine creates 4 links for its Shell Folders ("My Documents","My Pictures","My Music","My video" ) directly to user home or in ~/My Documents if it exists. ls -l ~/.wine/drive_c/windows/profiles/maz now: lrwxrwxrwx 1 maz maz 9 2007-10-11 10:31 My Documents -> /home/maz lrwxrwxrwx 1 maz maz 9 2007-10-11 10:31 My Music -> /home/maz lrwxrwxrwx 1 maz maz 9 2007-10-11 10:31 My Pictures -> /home/maz lrwxrwxrwx 1 maz maz 9 2007-10-11 10:31 My Video -> /home/maz If wine would make use of $(XDG_CONFIG_HOME)/user-dirs.dirs (assuming it exists), this could become (for example): lrwxrwxrwx 1 maz maz 19 2007-10-11 10:53 My Documents -> /home/maz/Documents lrwxrwxrwx 1 maz maz 15 2007-10-11 10:53 My Music -> /home/maz/Music lrwxrwxrwx 1 maz maz 18 2007-10-11 10:54 My Pictures -> /home/maz/Pictures lrwxrwxrwx 1 maz maz 16 2007-10-11 10:55 My Video -> /home/maz/Videos https://bugs.launchpad.net/ubuntu/+source/wine/+bug/151530 I believe this can be fixed with a simple change to wineprefixcreate. Am I right? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10363 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com --- Comment #1 from Dan Kegel <dank(a)kegel.com> 2007-11-08 17:42:28 --- We should not do this with symbolic links; rather, we should use shell folder redirection. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10363 --- Comment #2 from Juan Lang <juan_lang(a)yahoo.com> 2007-11-09 09:57:39 --- This isn't done in wineprefixcreate. Rather, it's done in dlls/shell32/shellpath.c in _SHCreateSymbolicLinks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10363 --- Comment #3 from Lei Zhang <thestig(a)google.com> 2007-11-12 15:03:17 --- I'll have a patch for this soon. The change is mostly in dlls/shell32/shellpath.c, but I did need to modify wineprefixcreate to source $XDG_CONFIG_HOME/.config and export the XDG_XXX_DIR variables. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10363 --- Comment #4 from Lei Zhang <thestig(a)google.com> 2007-11-16 16:49:04 --- patches sent: http://www.winehq.org/pipermail/wine-patches/2007-November/046854.html http://www.winehq.org/pipermail/wine-patches/2007-November/046855.html I'm doing this via symlink. In order to do shell folder redirection, we need to get rid of the symlinking behavior altogether. (i.e. replace _SHCreateSymbolicLinks) and change the code in winecfg where we assume these directories are symlinks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10363 --- Comment #5 from Lei Zhang <thestig(a)google.com> 2007-11-26 18:02:15 --- Alexandre asked for the changes to be all in shell32. Here's the second attempt: http://www.winehq.org/pipermail/wine-patches/2007-November/047205.html http://www.winehq.org/pipermail/wine-patches/2007-November/047206.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10363 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|_obsolete_binary |shell32 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10363 --- Comment #6 from Lei Zhang <thestig(a)google.com> 2008-03-04 19:00:59 --- Here's the third try. This version uses shell folder redirection. http://www.winehq.org/pipermail/wine-patches/2008-March/051060.html http://www.winehq.org/pipermail/wine-patches/2008-March/051058.html http://www.winehq.org/pipermail/wine-patches/2008-March/051059.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10363 Lei Zhang <thestig(a)google.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #7 from Lei Zhang <thestig(a)google.com> 2008-03-12 10:40:30 --- Patches committed, marking this fixed. http://www.winehq.org/pipermail/wine-cvs/2008-March/041219.html http://www.winehq.org/pipermail/wine-cvs/2008-March/041220.html http://www.winehq.org/pipermail/wine-cvs/2008-March/041221.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10363 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> 2008-03-21 10:54:24 --- Closing bugs fixed in 0.9.58. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org