[Bug 40177] New: multicharacter constant warning in wineqtdecoder
https://bugs.winehq.org/show_bug.cgi?id=40177 Bug ID: 40177 Summary: multicharacter constant warning in wineqtdecoder Product: Wine Version: 1.9.3 Hardware: x86 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: isakov-sl(a)bk.ru gcc-4.8.4 shows me a warning ~~~ dlls/wineqtdecoder/qtsplitter.c:1049:187: warning: multi-character character constant [-Wmultichar] err = NewMovieFromDataRef(&filter->pQTMovie, newMovieActive|newMovieDontInteractWithUser|newMovieDontAutoUpdateClock|newMovieDontAskUnresolvedDataRefs|newMovieAsyncOK, &id, dataRef, 'WINE'); ~~~~ Should it be "WINE" or some other idea? According to spec it must be (file, URL, pointer, or handle), not a character and moreover not a multicharacter. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40177 --- Comment #1 from Henri Verbeet <hverbeet(a)gmail.com> --- It's probably supposed to be a FourCC. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40177 --- Comment #2 from Sergey Isakov <isakov-sl(a)bk.ru> --- OK, it works ~~~~ #include <stdio.h> #include <stdlib.h> #include <string.h> int main(int argc, char **argv) { unsigned int Wine = 'WINE'; printf("%#x\n", Wine); } ~~~ $ ./four_cc 0x57494e45 ~~~ Sorry for disturbing. I should set CFLAGS = "-Wno-multichar" -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40177 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com, | |winetest(a)luukku.com --- Comment #3 from winetest(a)luukku.com --- So is this valid or invalid? You can yourself mark bugs closed. Not everyone can do that. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40177 Sergey Isakov <isakov-sl(a)bk.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED --- Comment #4 from Sergey Isakov <isakov-sl(a)bk.ru> ---
According to spec it must be (file, URL, pointer, or handle), not a character and >moreover not a multicharacter.
But it has reliable syntax. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40177 --- Comment #5 from Henri Verbeet <hverbeet(a)gmail.com> --- (In reply to winetest from comment #3)
So is this valid or invalid? You can yourself mark bugs closed. Not everyone can do that.
I think the warning is valid and these should use mmioFOURCC. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40177 Matteo Bruni <matteo.mystral(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #6 from Matteo Bruni <matteo.mystral(a)gmail.com> --- (In reply to Henri Verbeet from comment #5)
I think the warning is valid and these should use mmioFOURCC.
Same here. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40177 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net Status|REOPENED |NEW --- Comment #7 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, obviously still present. I guess fixing this is too hard *pepega*. https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/wineqtdecoder/qtsplit... Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla