[Bug 45246] New: Free Manga Downloader(all): no text on some boxes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Bug ID: 45246 Summary: Free Manga Downloader(all): no text on some boxes. Product: Wine Version: 3.6 Hardware: x86-64 URL: https://github.com/riderkick/FMD OS: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: luciojunior3(a)mail.com Distribution: Ubuntu Created attachment 61490 --> https://bugs.winehq.org/attachment.cgi?id=61490 Missing text. Same issue when running Manjaro, Nvidia 390 drivers. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #1 from Lucio <luciojunior3(a)mail.com> --- Same issue when running Manjaro, Nvidia 390 drivers. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Lucio <luciojunior3(a)mail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luciojunior3(a)mail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source CC| |dark.shadow4(a)web.de --- Comment #2 from Fabian Maurer <dark.shadow4(a)web.de> --- That's interesting, confirming. Since we have the source, it shouldn't be too hard to figure out. "winetricks -q allfonts" does not help. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 tokktokk <fdsfgs(a)krutt.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs(a)krutt.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- Seems to be the same issue in DoubleCommander (https://sourceforge.net/projects/doublecmd/files/DC for Windows 32 bit/Double Commander 0.8.2 beta/doublecmd-0.8.2.i386-win32.zip/download) (Configuration->Options) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- It works with wine-3.0. Also, ReactOS has the same issue, see https://jira.reactos.org/browse/CORE-14649 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |05d4e4a23b06fd927bbe72ad4e5 | |a864e9a8d842d --- Comment #5 from Fabian Maurer <dark.shadow4(a)web.de> --- Bisected to commit 05d4e4a23b06fd927bbe72ad4e5a864e9a8d842d Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Tue Apr 3 09:10:57 2018 +0300 comctl32/button: Remove style checking when handling BM_SETIMAGE. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #6 from Fabian Maurer <dark.shadow4(a)web.de> --- Actually, this is two problems: 1) Since BCM_SETIMAGELIST is implemented, this is used instead of BM_SETIMAGE. Since the imagelist is never drawn, this won't render. 2) Since a refactoring, the button won't be drawn if an image is set but the text is null. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com --- Comment #7 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Yes. The show image and text functionality is being review. Please wait for the patch. Thanks.(In reply to Fabian Maurer from comment #6)
Actually, this is two problems:
1) Since BCM_SETIMAGELIST is implemented, this is used instead of BM_SETIMAGE. Since the imagelist is never drawn, this won't render.
2) Since a refactoring, the button won't be drawn if an image is set but the text is null.
Yes. The show image and text, imagelist rendering functionality is being reviewed. Please wait for the patch. Thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #8 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- I wouldn't call this a regression though. The functionality to show image and text , and imagelist rendering were not implemented. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #9 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 61522 --> https://bugs.winehq.org/attachment.cgi?id=61522 patch being reviewed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61522|0 |1 is obsolete| | --- Comment #10 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 61523 --> https://bugs.winehq.org/attachment.cgi?id=61523 0001-comctl32-Use-BUTTON_GetDrawState-helper.txt -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #11 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 61524 --> https://bugs.winehq.org/attachment.cgi?id=61524 0002-comctl32-Support-show-image-and-text-as-button-label.txt -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #12 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 61525 --> https://bugs.winehq.org/attachment.cgi?id=61525 0003-comctl32-Support-imagelist-rendering-in-button.txt -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #13 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Apply those three patches if you don't wanna wait anymore. Thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #14 from Fabian Maurer <dark.shadow4(a)web.de> ---
I wouldn't call this a regression though. The functionality to show image and text , and imagelist rendering were not implemented.
Well, the program worked fine until these changes were made, so that's a regression.
Apply those three patches if you don't wanna wait anymore. Thanks.
Thanks, I can confirm those fix the issue. Please disregard the email I sent to wine-devel regarding that matter. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #15 from Fabian Maurer <dark.shadow4(a)web.de> --- Any news on those patches? Are they already submitted? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #16 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- No yet. I'll submit them soon. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 akw <akv(a)etersoft.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akv(a)etersoft.ru --- Comment #17 from akw <akv(a)etersoft.ru> --- Still no any news about these patches? There is another bug 45727 where these patches helps too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |comctl32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #18 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- They're ready. I'll submit the updated patches in a week or so. Hopefully before next release. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 --- Comment #19 from Nikolay Sivov <bunglehead(a)gmail.com> --- Please retest with current git, it should be fixed now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |c9aa8dab8f0d86cf4fb06612f26 | |1c67327046789 Resolution|--- |FIXED --- Comment #20 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- I just retested with wine-git and it works. Marking FIXED. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45246 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #21 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.16. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org