[Bug 11411] New: GetFileVersionInfoSizeW returns wrong error code if file has no version ( affects WiX)
http://bugs.winehq.org/show_bug.cgi?id=11411 Summary: GetFileVersionInfoSizeW returns wrong error code if file has no version (affects WiX) Product: Wine Version: 0.9.54. Platform: Other OS/Version: other Status: UNCONFIRMED Keywords: patch Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: dank(a)kegel.com http://blog.rvburke.com/2008/01/30/gtk-and-pygtk-on-win32/ complained about WiX not running. http://www.winehq.org/pipermail/wine-patches/2007-November/046456.html talks about two changes needed to get it closer to running. It seems to have been dropped, so here's one of the two bugs it reports: Running light.exe from wix on a wixobj file with a non-versioned file as a component prints a diagnostic error indicating ERROR_FILE_NOT_FOUND using wine's builtin of version.dll and msi.dll, but ERROR_RESOURCE_DATA_NOT_FOUND using wine's builtin of msi.dll and native version.dll. ... version.dll's GetFileVersionInfoSizeW does return ERROR_FILE_NOT_FOUND when trying to get the version of a file that does not contain a version (for example, a text file). This is because it relies on VERSION_GetFileVersionInfo_16 to do the file existance check, which returns 0 (meaning file does not exist) if LoadLibrary16 fails. The patch addresses this by making VERSION_GetFileVersionInfo_16 return 0xFFFFFFFF (meaning file exists but does not have version) if LoadLibrary16 returns an error beside ERROR_FILE_NOT_FOUND. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11411 Johan Dahlin <jdahlin(a)async.com.br> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11414 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11411 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Component|-unknown |msi Ever Confirmed|0 |1 --- Comment #1 from James Hawkins <truiken(a)gmail.com> 2008-02-03 12:19:23 --- I have a series of patches ready to submit that fix this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11411 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from James Hawkins <truiken(a)gmail.com> 2008-02-05 11:30:05 --- The fixes are in git. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11411 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Dan Kegel <dank(a)kegel.com> 2008-02-12 00:07:00 --- All bugs in state FIXED should be closed each time we do a release to mark the fact that the fix is now released. If the bug is somehow not really fixed, the individual bug should be reopened. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=11411 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net Keywords| |download OS|other |Linux URL| |https://web.archive.org/web | |/20210315115200/https://raw | |.githubusercontent.com/Casa | |DeRobison/wixtoolset-codepl | |ex/master/archived-stable-v | |ersions/WiX%20Toolset%20v3. | |6%20Stable/WiX36.exe Hardware|Other |x86 Fixed by SHA1| |d1654350483de252ff93365cd65 | |33170a98248e4 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla