New subject: [Bug 48914] Move error groups to the test unit granularity

11 Apr 2020

      https://bugs.winehq.org/show_bug.cgi?id=48914

            Bug ID: 48914
           Summary: Move error groups to the test unit granularity
           Product: Wine-Testbot
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
          Assignee: wine-bugs(a)winehq.org
          Reporter: fgouget(a)codeweavers.com
      Distribution: ---

The error groups of .errors files currently correspond to test modules
(kernel32, user32) rather than test units (kernel32:process, user32:win).

This matches the current presentation of errors on the TestBot:
  kernel32
  debugger.c:1646: Test failed: dwDebugEventCode = 1
  thread.c:1207: Test failed: wrong error 1444
  thread.c:1210: Test failed: wrong error 998
  ...

Only the filename at the start of the line distinguishes a test unit from
another. But when a test crashes the Wine unhandled exception error does not
specify a filename:

  kernel32
  Unhandled exception: page fault on write access to 0x00000000 in 32-bit code
(0x00440953).
  profile.c:85: Test failed: test<00>: ret<0000000070> exp<0000000000>

So the only way to know which test unit crashed is to look at the full report.
That's a minor inconvenience for developers.

But the test failures blacklisting (bug 48912) works on .errors files and
applies at the test unit level. As is, this make it hard to blacklist an
intermittent unhandled exception.

So it would make sense to modify the .errors files so they have one error group
per test unit. The JobDetails page could then either collapse all error groups
of a single test module together so the presentation is unchanged, or just
present them as they are which would probably make just as much sense.

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

[Bug 48914] New: Move error groups to the test unit granularity

WineHQ Bugzilla

WineHQ Bugzilla

tags

participants (1)