[Bug 11479] New: db: \r should be stripped from identifiers in SQL
http://bugs.winehq.org/show_bug.cgi?id=11479 Summary: db: \r should be stripped from identifiers in SQL Product: Wine Version: CVS/GIT Platform: Other OS/Version: other Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: msi AssignedTo: wine-bugs(a)winehq.org ReportedBy: jdahlin(a)async.com.br Created an attachment (id=10620) --> (http://bugs.winehq.org/attachment.cgi?id=10620) stupid patch and testcase While trying to compile the basic example in Wix, an query string is sent in to MsiDatabaseOpenView() for which MSI_ParseSQL return 1. Eg: trace:msi:MSI_DatabaseOpenViewW L"CREATE TABLE `_SummaryInformation` ( `PropertyId` INT NOT NULL, `Value\r` CHAR(255\r) NOT NULL LOCALIZABLE PRIMARY KEY `PropertyId\r`)" 0x61ed98 trace:msi:MSI_ParseSQL Parse returned 1 To reproduce this error, the instructions in bug 11414, comment 10 applies. Attached is a new test to msi/tests/db.c stupid and naive patch which just strips the trailing \r if present. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11479 --- Comment #1 from James Hawkins <truiken(a)gmail.com> 2008-02-05 13:05:39 --- I already have a test case and fix ready to send in. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11479 --- Comment #2 from James Hawkins <truiken(a)gmail.com> 2008-02-06 14:58:24 --- Have you even tested that snippet in windows? The test fails. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11479 --- Comment #3 from Johan Dahlin <jdahlin(a)async.com.br> 2008-02-06 16:45:37 --- James: No, I don't have access to a windows box. Then I guess the error is somewhere else, reading lines from a stream or such. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11479 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |INVALID --- Comment #4 from James Hawkins <truiken(a)gmail.com> 2008-02-17 21:06:40 --- Invalid. You can see the tests in wine/dlls/msi/tests/db.c. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11479 James Hawkins <truiken(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from James Hawkins <truiken(a)gmail.com> 2008-02-17 21:06:54 --- Closing. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=11479 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org