[Bug 13308] New: comctrl32 listview toggles election while scrolling with ctrl key

http://bugs.winehq.org/show_bug.cgi?id=13308

           Summary: comctrl32 listview toggles election while scrolling with
                    ctrl key
           Product: Wine
           Version: 1.0-rc1
          Platform: PC-x86-64
        OS/Version: other
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: comctl32
        AssignedTo: wine-bugs(a)winehq.org
        ReportedBy: winehq.10.drkshadow(a)spamgourmet.com


Created an attachment (id=13169)
 --> (http://bugs.winehq.org/attachment.cgi?id=13169)
patch to call SetItemFocus while scrolling with ctrl down

The comctrl32 listview module will toggle the selection of all items scrolled
over when the ctrl key is held down. This is contrary to Windows behavior.

The fix is to check for the control key and set the item if it is down, unless
space is pressed, in which case the toggle should be performed.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 13308] comctrl32 listview toggles election while scrolling with ctrl key

http://bugs.winehq.org/show_bug.cgi?id=13308


Austin English <austinenglish(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch




--- Comment #1 from Austin English <austinenglish(a)gmail.com>  2008-05-19 10:59:12 ---
Please add a conformance test to show your patch is correct, and submit to
wine-patches(a)winehq.org


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 13308] comctrl32 listview toggles election while scrolling with ctrl key

http://bugs.winehq.org/show_bug.cgi?id=13308





--- Comment #2 from Austin English <austinenglish(a)gmail.com>  2008-11-16 18:28:33 ---
Ping.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 13308] comctrl32 listview toggles election while scrolling with ctrl key

http://bugs.winehq.org/show_bug.cgi?id=13308





--- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com>  2009-03-12 15:09:53 ---
(In reply to comment #2)
> Ping.

Pong. Hi, Austin. Not sure but maybe this helped:
http://source.winehq.org/git/wine.git/?a=commit;h=24dc6600fccf13b41ae035ea61...

Anyway I can't reproduce this with 7zip file manager (multiselect listview).


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 13308] comctrl32 listview toggles election while scrolling with ctrl key

http://bugs.winehq.org/show_bug.cgi?id=13308





--- Comment #4 from Austin English <austinenglish(a)gmail.com>  2009-03-12 17:31:13 ---
(In reply to comment #3)
> (In reply to comment #2)
> > Ping.
>
> Pong. Hi, Austin. Not sure but maybe this helped:
> http://source.winehq.org/git/wine.git/?a=commit;h=24dc6600fccf13b41ae035ea61...
>
> Anyway I can't reproduce this with 7zip file manager (multiselect listview).

So, fixed? Reporter, could you confirm?


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 13308] comctrl32 listview toggles election while scrolling with ctrl key

http://bugs.winehq.org/show_bug.cgi?id=13308





--- Comment #5 from DrkShadow <winehq.10.drkshadow(a)spamgourmet.com>  2009-03-13 18:21:04 ---
Yes, the commit fixes it... though I'm surprised it was allowed; it seems like
a lot was changed. Do compare the attached patch.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 13308] comctrl32 listview toggles election while scrolling with ctrl key

http://bugs.winehq.org/show_bug.cgi?id=13308


Austin English <austinenglish(a)gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Austin English <austinenglish(a)gmail.com>  2009-03-13 18:52:20 ---
Fixed.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.

[Bug 13308] comctrl32 listview toggles election while scrolling with ctrl key

http://bugs.winehq.org/show_bug.cgi?id=13308


Alexandre Julliard <julliard(a)winehq.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




--- Comment #7 from Alexandre Julliard <julliard(a)winehq.org>  2009-03-27 13:50:28 ---
Closing bugs fixed in 1.1.18.


-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.