[Bug 48138] New: League of Legends 9.23: Crash after champ select
https://bugs.winehq.org/show_bug.cgi?id=48138 Bug ID: 48138 Summary: League of Legends 9.23: Crash after champ select Product: Wine Version: 4.17 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: winehq(a)juke.fr Distribution: --- (mostly copy-pasted from Bug#47915) Since updating to LoL 9.23 there is a new "crash after champ select" issue. Would be great if some experienced developer could have a look at this. I could not find a way to get the game to give me a crash dump report so I have not attached any logs, maybe other people will have better luck with this. The bug is really easy to reproduce. Just try to open the "practice tool". Will crash immediately when the switch from client to actual game should happen. There is also a problem with fonts not showing correctly when updating the client from a previous version that can easily be fixed by switching the resolution back and forth in the settings of the launcher. Maybe David Torok could have a look at this one? He did an remarkably great job with fixing such things in the past! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #1 from winehq(a)juke.fr --- Created attachment 65737 --> https://bugs.winehq.org/attachment.cgi?id=65737 Launcher crash when editing rune page edit rune page in launcher to reproduce -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #2 from winehq(a)juke.fr --- To recap the list as of now : - client crashes, on start, cant get a dump - launcher crashes, when editing runes, uploaded dump - launcher, issues with font/icons even after resolution switch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 David Torok <dt(a)zeroitlab.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dt(a)zeroitlab.com --- Comment #3 from David Torok <dt(a)zeroitlab.com> --- Created attachment 65743 --> https://bugs.winehq.org/attachment.cgi?id=65743 Patch for 9.23 Hello guys. Please test. Should be good ;) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #4 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to David Torok from comment #3)
Created attachment 65743 [details] Patch for 9.23
Hello guys.
Please test. Should be good ;)
@@ -1430,6 +1430,11 @@ NTSTATUS WINAPI NtQueryInformationThread( HANDLE handle, THREADINFOCLASS class, *(BOOL*)data = FALSE; if (ret_len) *ret_len = sizeof(BOOL); return STATUS_SUCCESS; + case ThreadHideFromDebugger: + if (length != sizeof(char)) return STATUS_INFO_LENGTH_MISMATCH; + *(char*)data = "\x01"; + if (ret_len) *ret_len = sizeof(char); + return STATUS_SUCCESS; Probably this should look like (BOOLEAN instead of char and strange "\x01"): case ThreadHideFromDebugger: if (length != sizeof(BOOLEAN)) return STATUS_INFO_LENGTH_MISMATCH; *(BOOLEAN *)data = TRUE; if (ret_len) *ret_len = sizeof(BOOLEAN); return STATUS_SUCCESS; I suppose it's a workaround for NtSetInformationThread(ThreadHideFromDebugger) that doesn't save the requested state for the specified thread/ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #5 from David Torok <dt(a)zeroitlab.com> --- (In reply to Dmitry Timoshkov from comment #4) Its for the Query function, as the patch refers to NtQueryInformationThread. You are right about the BOOLEAN part, usually I just rush to have a working PoC. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #6 from winehq(a)juke.fr --- I have tried the patch from David and it seems to work for the game client. Thank you very much. There still remains an issue with the launcher crashing when editing a rune page, should I open a separate bug to track it ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #7 from David Torok <dt(a)zeroitlab.com> --- (In reply to winehq from comment #6)
I have tried the patch from David and it seems to work for the game client. Thank you very much.
There still remains an issue with the launcher crashing when editing a rune page, should I open a separate bug to track it ?
Glad to hear that it works for you! Yes, that is a completely different issue, probably related to the newer chromium embedded framework that shipped with the client. I'll take a look :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 Rio <RioFlix(a)protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |RioFlix(a)protonmail.com Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick(a)piezo-forte.be --- Comment #8 from Rio <RioFlix(a)protonmail.com> --- (In reply to David Torok from comment #3)
Created attachment 65743 [details] Patch for 9.23
Hello guys.
Please test. Should be good ;)
Sorry for asking I'm not advanced user and many other too :( could you tell me where is the file location so we can edit it with those lines. --- Comment #9 from Rio <RioFlix(a)protonmail.com> --- (In reply to David Torok from comment #3)
Created attachment 65743 [details] Patch for 9.23
Hello guys.
Please test. Should be good ;)
Please could you tell me where I can find that file to edit it ? --- Comment #10 from Rio <RioFlix(a)protonmail.com> --- (In reply to David Torok from comment #3)
Created attachment 65743 [details] Patch for 9.23
Hello guys.
Please test. Should be good ;)
Please could you tell me where I can find that file to edit it ? --- Comment #11 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- (In reply to Rio from comment #8)
Sorry for asking I'm not advanced user and many other too :( could you tell me where is the file location so we can edit it with those lines.
Hello, The attachment is a patch file to be applied on the Wine source code before compiling it. The patch contains the path and name of the files it modifies (dlls/ntdll/thread.c). You can find instructions about compiling Wine in the Wiki: https://wiki.winehq.org/Building_Wine Users must not ask for help on bugzilla, look for help in the forums or mailing lists: https://www.winehq.org/help Regards. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |STAGED Ever confirmed|0 |1 CC| |z.figura12(a)gmail.com Component|-unknown |ntdll Staged patchset| |https://github.com/wine-sta | |ging/wine-staging/tree/mast | |er/patches/ntdll-ThreadHide | |FromDebugger -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #12 from winehq(a)juke.fr --- (In reply to David Torok from comment #7)
(In reply to winehq from comment #6)
I have tried the patch from David and it seems to work for the game client. Thank you very much.
There still remains an issue with the launcher crashing when editing a rune page, should I open a separate bug to track it ?
Glad to hear that it works for you! Yes, that is a completely different issue, probably related to the newer chromium embedded framework that shipped with the client. I'll take a look :)
The latest wine-lol available on github seems to fix this issue, so either wine 4.20 helps or the custom 4.20 patch in the repo fixes it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #13 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Staged version has 2 issues: 1. it still uses sizeof(char) in one place 2. it always returns TRUE for every thread, some apps may expect FALSE. This needs a proper implementation of set/get ThreadHideFromDebugger state. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #14 from Zebediah Figura <z.figura12(a)gmail.com> --- (In reply to Dmitry Timoshkov from comment #13)
Staged version has 2 issues: 1. it still uses sizeof(char) in one place
Sure, when it gets submitted upstream that can be fixed.
2. it always returns TRUE for every thread, some apps may expect FALSE. This needs a proper implementation of set/get ThreadHideFromDebugger state.
Not really a necessity a priori, I'd assert. If something actually breaks then sure. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 juliansperling(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juliansperling(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 --- Comment #15 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- A modified version of the staging patch was upstreamed as <https://source.winehq.org/git/wine.git/commit/537bb7a8aee278d285cb77669fd9258dfaa3222f> So I guess this issue is fixed? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Fixed by SHA1| |537bb7a8aee278d285cb77669fd | |9258dfaa3222f Resolution|--- |FIXED --- Comment #16 from Zebediah Figura <z.figura12(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #15)
A modified version of the staging patch was upstreamed as <https://source.winehq.org/git/wine.git/commit/ 537bb7a8aee278d285cb77669fd9258dfaa3222f>
So I guess this issue is fixed?
Yes, resolving fixed. Note of course that League of Legends is blocked by many other bugs and won't work upstream. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48138 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #17 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.12. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla