[Bug 42306] New: One Note Free Retail installer crashes in xmllite
https://bugs.winehq.org/show_bug.cgi?id=42306 Bug ID: 42306 Summary: One Note Free Retail installer crashes in xmllite Product: Wine Version: 2.0-rc5 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: xmllite Assignee: wine-bugs(a)winehq.org Reporter: xerox_xerox2000(a)yahoo.co.uk Distribution: --- Created attachment 57030 --> https://bugs.winehq.org/attachment.cgi?id=57030 crashlog A user reported troubles with this in AppdB. Attached is +xmllite debugcrash I was able to get a bit further using hack below *, then it ran into unimplmeneted function Call from 0x7b43f417 to unimplemented function api-ms-win-crt-locale-l1-1-0.dll.__initialize_lconv there is already bugreport for that one *hack: diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index de61d13..6d961cc 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -2777,7 +2777,8 @@ static HRESULT WINAPI xmlreader_Read(IXmlReader* iface, XmlNodeType *nodetype) if (hr == S_OK) { TRACE("node type %s\n", debugstr_nodetype(This->nodetype)); - *nodetype = This->nodetype; + if (nodetype) + *nodetype = This->nodetype; } return hr; -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.onenote.com/down | |load --- Comment #1 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> --- Added downloadlink sha1sum ~/Downloads/setuponenotefreeretail.x86.en-us_.exe d7adbfcc5656a77209e915c5fec8ca8c8a6dc63d /home/louis/Downloads/setuponenotefreeretail.x86.en-us_.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- Yes, this makes sense. Please add corresponding call to tests and send this fix. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 --- Comment #3 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> --- Created attachment 57033 --> https://bugs.winehq.org/attachment.cgi?id=57033 /tmp/zooi (In reply to Nikolay Sivov from comment #2)
Yes, this makes sense. Please add corresponding call to tests and send this fix.
Well, my knowledge about this is not very much, so then i need some guidance i guess. I did an attempt in attachment, i dont know where to put test. When i put it in other places in reader.c i get several failed tests/crash, when i put it like in attachment it passes (on XP). Would this be correct place? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |bunglehead(a)gmail.com --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- No, it doesn't look right. I'll take care of it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 --- Comment #5 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> --- (In reply to Nikolay Sivov from comment #4)
No, it doesn't look right. I'll take care of it.
ok, thats fine -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Assignee|bunglehead(a)gmail.com |wine-bugs(a)winehq.org Fixed by SHA1| |33d8a323d01f36785ea3db0f7c9 | |5eda5c36bea07 Status|NEW |RESOLVED --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- Fixed with 33d8a323d01f36785ea3db0f7c95eda5c36bea07, please test. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 --- Comment #7 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> --- (In reply to Nikolay Sivov from comment #6)
Fixed with 33d8a323d01f36785ea3db0f7c95eda5c36bea07, please test.
Yes, the crash is gone. (Next problem is an errorwindow comes up, winetricks msxml6 is workaround, but that should be tracked in new bugreport then) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> --- Yes, please. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42306 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.0.x |--- --- Comment #10 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 2.0.x milestone from bugs included in 2.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org