[Bug 13241] New: ALSA Midi port names
http://bugs.winehq.org/show_bug.cgi?id=13241 Summary: ALSA Midi port names Product: Wine Version: 1.0-rc1 Platform: Other OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: free(a)64studio.com Created an attachment (id=13070) --> (http://bugs.winehq.org/attachment.cgi?id=13070) ALSA Midi subport names Hi, the current implementation of dlls/winealsa.drv/midi.c does only show the main name of an ALSA MIDI port, but not the names of the subports. Please consider the inclusion of this small patch which has been tested for several month now (since version 0.9.54), and is included in the wine build for the Mediastation keyboard (for running VST programs): http://www.lionstracs.com/store/ Thanks and keep on with this great project. Ciao, Free -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #1 from Juan Lang <juan_lang(a)yahoo.com> 2008-05-15 10:09:36 --- Patches should be sent to wine-patches(a)winehq.org , they're not picked up from here. Also, to save you some time, your patch will likely get rejected on the first pass. Things like this will cause rejection: @@ -1129,7 +1131,7 @@ return; MidiOutDev[MODM_NumDevs].addr = *snd_seq_port_info_get_addr(pinfo); - + Here you're adding whitespace for no good reason. Make sure your patch is clean of any whitespace changes before sending it in. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 --- Comment #2 from Free Ekanayaka <free(a)64studio.com> 2008-05-15 10:28:54 --- (From update of attachment 13070) --- dlls/winealsa.drv/midi.c.orig 2008-05-15 16:32:49.000000000 +0100 +++ dlls/winealsa.drv/midi.c 2008-05-15 16:33:53.000000000 +0100 @@ -388,8 +388,10 @@ lpMidiHdr->dwFlags &= ~MHDR_INQUEUE; lpMidiHdr->dwFlags |= MHDR_DONE; MidiInDev[wDevID].lpQueueHdr = (LPMIDIHDR)lpMidiHdr->lpNext; + LeaveCriticalSection(&crit_sect); if (MIDI_NotifyClient(wDevID, MIM_LONGDATA, (DWORD)lpMidiHdr, dwTime) != MMSYSERR_NOERROR) WARN("Couldn't notify client\n"); + break; } } else FIXME("No enough space in the buffer to store sysex!\n"); @@ -1146,7 +1148,7 @@ * not MIDICAPS_CACHE. */ MidiOutDev[MODM_NumDevs].caps.dwSupport = MIDICAPS_VOLUME|MIDICAPS_LRVOLUME; - MultiByteToWideChar(CP_ACP, 0, snd_seq_client_info_get_name(cinfo), -1, + MultiByteToWideChar(CP_ACP, 0, snd_seq_port_info_get_name(pinfo), -1, MidiOutDev[MODM_NumDevs].caps.szPname, sizeof(MidiOutDev[MODM_NumDevs].caps.szPname) / sizeof(WCHAR)); @@ -1201,7 +1203,7 @@ * not MIDICAPS_CACHE. */ MidiInDev[MIDM_NumDevs].caps.dwSupport = MIDICAPS_VOLUME|MIDICAPS_LRVOLUME; - MultiByteToWideChar(CP_ACP, 0, snd_seq_client_info_get_name(cinfo), -1, + MultiByteToWideChar(CP_ACP, 0, snd_seq_port_info_get_name(pinfo), -1, MidiInDev[MIDM_NumDevs].caps.szPname, sizeof(MidiInDev[MIDM_NumDevs].caps.szPname) / sizeof(WCHAR)); MidiInDev[MIDM_NumDevs].state = 0; -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 --- Comment #3 from Juan Lang <juan_lang(a)yahoo.com> 2008-05-15 10:32:53 --- That's better. One more comment: the first hunk of the patch appears unrelated to the change you're describing. One (logical) change per patch, please. Also, please send it to wine-patches(a)winehq.org, not here. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 Ove Kaaven <ovek(a)arcticnet.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovek(a)arcticnet.no --- Comment #4 from Ove Kaaven <ovek(a)arcticnet.no> 2008-05-16 02:26:26 --- This looks like a duplicate of #11177 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2008-05-16 12:36:40 --- *** Bug 11177 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 Christian Costa <titan.costa(a)wanadoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |titan.costa(a)wanadoo.fr --- Comment #6 from Christian Costa <titan.costa(a)wanadoo.fr> 2008-08-20 03:55:23 --- I sent a patch which is commited now. In the patch, both client and port names are used when possible otherwise we use the port name. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 --- Comment #7 from Christian Costa <titan.costa(a)wanadoo.fr> 2008-08-20 03:58:52 --- Off topic: BTW, are the LeaveCriticalSection and break, around MIDI_NotifyClient call, are supposed to fix something ? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 --- Comment #8 from Austin English <austinenglish(a)gmail.com> 2008-08-20 10:18:52 --- Please retest. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 Free Ekanayaka <free(a)64studio.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #9 from Free Ekanayaka <free(a)64studio.com> 2008-10-16 10:31:25 --- It works fine, I'm closing the bug. Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13241 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> 2008-10-24 11:13:29 --- Closing bugs fixed in 1.1.7. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org