[Bug 56781] New: srcrrun: Dictionary setting item to object fails
https://bugs.winehq.org/show_bug.cgi?id=56781 Bug ID: 56781 Summary: srcrrun: Dictionary setting item to object fails Product: Wine Version: 9.4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: scrrun Assignee: wine-bugs(a)winehq.org Reporter: francisdb(a)gmail.com Distribution: --- Reproducer in vbscript Class C End Class Dim cls1: Set cls1 = new C Dim cls2: Set cls2 = new C Dim dict: Set dict = createobject("scripting.dictionary") Dim key: key = "test" dict.Add key, cls1 Set dict.Item(key) = cls2 Looks like this is not implemented https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/scrrun/dictionary.c?r... Without understanding the code this should maybe increase the reference count and delegate to dictionary_put_Item? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56781 --- Comment #1 from francisdb <francisdb(a)gmail.com> --- wine cscript ./test.vbs Before 0120:fixme:scrrun:dictionary_putref_Item 0143F464, 01449108, 01449118 stub 0120:fixme:wscript:ActiveScriptSite_OnScriptError () -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56781 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- I don't see any semantic difference with put_Item(). Both will addref on get/set. I sent a fix https://gitlab.winehq.org/wine/wine/-/merge_requests/5795. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56781 --- Comment #3 from francisdb <francisdb(a)gmail.com> --- Thanks for the quick fix! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56781 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |0da33d5493814b8cb8309c092bd | |7c6e1c60f1868 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- This is now fixed, 0da33d5493814b8cb8309c092bd7c6e1c60f1868. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56781 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 9.11. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=56781 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |9.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=56781 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|9.0.x |--- --- Comment #6 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 9.0.x milestone from bug fixes included in 9.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla