[Bug 12979] New: Trucks&Trains game error in quartz.dll
http://bugs.winehq.org/show_bug.cgi?id=12979 Summary: Trucks&Trains game error in quartz.dll Product: Wine Version: 0.9.61. Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: quartz AssignedTo: wine-bugs(a)winehq.org ReportedBy: mike2006michael(a)mail.ru CC: mike2006michael(a)mail.ru Game - Tracks & Trains Tycoon Game graphics - DirectX or Open GL If i Use Open GL While I using wine 0.9.60 with this game there are no problems... I upgrade wine to 0.9.61 Now game crashes with error in quartz.dll If I use Windows dll quartz - game - runnning but very slowly If i Use DirectX With Direct X ,game don't want starting log fixme:win:EnumDisplayDevicesW ((null),0,0x1caf814,0x00000000), stub! fixme:d3d:test_pbo_functionality >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION (0x502) from Loading the PBO test texture @ directx.c / 3518 err:d3d:WineD3D_ChoosePixelFormat Can't find a suitable iPixelFormat fixme:xrandr:X11DRV_XRandR_SetCurrentMode Cannot change screen BPP from 32 to 16 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 --- Comment #1 from Michael Povarov <mike2006michael(a)mail.ru> 2008-05-04 23:43:44 --- Created an attachment (id=12729) --> (http://bugs.winehq.org/attachment.cgi?id=12729) log while using Opengl In this game -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Olivier Samyn <olivier-ml1(a)oleastre.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olivier-ml1(a)oleastre.be --- Comment #2 from Olivier Samyn <olivier-ml1(a)oleastre.be> 2008-05-05 16:39:10 --- I got a similar problem with gta vicecity. It works fine with wine 0.9.60 but, with wine 0.9.61, it crashes (segfault) in the quartz.dll (using wine builtin one). So, for me it's a regression, and I will try to bisect it once I get a little bit of time. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 --- Comment #3 from Olivier Samyn <olivier-ml1(a)oleastre.be> 2008-05-06 18:12:29 --- I located the problem. In the following code from dlls/quartz/filesource.c, sometimes, *pin is null (ie This->pOutputPin). I just added a return S_FALSE in that case and it works again for me. Small patch below: diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c index f410b56..a4e708f 100644 --- a/dlls/quartz/filesource.c +++ b/dlls/quartz/filesource.c @@ -533,6 +533,10 @@ static HRESULT AsyncReader_GetPin(IBaseFilter *iface, ULONG return S_FALSE; *pin = (IPin *)This->pOutputPin; + + if(!(*pin)) + return S_FALSE; + IPin_AddRef(*pin); return S_OK; } -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 --- Comment #4 from Olivier Samyn <olivier-ml1(a)oleastre.be> 2008-05-06 18:14:53 --- Created an attachment (id=12784) --> (http://bugs.winehq.org/attachment.cgi?id=12784) Small patch adding a null test Patch copy paste in comments are always bad. So here is the correct patch version as an attachment. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 --- Comment #5 from Michael Povarov <mike2006michael(a)mail.ru> 2008-05-07 06:20:40 --- It works!!Thank you ever so much -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Michael Povarov <mike2006michael(a)mail.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #6 from Michael Povarov <mike2006michael(a)mail.ru> 2008-05-07 09:26:47 --- _ -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2008-05-07 09:29:05 --- (In reply to comment #6)
_
Not fixed. The patch hasn't been committed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Lei Zhang <thestig(a)google.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m_105(a)gmx.de --- Comment #8 from Lei Zhang <thestig(a)google.com> 2008-05-08 20:01:01 --- *** Bug 13047 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Maarten Lankhorst <m.b.lankhorst(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winehq(a)pento.net --- Comment #9 from Maarten Lankhorst <m.b.lankhorst(a)gmail.com> 2008-05-09 17:19:54 --- *** Bug 13000 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Florian <mcflow-forum(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #10 from Florian <mcflow-forum(a)gmx.net> 2008-05-10 05:47:33 --- *** This bug has been confirmed by popular vote. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 --- Comment #11 from Gary Pendergast <winehq(a)pento.net> 2008-05-10 08:46:29 --- Given that this is a small bug with a simple patch, can it be targeted for 1.0.0? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Florian <mcflow-forum(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcflow-forum(a)gmx.net --- Comment #12 from Florian <mcflow-forum(a)gmx.net> 2008-05-11 05:09:55 --- (In reply to comment #5)
It works!!Thank you ever so much
This patch also works for GTA:SA with wine-1.0-rc1 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 --- Comment #13 from Austin English <austinenglish(a)gmail.com> 2008-05-11 22:20:39 --- (In reply to comment #11)
Given that this is a small bug with a simple patch, can it be targeted for 1.0.0?
If the patch is small and correct, there's a good chance it'll be applied. I don't think this app warrants adding another bug to 1.0 list, especially this close to release. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 --- Comment #14 from Gary Pendergast <winehq(a)pento.net> 2008-05-13 19:59:07 --- Patch fixes Audiosurf when applied to Git HEAD. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Juan Lang <juan_lang(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #15 from Juan Lang <juan_lang(a)yahoo.com> 2008-05-15 19:46:43 --- Now the fix is in git, so it's been fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #16 from Alexandre Julliard <julliard(a)winehq.org> 2008-05-23 10:38:09 --- Closing bugs fixed in 1.0-rc2. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=12979 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other --- Comment #17 from Austin English <austinenglish(a)gmail.com> 2012-02-23 15:25:53 CST --- Removing deprecated 'All' Platform. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org