[Bug 39014] New: ddraw, o2jam having pink artifacts on wine 1.7.48
https://bugs.winehq.org/show_bug.cgi?id=39014 Bug ID: 39014 Summary: ddraw, o2jam having pink artifacts on wine 1.7.48 Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: onte_jc(a)yahoo.com Distribution: --- ddraw, o2jam having pink artifacts on wine 1.7.48 you can try it out here it calls for ddraw, it works fine, until you play one song, you will see pink artifacts, make sure you enabled the 3d on the options install .net 2.0 and 4.0 http://o2jam.intgamerz.net/index.php -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 jc onte <onte_jc(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |onte_jc(a)yahoo.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 jc onte <onte_jc(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |Ubuntu -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 jc onte <onte_jc(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 jc onte <onte_jc(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://o2jam.intgamerz.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 jc onte <onte_jc(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |1.7.48 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #1 from jc onte <onte_jc(a)yahoo.com> --- Created attachment 51994 --> https://bugs.winehq.org/attachment.cgi?id=51994 pink issue, it should be transparent -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #2 from jc onte <onte_jc(a)yahoo.com> --- Created attachment 51995 --> https://bugs.winehq.org/attachment.cgi?id=51995 while playing, still the pink issue, 1.6.2 works ok, but 1.7.48 not, lag issue is improved -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression CC| |gyebro69(a)gmail.com Severity|critical |normal --- Comment #3 from Béla Gyebrószki <gyebro69(a)gmail.com> --- (In reply to jc onte from comment #2)
Created attachment 51995 [details] while playing, still the pink issue, 1.6.2 works ok, but 1.7.48 not, lag issue is improved
If the game used to work in older Wine versions then it is probably a regression. Please perform a regression test to find out which commit broke it. http://wiki.winehq.org/RegressionTesting -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ddraw, o2jam having pink |O2Jam renders pink |artifacts on wine 1.7.48 |artifacts -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|onte_jc(a)yahoo.com | --- Comment #4 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Please attach the full console output. http://wiki.winehq.org/Bugs -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #6 from Béla Gyebrószki <gyebro69(a)gmail.com> --- (In reply to jc onte from comment #5)
can you give me a tutorial on the regression testing?, so i can provide more info
The page that I linked for you in comment #3 has a detailed description of the regression testing procedure. If you need further assistance please seek help on the official WineHQ forum (https://forum.winehq.org/) or feel free to ask on IRC: irc.freenode.net#winehq -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |stefan(a)codeweavers.com Component|-unknown |directx-d3d Summary|O2Jam renders pink |Multiple games render pink |artifacts |artifacts (O2Jam, Stranded | |II, SpaceRace) Ever confirmed|0 |1 Regression SHA1| |5d51c97d07b5730791226799658 | |6d05528f652a5 --- Comment #7 from Béla Gyebrószki <gyebro69(a)gmail.com> --- It turned out that the bug/regression reported here is due to the same commit that reintroduced bug #37748 for me. The result of the regression test: commit 5d51c97d07b57307912267996586d05528f652a5 Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Fri Apr 10 12:05:54 2015 +0200 wined3d: Implement color keying in the glsl fragment pipeline. You can reproduce the problem either with this O2Jam game (needs registration plus you need to download at least one music pack), or you can use Stranded II from bug #37748. SpaceRace, a freeware game from Intermediaware also has the same problem, it's only 5 MB: http://www.intermediaware.com/downloads/SpaceRace_Setup.exe All those games have the reported issue due to that commit. Reproduced with nvidia binary drivers and nouveau/mesa git. Disabling GLSL doesn't make it better. Terminal output from Stranded II:
fixme:win:EnumDisplayDevicesW ((null),0,0x33f408,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x33f188,0x00000000), stub! ... fixme:d3d:wined3d_get_adapter_raster_status wined3d 0x132200, adapter_idx 0, raster_status 0x33fc98 semi-stub! fixme:ddraw:ddraw_surface7_Flip Ignoring flags 0x1.
Wine 1.7.49 Fedora 22 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #8 from jc onte <onte_jc(a)yahoo.com> --- any way to fix this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #9 from Stefan Dösinger <stefan(a)codeweavers.com> --- Created attachment 52053 --> https://bugs.winehq.org/attachment.cgi?id=52053 wined3d: Use the correct color key in ARBfp color key blits. Does this patch fix the issue? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #10 from jc onte <onte_jc(a)yahoo.com> --- not working, there still pink -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #11 from Stefan Dösinger <stefan(a)codeweavers.com> --- It works in Space Race for me. Which game did you test? Probably the problems are caused by different bugs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #12 from Béla Gyebrószki <gyebro69(a)gmail.com> --- (In reply to Stefan Dösinger from comment #9)
Created attachment 52053 [details] wined3d: Use the correct color key in ARBfp color key blits.
Does this patch fix the issue?
The patch fixes the problem in Stranded II and SpaceRace, O2Jam indeed behaves differently: the pink rectangles are still there when playing the game in 2-players mode (couple mode). On the other hand, when starting a single-player match those artifacts are no longer present.Without the patch the pink artefacts are present in both game modes. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #13 from jc onte <onte_jc(a)yahoo.com> --- Created attachment 52055 --> https://bugs.winehq.org/attachment.cgi?id=52055 settings you should do this kind of settings if you want to really test the pink issue -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #14 from Stefan Dösinger <stefan(a)codeweavers.com> --- O2Jam contains a few suspicious files: libwine.dll, opengl32.dll, wined3d.dll. Interestingly it does not contain a ddraw.dll, and I have no idea what it's doing with a replacement opengl32.dll. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #15 from jc onte <onte_jc(a)yahoo.com> --- (In reply to Stefan Dösinger from comment #14)
O2Jam contains a few suspicious files: libwine.dll, opengl32.dll, wined3d.dll. Interestingly it does not contain a ddraw.dll, and I have no idea what it's doing with a replacement opengl32.dll.
you can delete that one, i did put that opengl32 just to fix the process staying even though you close the game -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #16 from Stefan Dösinger <stefan(a)codeweavers.com> --- Created attachment 52058 --> https://bugs.winehq.org/attachment.cgi?id=52058 Don't require an exact color key match The O2Jam problem seems to be a precision issue. The game uses an R5G6B5 texture, and the color key is 31/20/31, which translates to r=1.0, g=20/63, b=1.0. The rounding of the green value is different between our color key calculation and the normalization during texture sampling, causing the key not to match. The attached patch allows a small mismatch, which seems to fix the game. We need some tests for this though to make sure we're not matching keys we shouldn't match, and we need the same change in the ARB and GLSL fixed function fragment shader. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #17 from jc onte <onte_jc(a)yahoo.com> --- wow that fixed the problem, its working correctly -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #18 from jc onte <onte_jc(a)yahoo.com> --- ok to add more issue on the list, it doesnt close the process, the process stays on the background even though you already exits the game -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #19 from Béla Gyebrószki <gyebro69(a)gmail.com> --- (In reply to jc onte from comment #18)
ok to add more issue on the list, it doesnt close the process, the process stays on the background even though you already exits the game
Each bug report should cover only one problem, feel free to open a new bug report about that problem. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #20 from Bruno Jesus <00cpxxx(a)gmail.com> --- Just for information today O2JAM news states: GOOD NEWS TO ALL WINDOWS 8, 8.1 and 10 users, lags already fixed, and no more pink artifacts problems, tomorrow i will release the patch for the compatibility -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #21 from jc onte <onte_jc(a)yahoo.com> --- (In reply to Bruno Jesus from comment #20)
Just for information today O2JAM news states: GOOD NEWS TO ALL WINDOWS 8, 8.1 and 10 users, lags already fixed, and no more pink artifacts problems, tomorrow i will release the patch for the compatibility
ohh i did that news, because im the admin, so we use your wine dll files for support on windows 8 up to 10 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 Woojin Na <zaqzaq0802(a)naver.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zaqzaq0802(a)naver.com --- Comment #22 from Woojin Na <zaqzaq0802(a)naver.com> --- 1.7.49 have new problem. - input lagging. - frame drop when playing songs. - process will not kill itself even if exit the game. - AMD / Intel graphic user must be use force-8bit-color-mode. if will not, game will not work. (nvidia OK) 1.7.50 have new problem. - pink color crash again (at nvidia only) - frame drop improve a little. - input lagging. - process will not kill itself even if exit the game. - AMD / Intel graphic user must be use force-8bit-color-mode. if will not, game will not work. (nvidia OK) well, 1.3.11? that old version is best when game play (play songs). It have most smooth frame. but it have lots of other problem. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #23 from Stefan Dösinger <stefan(a)codeweavers.com> --- Please file separate bugs for those problems. This bug is already too complicated and contains too many separate issues. Stranded II and SpaceRace should be fixed by commit 6626b1a51b78bac189e184162db7102c2bd12e86. Color keying in O2Jam should be fixed by http://source.winehq.org/patches/data/113889 once it is in. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 Stefan Dösinger <stefan(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |1a965811f661b841f877df5706f | |5a2dc7771a89a Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #24 from Stefan Dösinger <stefan(a)codeweavers.com> --- 1a965811f661b841f877df5706f5a2dc7771a89a should be the last part for fixing the color keying issues mentioned here. I'm marking this bug fixed, for any other bugs regarding these games please open a new report. Feel free to CC me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #25 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.51. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=39014 --- Comment #26 from Woojin Na <zaqzaq0802(a)naver.com> --- (In reply to Alexandre Julliard from comment #25)
Closing bugs fixed in 1.7.51.
All problem is remaining. (at AMD R9 290 / windows 10 ) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org