[Bug 45689] New: Quik 7: Regression in ComboBox after " Introduce ComboBox control" commit - empty drop-down list
https://bugs.winehq.org/show_bug.cgi?id=45689 Bug ID: 45689 Summary: Quik 7: Regression in ComboBox after "Introduce ComboBox control" commit - empty drop-down list Product: Wine Version: 3.14 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: akv(a)etersoft.ru Distribution: --- Overview: wine-3.14 Empty drop-down list when I try to choose a brokerage account in “New Order” window. As a result, a market order cannot be sent. Steps to Reproduce: Install: 1) Download the app by link http://arqatech.com/upload/iblock/68d/Quik_v7.19.0_ENG.exe 2) wine Quik_v7.19.0_ENG.exe 3) Click Next until end Reproduce: 1) Login is valid until 09/22/2018. I will update after this date. User:U0127031 Pass:04209 2) Click on a ticker in the tickers table and press F2. The “New Order” window appears 3) Try to choose an account at the right upper combobox Actual Result: The CombBox hasn't set a default account and the drop-down list is empty. Expected: The ComboBox has already set a default account and the drop-down list isn't empty Regression testing: The last wine version that works fine with the same version of QUIK is 3.1. So I've done regression testing between 3.1 and 3.2 by manual from here https://wiki.winehq.org/Regression_Testing#Running_the_bisection and found the first problem commit: c9e98034b37f44d505ba406f94031d02e226a176 is the first bad commit commit c9e98034b37f44d505ba406f94031d02e226a176 Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Feb 13 10:56:36 2018 +0300 comctl32: Introduce ComboBox control. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> :040000 040000 de95ff28d86354aaaa40b8d1757ce6e82d140705 b22b611e6afe490e3e54029f11dc62d5be7a7b1e M dlls -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 --- Comment #1 from akw <akv(a)etersoft.ru> --- Created attachment 62114 --> https://bugs.winehq.org/attachment.cgi?id=62114 ComboBox regression I made a pucture showing the regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 akw <akv(a)etersoft.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |c9e98034b37f44d505ba406f940 | |31d02e226a176 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 akw <akv(a)etersoft.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |akv(a)etersoft.ru -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- Could you try with current wine, specifically commit 313c63e194aebdd517b3a85f8fe4d83acf170b62? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Keywords| |regression Status|UNCONFIRMED |NEW --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- Tested it myself, can confirm. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- Thanks for reporting, what a stupid little issue. The program doesn't add the combobox items the usual way, instead it enumerates the window to get the combobox, and then sends the listbox the new elements directly. However, this only works when it finds the combobox properly - but the name was mispelled as "Combobox" while it should be "ComboBox". Patch to fix the issue: https://source.winehq.org/patches/data/150043 Note that you will need a proper rebuild, or it won't work. Don't ask me why though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Fabian Maurer from comment #4)
Patch to fix the issue: https://source.winehq.org/patches/data/150043 Note that you will need a proper rebuild, or it won't work. Don't ask me why though.
I think you only need to fix installed manifest, and rebuild the dll. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 --- Comment #6 from Fabian Maurer <dark.shadow4(a)web.de> --- I don't know, rebuilding the dll wasn't enough. What do you mean by "fix installed manifest"? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 --- Comment #7 from akw <akv(a)etersoft.ru> --- (In reply to Fabian Maurer from comment #4)
Thanks for reporting, what a stupid little issue.
The program doesn't add the combobox items the usual way, instead it enumerates the window to get the combobox, and then sends the listbox the new elements directly. However, this only works when it finds the combobox properly - but the name was mispelled as "Combobox" while it should be "ComboBox".
Patch to fix the issue: https://source.winehq.org/patches/data/150043 Note that you will need a proper rebuild, or it won't work. Don't ask me why though.
So, I did this actions: 1) wget https://source.winehq.org/patches/data/150043 2) git clone git://source.winehq.org/git/wine.git && cd wine 3) git am ../150043 Applying: comctl32: Correct spelling for ComboBox window class 4) # checked the last commit git log | head commit 9090c8e84c8a57fedbe0758f4ae84ac89bb05dc5 Author: Fabian Maurer <dark.shadow4(a)web.de> Date: Wed Aug 22 22:17:29 2018 +0200 comctl32: Correct spelling for ComboBox window class Some programs try to get the class name, so this needs to have correct casing. Note: For some reason, you will need a proper clean to see the changes 5) ./configure --verbose --disable-tests && make clean && make depend && jmake And the problem is still there. What do you mean by "proper rebuild"? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 --- Comment #8 from akw <akv(a)etersoft.ru> --- Sorry, that was my mistake in test script. I launched a system installed wine. (In reply to akw from comment #7)
And the problem is still there.
Sorry, that was my mistake in a test script. I launched a system installed wine. At now I've checked wine from a source dir with the attached patch. The problem is gone. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 --- Comment #9 from Fabian Maurer <dark.shadow4(a)web.de> ---
At now I've checked wine from a source dir with the attached patch. The problem is gone.
Good to hear, but I'll need to rework the patch - on windows the spelling is also like that... There must be an issue somewhere else, I'll look into it! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 --- Comment #10 from Fabian Maurer <dark.shadow4(a)web.de> --- Updated patch: https://source.winehq.org/patches/data/150121 Hopefully this time the right solution. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Quik 7: Regression in |Quik 7: Combobox is not |ComboBox after "Introduce |populated properly |ComboBox control" commit - | |empty drop-down list | Component|comctl32 |user32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |78236592df22e152c6be3b43871 | |a3e1faeb41df0 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> --- This should be fixed now, 78236592df22e152c6be3b43871a3e1faeb41df0. Please test. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 --- Comment #12 from akw <akv(a)etersoft.ru> --- wine-3.14-214-g96a6053 compiled from source in a separate dir. ComboBox works correctly. So problem is solved in 3.14-214-g96a6053 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45689 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.15. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org