[Bug 17517] New: crypt32/sip tests fail with +relay enabled
http://bugs.winehq.org/show_bug.cgi?id=17517 Summary: crypt32/sip tests fail with +relay enabled Product: Wine Version: 1.1.15 Platform: PC URL: http://test.winehq.org/data/86f79e3a558ca1fb5d596e9f6240 3ca89178d3cf/wine_xp_ae-ub904-relay/crypt32:sip.html OS/Version: Linux Status: NEW Keywords: download, source, testcase Severity: enhancement Priority: P2 Component: crypt32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: austinenglish(a)gmail.com sip.c:383: Test failed: Expected function addresses to be from crypt32 sip.c:425: Test failed: Expected function addresses to be from crypt32 sip: 51 tests executed (0 marked as todo, 2 failures), 0 skipped. Maybe a race condition? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WONTFIX --- Comment #1 from Alexandre Julliard <julliard(a)winehq.org> 2009-02-24 16:37:39 --- +relay adds a wrapper around functions, so it's normal that addresses no longer match. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 --- Comment #2 from Alexandre Julliard <julliard(a)winehq.org> 2009-02-24 16:39:51 --- *** Bug 17522 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 --- Comment #3 from Alexandre Julliard <julliard(a)winehq.org> 2009-02-24 16:40:38 --- *** Bug 17523 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2009-02-24 18:03:31 --- Is the qmgr bug (bug 17521) still valid then? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2009-02-25 02:57:52 --- Closing. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> 2009-02-25 03:30:05 --- (In reply to comment #4)
Is the qmgr bug (bug 17521) still valid then?
I haven't investigated it, but at first glance it looks like a different issue. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2009-02-25 10:43:56 --- (In reply to comment #1)
+relay adds a wrapper around functions, so it's normal that addresses no longer match.
Would you accept a patch to skip the tests/mark as broken if +relay is enabled? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 --- Comment #8 from Juan Lang <juan_lang(a)yahoo.com> 2009-02-25 11:39:46 --- (In reply to comment #7)
Would you accept a patch to skip the tests/mark as broken if +relay is enabled?
I can't speak for AJ, but that sounds like a good idea to me. We might get spurious test failure reports otherwise. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 --- Comment #9 from Austin English <austinenglish(a)gmail.com> 2009-02-25 11:46:06 --- (In reply to comment #8)
(In reply to comment #7)
Would you accept a patch to skip the tests/mark as broken if +relay is enabled?
I can't speak for AJ, but that sounds like a good idea to me. We might get spurious test failure reports otherwise.
That's my thinking. I've added them to the wiki in MakeTestFailures, but I'm forgetful and may forget about it later. Looking at http://test.winehq.org/data/b86552f58d96f3bf3b324a6ed115a1c4a846174d/#group_..., there's only a few places it's needed (crypt32/sip, rpcrt4/cstub, user32/class). Plus, makes test.winehq.org/data look prettier :-). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17517 --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> 2009-02-25 12:24:12 --- No, I don't think we want workarounds in the tests. Anyway I don't see much value in running the tests with +relay, it's unlikely to catch any real problem. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org