[Bug 52285] New: 7-zip: column titles are not rendered initially when using a theme
https://bugs.winehq.org/show_bug.cgi?id=52285 Bug ID: 52285 Summary: 7-zip: column titles are not rendered initially when using a theme Product: Wine Version: 7.0-rc1 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: uxtheme Assignee: wine-bugs(a)winehq.org Reporter: aros(a)gmx.com Distribution: --- Created attachment 71421 --> https://bugs.winehq.org/attachment.cgi?id=71421 7-zip themed See the attached screenshot. If you interact with the columns in any way titles will appear. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #1 from Artem S. Tashkinov <aros(a)gmx.com> --- Created attachment 71422 --> https://bugs.winehq.org/attachment.cgi?id=71422 7-zip unthemed -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Artem S. Tashkinov <aros(a)gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Artem S. Tashkinov <aros(a)gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://www.7-zip.org/a/7z2 | |106.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #2 from Artem S. Tashkinov <aros(a)gmx.com> --- To be honest 7-zip rendering under Wine is broken even without themes: when you resize the program window, various parts of it stop rendering/repainting properly. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #3 from Artem S. Tashkinov <aros(a)gmx.com> --- Created attachment 71424 --> https://bugs.winehq.org/attachment.cgi?id=71424 7-zip under Windows XP One last nitpick not sure if it warrants a separate bug report. Under Windows with the Zune theme, the status bar separators are painted white in Wine and black(ish) in Windows. See the attached screenshot. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #4 from Artem S. Tashkinov <aros(a)gmx.com> --- Created attachment 71425 --> https://bugs.winehq.org/attachment.cgi?id=71425 7-zip themed options And another nitpick. In 7-zip running themed under Wine checkboxes in the scrollbox (7-zip options) lose the gradient background - it's #FFFFFFF throughout. So, probably we have three bugs here. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Artem S. Tashkinov <aros(a)gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|7.0-rc1 |7.0-rc2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Confirmed with wine-7.0-rc3. I will look into this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #6 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 71449 --> https://bugs.winehq.org/attachment.cgi?id=71449 patch Fix the invisible listview header issue. For other aforementioned theming issues, I might take a look as well. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|uxtheme |comctl32 Version|7.0-rc2 |7.0-rc3 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #7 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 71462 --> https://bugs.winehq.org/attachment.cgi?id=71462 Fix incorrect status bar separators 1/2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #8 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 71463 --> https://bugs.winehq.org/attachment.cgi?id=71463 Fix incorrect status bar separators 2/2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #9 from Artem S. Tashkinov <aros(a)gmx.com> --- (In reply to Zhiyi Zhang from comment #8)
Created attachment 71463 [details] Fix incorrect status bar separators 2/2
Great many thanks for your dedicated work. comctl32 has seen almost no updates for the past couple of years. Hopefully your patches won't lead to major regressions 'cause from what I remember the painting code is very brittle. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #10 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- The invisible listview header patch is upstreamed at 5f0dcf79185941c4faff35d1cc9c758160f3a27d -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 --- Comment #11 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 71471 --> https://bugs.winehq.org/attachment.cgi?id=71471 Fix check boxes in listview not themed -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Julian RĂ¼ger <jr98(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jr98(a)gmx.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 winetaste(a)gmx.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetaste(a)gmx.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |5f0dcf79185941c4faff35d1cc9 | |c758160f3a27d Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Closing. The invisible header issue is fixed by 5f0dcf79185941c4faff35d1cc9c758160f3a27d. Patches for other issues will be sent after the code freeze. If there are other issues not discussed here, please open new reports. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52285 Jinoh Kang <jinoh.kang.kr(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jinoh.kang.kr(a)gmail.com --- Comment #14 from Jinoh Kang <jinoh.kang.kr(a)gmail.com> --- I think the actual cause of this issue may be due to incorrect window redraw algorithm in Wine. Note that 7-zip clears the WS_VISIBLE flag (via WM_SETREDRAW) from the list view before refreshing the list: https://github.com/mcmilk/7-Zip/blob/c2a1bdb0235368e80cf6d434baf448c94469e04.... This may explain why the theme background drawn by WM_NCPAINT is not later overlaid by client contents. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla