[Bug 43236] New: F.E.A.R, Condemned: Criminal Origins have no in-game audio
https://bugs.winehq.org/show_bug.cgi?id=43236 Bug ID: 43236 Summary: F.E.A.R, Condemned: Criminal Origins have no in-game audio Product: Wine Version: 2.11 Hardware: x86 URL: https://megagames.com/demos/condemned-demo OS: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: winemp3.acm Assignee: wine-bugs(a)winehq.org Reporter: gyebro69(a)gmail.com CC: z.figura12(a)gmail.com Regression SHA1: ae34a0f5407ffac492e9bfb5ce5b4267183ea4c5 Distribution: --- Created attachment 58543 --> https://bugs.winehq.org/attachment.cgi?id=58543 Condemned:CO audio debug log Audio works only in the game logo intro videos, but the games are running without audio. Reproduced in F.E.A.R. (+expansions) and in Condemned: Criminal Origins. Demo is available for both games. Reverting the following commit fixes the problem: commit ae34a0f5407ffac492e9bfb5ce5b4267183ea4c5 Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Fri Jun 9 18:08:28 2017 -0500 winemp3.acm: Disallow operations encoding to MPEG. condemned_criminal_origins_demo.exe (455 M) sha1: 733d1f37ca9628fa5cecb6ead39c8f80227a9041 Arch Linux (64-bit) Wine 2.11 (32-bit) Pulseaudio 10.0 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 --- Comment #1 from Béla Gyebrószki <gyebro69(a)gmail.com> --- Created attachment 58544 --> https://bugs.winehq.org/attachment.cgi?id=58544 F.E.A.R. 2 crashes on start Also affects F.E.A.R. 2: Project Origin. The game crashes shortly after started. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 Paul Bredbury <brebs(a)sent.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brebs(a)sent.com --- Comment #2 from Paul Bredbury <brebs(a)sent.com> --- I confirm this bug, and the patch that caused it. Tested in FEAR 1: https://appdb.winehq.org/objectManager.php?sClass=application&iId=2878 Reversing this patch, in Wine 2.11, causes audio to play again: https://source.winehq.org/git/wine.git/commit/ae34a0f5407ffac492e9bfb5ce5b42... (I use plain ALSA, not pulseaudio.) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 --- Comment #3 from Zebediah Figura <z.figura12(a)gmail.com> --- Thank you for reporting this bug. It doesn't immediately look like the driver is trying to convert into mp3, but rather may be using the winemp3 driver to convert between native PCM formats. Could we get a debug trace without this patch? That should make finding the problem trivial. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 --- Comment #4 from Béla Gyebrószki <gyebro69(a)gmail.com> --- Created attachment 58566 --> https://bugs.winehq.org/attachment.cgi?id=58566 audio debug log with reverted patch (Condemned:CO) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 --- Comment #5 from Béla Gyebrószki <gyebro69(a)gmail.com> --- Created attachment 58567 --> https://bugs.winehq.org/attachment.cgi?id=58567 audio debug log with reverted patch (F.E.A.R. 2) Reverting the patch fixes the early crash in F.E.A.R. 2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 abienz(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abienz(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 --- Comment #6 from Zebediah Figura <z.figura12(a)gmail.com> --- The program seems to be calling acmFormatEnum() on each driver and checking whether each format can convert into a given PCM format. The commit in question prevents acmFormatEnum() from listing mp3 formats, but as tests show this is the correct behaviour. So it's not impossible there's something else going on here. As it is it may be best just to stage a revert to ae34a0f5. The issue it was meant to fix is much less important. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/winemp3.acm-Re | |vert_MPEG_Encode Status|NEW |STAGED CC| |dmitry(a)baikal.ru, | |erich.e.hoover(a)wine-staging | |.com, michael(a)fds-team.de, | |sebastian(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 --- Comment #7 from Zebediah Figura <z.figura12(a)gmail.com> --- Created attachment 59485 --> https://bugs.winehq.org/attachment.cgi?id=59485 Rename winemp3.acm to l3codeca.acm. Apologies it took so long to track this down. Does the attached patch fix the bug for you? (You may need to start in a fresh WINEPREFIX, although the patch worked for me without doing so.) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 --- Comment #8 from Béla Gyebrószki <gyebro69(a)gmail.com> --- (In reply to Zebediah Figura from comment #7)
Created attachment 59485 [details] Rename winemp3.acm to l3codeca.acm.
Apologies it took so long to track this down. Does the attached patch fix the bug for you? (You may need to start in a fresh WINEPREFIX, although the patch worked for me without doing so.)
The patch fixes the problem here, thank you. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 --- Comment #9 from Zebediah Figura <z.figura12(a)gmail.com> --- Committed as bcc8791bc18f6c430cc2e29a2fd1641da77f7c9b. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|STAGED |RESOLVED CC| |joseph.kucia(a)gmail.com Fixed by SHA1| |bcc8791bc18f6c430cc2e29a2fd | |1641da77f7c9b --- Comment #10 from Józef Kucia <joseph.kucia(a)gmail.com> --- (In reply to Zebediah Figura from comment #9)
Committed as bcc8791bc18f6c430cc2e29a2fd1641da77f7c9b.
Fixed in Wine 2.19 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=43236 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #11 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.20. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org