[Bug 52216] New: winemac.drv fails to compile without Metal support
https://bugs.winehq.org/show_bug.cgi?id=52216 Bug ID: 52216 Summary: winemac.drv fails to compile without Metal support Product: Wine Version: 7.0-rc1 Hardware: x86-64 OS: Mac OS X Status: UNCONFIRMED Severity: major Priority: P2 Component: winemac.drv Assignee: wine-bugs(a)winehq.org Reporter: gcenx83(a)gmail.com When compiling wine using the MacOSX10.10.SDK or MacOSX10.11.SDK with metal disabled winemac.drv fails to compile. For reference see my build errors when using the proposed (incorrect patch) https://www.winehq.org/pipermail/wine-devel/2021-December/203171.html -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 Gcenx <gcenx83(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 Gcenx <gcenx83(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gcenx83(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 Gcenx <gcenx83(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|7.0-rc1 |6.17 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 --- Comment #1 from Gcenx <gcenx83(a)gmail.com> --- Still need to run a regression test but this has been broken since 6.17 as 6.16 was the last version that can build winemac.drv without Metal. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 Gcenx <gcenx83(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |a5cf847aa45c38bae1500ef19a9 | |bac -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 --- Comment #2 from Gcenx <gcenx83(a)gmail.com> --- Added the regression commit as per Chip as they’ve confirmed the breakage and the fist commit that changed this behavior. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 Reinhold <reinhold.hoffmann(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |reinhold.hoffmann(a)hotmail.c | |om --- Comment #3 from Reinhold <reinhold.hoffmann(a)hotmail.com> --- May be this bug is related to Bug 52231 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 Huw Davies <huw.davies(a)physics.ox.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |huw.davies(a)physics.ox.ac.uk --- Comment #4 from Huw Davies <huw.davies(a)physics.ox.ac.uk> --- (In reply to Gcenx from comment #0)
When compiling wine using the MacOSX10.10.SDK or MacOSX10.11.SDK with metal disabled winemac.drv fails to compile.
For reference see my build errors when using the proposed (incorrect patch) https://www.winehq.org/pipermail/wine-devel/2021-December/203171.html
Dean, later in that thread you say that you are able to build using the proposed patch, so is the proposed patch in fact correct? (I realise there's another issue relating to displaying windows, but that'll be a different bug). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 --- Comment #5 from Huw Davies <huw.davies(a)physics.ox.ac.uk> --- Created attachment 71527 --> https://bugs.winehq.org/attachment.cgi?id=71527 Proposed patch to fix non-metal builds For reference here's the proposed patch with the configure bit removed and the commit msg re-worded. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 --- Comment #6 from Gcenx <gcenx83(a)gmail.com> --- (In reply to Huw Davies from comment #5)
Created attachment 71527 [details] Proposed patch to fix non-metal builds
For reference here's the proposed patch with the configure bit removed and the commit msg re-worded.
Indeed this does resolve the build issue when compiling with non-metal SDK. Ididn’t open a new bug for the new issue that happens for none metal setups. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 --- Comment #7 from Huw Davies <huw.davies(a)physics.ox.ac.uk> --- (In reply to Gcenx from comment #6)
(In reply to Huw Davies from comment #5)
Created attachment 71527 [details] Proposed patch to fix non-metal builds
For reference here's the proposed patch with the configure bit removed and the commit msg re-worded.
Indeed this does resolve the build issue when compiling with non-metal SDK.
Thanks, I've sent this in again.
Ididn’t open a new bug for the new issue that happens for none metal setups.
Could you do that? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 Gcenx <gcenx83(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |52354 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 --- Comment #8 from Gcenx <gcenx83(a)gmail.com> --- (In reply to Huw Davies from comment #7)
(In reply to Gcenx from comment #6)
(In reply to Huw Davies from comment #5)
Created attachment 71527 [details] Proposed patch to fix non-metal builds
For reference here's the proposed patch with the configure bit removed and the commit msg re-worded.
Indeed this does resolve the build issue when compiling with non-metal SDK.
Thanks, I've sent this in again.
Ididn’t open a new bug for the new issue that happens for none metal setups.
Could you do that?
Done see https://bugs.winehq.org/show_bug.cgi?id=52354 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 Huw Davies <huw.davies(a)physics.ox.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |1f17015cea89cef3083ade0497e | |5eae5efdcb570 Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #9 from Huw Davies <huw.davies(a)physics.ox.ac.uk> --- Fixed with 1f17015cea89cef3083ade0497e5eae5efdcb570 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=52216 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.0-rc5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla