[Bug 10640] New: Change to modern Windows colours - not enough
http://bugs.winehq.org/show_bug.cgi?id=10640 Summary: Change to modern Windows colours - not enough Product: Wine Version: 0.9.50. Platform: Other OS/Version: other Status: UNCONFIRMED Severity: minor Priority: P2 Component: wine-user AssignedTo: wine-bugs(a)winehq.org ReportedBy: bammzilla(a)gabriana.com While I appreciate (and love) the patch by Alexander Nicolaysen Sørnes entitled "user32: Change to modern Windows colours", I think the change is not enough. I did a fresh install of Windows XP, and compared the colors found in the patch for DefSysColors to the Windows XP registry key "HKEY_CURRENT_USER\Control Panel\Colors" and found that the following still need to be changed: "ActiveTitle" from "0 0 128" to "10 36 106" "ButtonDkShadow" from "0 0 0" to "64 64 64" "ButtonLight" from "224 224 224" to "212 208 200" "GradientActiveTitle" from "16 132 208" to "166 202 240" "GradientInactiveTitle" from "181 181 181" to "192 192 192" "Hilight" from "0 0 128" to "10 36 106" "MenuHilight" from "0 0 0" to "10 36 106" In addition, Windows XP's registry contains the following entries not found in Wine's DefSysColors function: "ButtonAlternateFace"="181 181 181" "HotTrackingColor"="0 0 128" "InfoBorder"="41 3 2" "InfoText"="0 0 0" "InfoWindow"="255 255 225" Although Wine does not use the additions yet, it might be useful to have them too in case future enhancements to Wine needs them. I also suggest that the entries be arranged alphabetically for people browsing the code to easily find what they are looking for. I therefore suggest the following content for the DefSysColors function, properly alphabetized: static const char * const DefSysColors[] = { "ActiveBorder", "212 208 200", /* COLOR_ACTIVEBORDER */ "ButtonAlternateFace", "181 181 181" /* COLOR_BUTTONALTERNATEFACE */ "ActiveTitle", "0 0 128", /* COLOR_ACTIVECAPTION */ "AppWorkSpace", "128 128 128", /* COLOR_APPWORKSPACE */ "Background", "0 128 128", /* COLOR_BACKGROUND */ "ButtonDkShadow", "0 0 0", /* COLOR_3DDKSHADOW */ "ButtonFace", "212 208 200", /* COLOR_BTNFACE */ "ButtonHilight", "255 255 255", /* COLOR_BTNHIGHLIGHT */ "ButtonLight", "224 224 224", /* COLOR_3DLIGHT */ "ButtonShadow", "128 128 128", /* COLOR_BTNSHADOW */ "ButtonText", "0 0 0", /* COLOR_BTNTEXT */ "GradientActiveTitle", "16 132 208", /* COLOR_GRADIENTACTIVECAPTION */ "GradientInactiveTitle", "181 181 181", /* COLOR_GRADIENTINACTIVECAPTION */ "GrayText", "128 128 128", /* COLOR_GRAYTEXT */ "Hilight", "0 0 128", /* COLOR_HIGHLIGHT */ "HilightText", "255 255 255", /* COLOR_HIGHLIGHTTEXT */ "HotTrackingColor", "0 0 128" /* COLOR_HOTTRACKINGCOLOR */ "InactiveBorder", "212 208 200", /* COLOR_INACTIVEBORDER */ "InactiveTitle", "128 128 128", /* COLOR_INACTIVECAPTION */ "InactiveTitleText", "212 208 200", /* COLOR_INACTIVECAPTIONTEXT */ "InfoBorder", "41 3 2" /* COLOR_INFOBORDER */ "InfoText", "0 0 0" /* COLOR_INFOTEXT */ "InfoWindow", "255 255 225" /* COLOR_INFOWINDOW */ "Menu", "212 208 200", /* COLOR_MENU */ "MenuBar", "212 208 200" /* COLOR_MENUBAR */ "MenuHilight", "0 0 0", /* COLOR_MENUHILIGHT */ "MenuText", "0 0 0", /* COLOR_MENUTEXT */ "Scrollbar", "212 208 200", /* COLOR_SCROLLBAR */ "TitleText", "255 255 255", /* COLOR_CAPTIONTEXT */ "Window", "255 255 255", /* COLOR_WINDOW */ "WindowFrame", "0 0 0", /* COLOR_WINDOWFRAME */ "WindowText", "0 0 0", /* COLOR_WINDOWTEXT */ }; other files touched by Alexander's patch should be updated accordingly, such as display.rc, etc. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10640 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement Component|wine-user |wine-misc --- Comment #1 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2007-12-02 19:11:06 --- Make that a color only theme. I despise XP's colors and do not want to have them by default. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10640 --- Comment #2 from Bamm Gabriana <bammzilla(a)gabriana.com> 2007-12-02 19:51:09 --- Vitaliy, remember that we are not talking about our preferences here. We're talking about Wine's defaults matching Windows defaults. The modern Windows look has been committed and appears in 0.9.50. I'm just saying that Alexander Nicolaysen Sørnes missed a few, that's all. See: http://archives.free.net.ph/message/20071120.165503.a520af1e.en.html If you don't like the defaults, feel free to make your personal preferences into your color-only theme. I also have my own color theme, but I don't insist on it being everyone else's default. It would be nice if Wine had an option to match the color theme of Gnome or KDE but that would be another bug. Otherwise, proper behavior would be for apps to look and feel the same as they would in Windows. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10640 --- Comment #3 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2007-12-02 20:21:12 --- Last time I checked (and suggest you check that too) default for Wine was win2k. NOT xp! You are welcome to "fix" all other aspects of Wine to make it closer to XP. Then color could be part of that. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10640 --- Comment #4 from Bamm Gabriana <bammzilla(a)gabriana.com> 2007-12-02 21:30:25 --- Last time I checked (and suggest you check that too) the WinXP "Classic" colors defined in HKCU\Control Panel\Colors are the same as Win2k. I know that because I hate the Luna look too, and always use Windows Classic under XP. Prior to 0.9.50, the default colors of Wine were that of Win98 even though its default setup is Win2k. Perhaps haven't noticed the difference between Win98 and Win2k colors? Which brings me to another point: why not make the colors match the Windows version Wine is set to? For example, if Wine is set to Win98, then use Win98 colors. If Wine is set to either Win2k or WinXP, then use the Win2k/XP-classic colors. However, that should be another bug! You're straying away from the topic. This bug is just a minor correction to a patch by Alexander Nicolaysen Sørnes. Can someone add him to the CC list of this bug please? Thanks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10640 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex(a)thehandofagony.com Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #5 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-12-06 10:05:30 --- Thanks for the info. It definitely looks better. Patch sent. The only colour value missing from the Winde sources now is InfoBorder. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10640 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-12-07 11:22:16 --- Patch accepted. I couldn't find any references to the InfoBorder colour value anywhere, so I'll resolve this bug as fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10640 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Dan Kegel <dank(a)kegel.com> 2008-01-28 05:45:05 --- Closing all RESOLVED FIXED bugs older than four weeks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org