[Bug 14371] New: cleanup undefined members in vartest
http://bugs.winehq.org/show_bug.cgi?id=14371 Summary: cleanup undefined members in vartest Product: Wine Version: 1.0.0 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: oleaut32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: jreiser(a)BitWagon.com Created an attachment (id=14668) --> (http://bugs.winehq.org/attachment.cgi?id=14668) cleanup memcheck errors in vartest.c vartest.c uses undefined structure members; detected by valgrind(memcheck). Patch is attached, and will be sent to wine-patches(a)winehq.org. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14371 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-01-05 11:13:54 --- Is this still an issue in current (1.1.12 or newer) wine? Would you mind resubmitting the patch and asking for comments? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14371 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2009-07-16 13:08:50 --- Patch resent: http://www.winehq.org/pipermail/wine-patches/2009-July/075713.html Not applied. I think AJ doesn't like using memset, though I can't say for sure. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14371 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14371 --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2012-03-19 14:03:21 CDT --- Still present. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=14371 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=14371 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #4 from super_man(a)post.com --- patching file dlls/oleaut32/tests/vartest.c Hunk #1 succeeded at 5609 with fuzz 2 (offset 385 lines). still applies 1.7.51 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=14371 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de --- Comment #5 from Sebastian Lackner <sebastian(a)fds-team.de> --- It sounds the patch is trying to suppress some warning in oleaut32/vartest. If those warnings are no longer present in current versions of Wine and Valgrind it can be safely closed (fixed either on the Valgrind or Wine side). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=14371 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #6 from Austin English <austinenglish(a)gmail.com> --- (In reply to Sebastian Lackner from comment #5)
It sounds the patch is trying to suppress some warning in oleaut32/vartest. If those warnings are no longer present in current versions of Wine and Valgrind it can be safely closed (fixed either on the Valgrind or Wine side).
I don't see this with: austin(a)austin2:~/wine-valgrind$ git describe wine-2.3-135-gfaa6ff5 austin(a)austin2:~/wine-valgrind$ /opt/valgrind/bin/valgrind -v --version valgrind-3.13.0.SVN-16261-vex-3307 assuming fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=14371 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org