[Bug 22076] New: GOTO labels are not recognized if there are preceding spaces
http://bugs.winehq.org/show_bug.cgi?id=22076 Summary: GOTO labels are not recognized if there are preceding spaces Product: Wine Version: 1.1.40 Platform: x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: cmd AssignedTo: wine-bugs(a)winehq.org ReportedBy: gabspeck(a)gmail.com Created an attachment (id=26898) --> (http://bugs.winehq.org/attachment.cgi?id=26898) Example of a script with a GOTO statement that works on Windows but not on Wine. Wine's CMD is unable to recognize a label for the GOTO command if there are preceding spaces on it. This causes problems for the administration scripts included with Progress Software's OpenEdge solution. Some of these BAT scripts have indentation on some lines which causes them to fail on Wine if not manually altered to remove said spaces. They work perfectly fine on Windows. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26898|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-03-19 22:14:34 --- Created an attachment (id=26899) --> (http://bugs.winehq.org/attachment.cgi?id=26899) Eat spaces before testing for label I can confirm this, at least testing on XP. This is a quick patch, to include it we need also some tests. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26898|0 |1 is obsolete| | --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2010-03-20 00:24:35 --- Created an attachment (id=26900) --> (http://bugs.winehq.org/attachment.cgi?id=26900) testcase Here you go. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-03-20 07:37:57 --- (In reply to comment #2)
Created an attachment (id=26900) --> (http://bugs.winehq.org/attachment.cgi?id=26900) [details] testcase
Here you go.
Thanks, I think we also need a tab test. Could you submit it next week? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26900|0 |1 is obsolete| | --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2010-03-20 10:55:37 --- Created an attachment (id=26913) --> (http://bugs.winehq.org/attachment.cgi?id=26913) with tab test Here you go. Also tested on winetestbot (https://winetestbot.geldorp.nl/JobDetails.pl?Key=1102). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2010-03-23 11:03:09 --- Nikolay, would you mind submitting that patch? I'll follow with my testcase. Confirming, also. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-03-23 21:47:39 --- (In reply to comment #5)
Nikolay, would you mind submitting that patch? I'll follow with my testcase.
Confirming, also.
No, please take it and send with your tests. I really don't have time now. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2010-03-23 22:56:01 --- Sent: http://source.winehq.org/patches/data/59736 http://source.winehq.org/patches/data/59737 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-03-24 15:58:46 --- (In reply to comment #7)
Sent: http://source.winehq.org/patches/data/59736 http://source.winehq.org/patches/data/59737
Fixed by e22f6aa6e3e79de063d242e285b89881d701dfbe. Thanks, Austin. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=22076 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> 2010-04-02 12:52:30 --- Closing bugs fixed in 1.1.42. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org