[Bug 20516] New: Alt-F10 sent on press of F10 with wineconsole --backend=user
http://bugs.winehq.org/show_bug.cgi?id=20516 Summary: Alt-F10 sent on press of F10 with wineconsole --backend=user Product: Wine Version: 1.1.32 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: singularita(a)gmail.com I am using opensource FAR manager, run via "wineconsole --backend=user". In wine 1.1.32, when I press F10 (this key usually invokes dialog asking if you want to really quit FAR), Alt-F10 is sent to the program instead (Alt-F10 invokes the tree in FAR). Other F-keys (F1 .. F9, F11, F12) work normally. When I downgarded from 1.1.32 to 1.1.31, the bug disappeared and F10 started behaving normally. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 --- Comment #1 from Jeff Zaroyko <jeffz(a)jeffz.name> 2009-10-29 23:57:18 --- please post the results of your regression test http://wiki.winehq.org/RegressionTesting -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 MP <singularita(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ehoover(a)mines.edu --- Comment #2 from MP <singularita(a)gmail.com> 2009-10-30 11:40:13 --- I've done regression test and this is the result after 8 steps I got to this $ git bisect good 8c9a6e9f5cafa3306d9c0024a3e9635081678262 is the first bad commit commit 8c9a6e9f5cafa3306d9c0024a3e9635081678262 Author: Erich Hoover <ehoover(a)mines.edu> Date: Mon Oct 12 18:51:19 2009 -0600 winex11: Send WM_SYSKEYDOWN and WM_SYSKEYUP when the 'F10' key is used. :040000 040000 6a4ba862373aadc35642f690a9687e54a2612538 6c49297a03969156537c1c037005902eeb0f6864 M dlls Seems this is the patch that caused this bug -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 --- Comment #3 from Erich Hoover <ehoover(a)mines.edu> 2009-10-30 11:50:52 --- (In reply to comment #2)
I've done regression test and this is the result after 8 steps I got to this ... winex11: Send WM_SYSKEYDOWN and WM_SYSKEYUP when the 'F10' key is used. ... Seems this is the patch that caused this bug
I'll try to look into it this over the weekend. The patch I submitted changes the type of message for F10 from WM_KEY* to WM_SYSKEY* in order to match behavior on Windows. This behavior is similar to holding down ALT and pressing F10 in that holding ALT will cause any normal WM_KEY* to be reported as WM_SYSKEY*; however, the accelerator key for ALT should not be reported - so it should not be treated exactly the same as ALT+F10. Where can I get a hold of this application? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 --- Comment #4 from MP <singularita(a)gmail.com> 2009-10-30 11:59:33 --- (In reply to comment #3)
Where can I get a hold of this application?
Opensource far is available from http://farmanager.com/opensource.php?l=en The exact build I am using is this (revision 780): http://farmanager.rainforce.org/nightly/tags/Far_20_b780.zip -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 --- Comment #5 from Erich Hoover <ehoover(a)mines.edu> 2009-10-30 16:52:16 --- Created an attachment (id=24455) --> (http://bugs.winehq.org/attachment.cgi?id=24455) Hack for wineconsole (In reply to comment #4)
(In reply to comment #3)
Where can I get a hold of this application?
Opensource far is available from http://farmanager.com/opensource.php?l=en
The exact build I am using is this (revision 780): http://farmanager.rainforce.org/nightly/tags/Far_20_b780.zip
Thanks, I had a couple minutes to look into this and tracked down the general vicinity of the problem. The issue is that "wineconsole" treats ALL of the WM_SYSKEY* messages as having the ALT key pressed. So, attached is a hack to except F10 from this rule. Unfortunately I have to head off to a meeting, so I'll have to finish up later (the WM_SYSKEY* should not be used to determine accelerator keys, so fixing this properly will take a little effort). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 Erich Hoover <ehoover(a)mines.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24455|0 |1 is obsolete| | --- Comment #6 from Erich Hoover <ehoover(a)mines.edu> 2009-10-30 18:44:36 --- Created an attachment (id=24458) --> (http://bugs.winehq.org/attachment.cgi?id=24458) An actual fix for F10 in wineconsole If you could please test that the attached solves your issue (and doesn't introducing another bug) then I would greatly appreciate it. This problem appears to have been a lot easier to track down than I anticipated. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 --- Comment #7 from MP <singularita(a)gmail.com> 2009-10-31 08:08:57 ---
If you could please test that the attached solves your issue (and doesn't introducing another bug) then I would greatly appreciate it.
I tried the patch on current GIT master and is fixes the F10 issue. I have not noticed the patch breaking anything, at least not in FAR manager. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 --- Comment #8 from Erich Hoover <ehoover(a)mines.edu> 2009-11-13 11:37:57 --- (In reply to comment #7)
I tried the patch on current GIT master and is fixes the F10 issue. I have not noticed the patch breaking anything, at least not in FAR manager.
A slightly revised version of the patch is in the latest git. So, if you could try it out and confirm that everything is OK then we can close this issue. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 --- Comment #9 from MP <singularita(a)gmail.com> 2009-11-13 21:34:24 --- I tried latest GIT and FAR works fine, so I guess this is fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 --- Comment #10 from Erich Hoover <ehoover(a)mines.edu> 2009-11-13 21:39:32 --- (In reply to comment #9)
I tried latest GIT and FAR works fine, so I guess this is fixed.
Great! This patch actually just squeaked by in time for 1.1.33, so you should be set. I don't have the privileges to manage bugs, so if one of the wine-bugs folks could resolve this bug then that would be awesome. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 Jeff Zaroyko <jeffz(a)jeffz.name> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #11 from Jeff Zaroyko <jeffz(a)jeffz.name> 2009-11-13 22:00:25 --- marking fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20516 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> 2009-12-04 12:16:21 --- Closing bugs fixed in 1.1.34. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org