[Bug 40473] New: wine stops to compile with >=glibc-2.23
https://bugs.winehq.org/show_bug.cgi?id=40473 Bug ID: 40473 Summary: wine stops to compile with >=glibc-2.23 Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: darkcircle.0426(a)gmail.com Distribution: --- I'm using gentoo distribution and with unstable amd64 arch tree branch, so I'm glad to test early version of wine. ;) some of user reported build issue, and i made patch to this below link https://bugs.gentoo.org/show_bug.cgi?id=580046 and we should test which is working well or not. so please help me to test my patch to eliminate compile stopping issue with =glibc-2.23 Thank you for advance. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 --- Comment #2 from Seong-ho Cho <darkcircle.0426(a)gmail.com> --- Created attachment 54230 --> https://bugs.winehq.org/attachment.cgi?id=54230 This patch is following autoconf manual given by Mike Frysinger, Thanks. I modified a patch from initially submitted one to the gentoo bugzilla. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 Mike Frysinger <vapier(a)gentoo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vapier(a)gentoo.org --- Comment #1 from Mike Frysinger <vapier(a)gentoo.org> --- the build failure is semi-specific to Gentoo at this time. the plan is to deprecate these things in mainline glibc. other C libraries have dropped it (or never had it in the first place), although i'm guessing wine doesn't cover glibc too much atm. the AC_HEADER_MAJOR autoconf macro is designed to support this. https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Particu... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com Summary|wine stops to compile with |wine fails to compile with |>=glibc-2.23 |>=glibc-2.23 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 --- Comment #3 from Mike Frysinger <vapier(a)gentoo.org> --- not sure if there's a more central location to put these (not terribly familiar w/wine codebase), but if there isn't, that patch looks good. thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de --- Comment #4 from Sebastian Lackner <sebastian(a)fds-team.de> --- Patches have to be submitted to the wine-patches mailing list for inclusion, see https://wiki.winehq.org/Submitting_Patches. The proposed solution also looks good to me, but it doesn't apply cleanly on current Wine git. Make sure that the patch applies without --fuzz before sending it. Also, you might want to add a space inbetween of "#" and "include", like in the other lines above and below, but thats a minor issue. ;) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 --- Comment #5 from Seong-ho Cho <darkcircle.0426(a)gmail.com> --- (In reply to Sebastian Lackner from comment #4)
Patches have to be submitted to the wine-patches mailing list for inclusion, see https://wiki.winehq.org/Submitting_Patches.
The proposed solution also looks good to me, but it doesn't apply cleanly on current Wine git. Make sure that the patch applies without --fuzz before sending it. Also, you might want to add a space inbetween of "#" and "include", like in the other lines above and below, but thats a minor issue. ;)
Thank you for telling about how to submit patch. I sent my patch to wine-patches(a)whq.org via 'git send-email' I don't know that my patch is really good, and it goes well into the mail server. because, it's just my first patch submission *(-_-)* -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Keywords| |download, source --- Comment #6 from Austin English <austinenglish(a)gmail.com> --- (In reply to Seong-ho Cho from comment #5)
(In reply to Sebastian Lackner from comment #4)
Patches have to be submitted to the wine-patches mailing list for inclusion, see https://wiki.winehq.org/Submitting_Patches.
The proposed solution also looks good to me, but it doesn't apply cleanly on current Wine git. Make sure that the patch applies without --fuzz before sending it. Also, you might want to add a space inbetween of "#" and "include", like in the other lines above and below, but thats a minor issue. ;)
Thank you for telling about how to submit patch.
I sent my patch to wine-patches(a)whq.org via 'git send-email' I don't know that my patch is really good, and it goes well into the mail server. because, it's just my first patch submission *(-_-)*
It will show here: https://source.winehq.org/patches/ once it's gone through moderation (assuming you haven't subscribed to wine-patches@). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #7 from super_man(a)post.com --- This should be fixed now? All the 3 patches were committed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |ca8a08606d3f0900b3f4aa8f2e6 | |547882a22dba8 Resolution|--- |FIXED --- Comment #8 from Austin English <austinenglish(a)gmail.com> --- Fixed by https://source.winehq.org/git/wine.git/commitdiff/ca8a08606d3f0900b3f4aa8f2e... Thanks Seong-ho! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 --- Comment #9 from Seong-ho Cho <darkcircle.0426(a)gmail.com> --- Thank you for helping me everyone :D !! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.9. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.8.x CC| |mstefani(a)redhat.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=40473 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #11 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org