[Bug 49790] New: wine (staging) from 5.13 to current 5.16 - qclauncher hangs (on access to a lock file?)
https://bugs.winehq.org/show_bug.cgi?id=49790 Bug ID: 49790 Summary: wine (staging) from 5.13 to current 5.16 - qclauncher hangs (on access to a lock file?) Product: Wine-staging Version: 5.16 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: winehq(a)lam.pl CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- Because Bethesda.net Launcher doesn't work in WINE, qclauncher has been a great tool to start Quake Champions in WINE for pure BNL accounts (non-Steam). On Fedora (which uses wine-staging), I can't run qclauncher on any wine (staging) newer than 5.12. To reproduce qclauncher's problem, you don't need the game or Bethesda account. All you need is to: - grab the newest qclauncher.exe - https://github.com/syncore/qclauncher/releases/tag/v1.06 and extract that into a directory - cd <said directory> - touch data.qcl - ./qclauncher.exe Because the configuration file is 0 bytes, it should pop up an error saying "Your data.qcl is from an old version (...) You must restart (...)". That's the expected behavior for this test scenario. At least it was able to open the file, see that it's empty and display a dialog. It will remove the empty data.qcl file and you need to touch (re-create) it before test with a different WINE version. In current wine-staging, the pop-up never appears. Instead, wine apparently hangs completely, doesn't show any window, doesn't react to ^C/^\, but can be killed. My history with this problem: - 5.9 works - 5.10 had the same issue - not sure about 5.11 - 5.12 works - 5.13, 5.14, 5.15, 5.16 (newest at the time of writing) all have the bug Because I found a way to reproduce the hang without qclauncher ever trying to launch the game, I'm now suspecting (actually, pretty convinced) that the hang occurs during access to the data.qcl file. The program creates a file "qcl.lock" and perhaps this locking mechanisms got broken? This should be 100% reproducible without any requirements (other than grabbing qclauncher from github), but please let me know if it somehow isn't. Many thanks in advance! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49790 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 URL| |https://github.com/syncore/ | |qclauncher/releases/tag/v1. | |06 Status|UNCONFIRMED |NEW CC| |dark.shadow4(a)web.de, | |erich.e.hoover(a)gmail.com Keywords| |download, regression --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Confirming, the issue is caused by https://github.com/wine-staging/wine-staging/blob/master/patches/ntdll-Junct... @Erich E. Hoover Would you mind taking a look? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49790 --- Comment #2 from Erich E. Hoover <erich.e.hoover(a)gmail.com> --- (In reply to Fabian Maurer from comment #1)
Confirming, the issue is caused by
https://github.com/wine-staging/wine-staging/blob/master/patches/ntdll- Junction_Points/0005-server-Add-support-for-deleting-junction-points-with. patch
@Erich E. Hoover Would you mind taking a look?
Yikes, I tried to be _really_ careful about this update to the reparse/junction point support... I'll try to take a look tonight and see what I can figure out. That also reminds me that I need to resend the mountmgr patches so that we can get proper reporting of whether the underlying filesystem reports reparse points. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49790 --- Comment #3 from Erich E. Hoover <erich.e.hoover(a)gmail.com> --- Created attachment 68123 --> https://bugs.winehq.org/attachment.cgi?id=68123 fix for qclauncher wineserver crash Give this a try: 1) setup wine at tag wine-5.16 2) patch with wine-staging at tag v5.16 3) patch with the attached patch 4) build wine 5) test: wget https://github.com/syncore/qclauncher/releases/download/v1.06/qclauncher-1.0...; unzip qclauncher-1.06.zip; cd qclauncher/ touch data.qcl WINEDLLOVERRIDES="mscoree=n;mshtml=n" wine qclauncher.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49790 --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- @Erich E. Hoover Your patch works fine for me. Are you getting that into wine-staging? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49790 --- Comment #5 from Erich E. Hoover <erich.e.hoover(a)gmail.com> --- (In reply to Fabian Maurer from comment #4)
@Erich E. Hoover Your patch works fine for me. Are you getting that into wine-staging?
Yes, I'll send an updated patch to Zeb when I get off work. I'm honestly shocked that this updated patchset worked as well as it did with this mistake. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49790 --- Comment #6 from Lam <winehq(a)lam.pl> --- I'm happy to report that rebuilding Fedora's wine-5.16 (and reinstalling just the wine-core.x86_64 rpm) fixes the issue for me. Many thanks for such a quick fix, here's hoping this comes to "official" patches as well :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49790 --- Comment #7 from Erich E. Hoover <erich.e.hoover(a)gmail.com> --- (In reply to Lam from comment #6)
I'm happy to report that rebuilding Fedora's wine-5.16 (and reinstalling just the wine-core.x86_64 rpm) fixes the issue for me.
Many thanks for such a quick fix, here's hoping this comes to "official" patches as well :)
I was hoping to get this in to Zeb before 5.17, but unfortunately this fell off of my stack the other day. I've now sent him an updated patch that should do the trick. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49790 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |7bd8acb4ca8b301fa9edee3601d | |eeecd72522091 Resolution|--- |FIXED --- Comment #8 from Zebediah Figura <z.figura12(a)gmail.com> --- Fixed by 7bd8acb4ca8b301fa9edee3601deeecd72522091; sorry for the long delay. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49790 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Closing bugs fixed in Staging 5.19. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla