[Bug 6842] DrawFocusRect code correction
http://bugs.winehq.org/show_bug.cgi?id=6842 ------- Additional Comments From juan_lang(a)yahoo.com 2006-07-12 12:51 ------- It would be easier to check your code if you sent it as a patch to wine-devel. We want to be able to see exactly what you've changed, so the patch format helps with that. Some initial feedback: 1. This looks like preprocessor abuse - choose one method (to cache or not to cache) and propose that. 2. Don't use C++-style comments (no //). 3. You have comments on too many lines - one larger comment before the block that explain the gist of it could replace a lot of these. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
participants (1)
-
Wine Bugs