[Bug 33146] New: Path of Exile "Allocating Space" very slow, due to NtFlushVirtualMemory being synchronous
http://bugs.winehq.org/show_bug.cgi?id=33146 Bug #: 33146 Summary: Path of Exile "Allocating Space" very slow, due to NtFlushVirtualMemory being synchronous Product: Wine Version: unspecified Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll AssignedTo: wine-bugs(a)winehq.org ReportedBy: default_357-line(a)yahoo.de Classification: Unclassified The "Allocating Space" step of the Path of Exile installer/updater can take upwards of ten hours to complete (compared to a few minutes under Windows). Path of Exile calls FlushViewOfFile, which calls NtFlushVirtualMemory, which calls msync with MS_SYNC. The MSDN documentation for FlushViewOfFile http://msdn.microsoft.com/en-us/library/windows/desktop/aa366563%28v=vs.85%2... says, quote, "The FlushViewOfFile function does not flush the file metadata, and it does not wait to return until the changes are flushed from the underlying hardware disk cache and physically written to disk." This strongly indicates that NtFlushVirtualMemory is meant to be asynchronous. I'll submit a patch that corrects this, and fixes the Allocating Space slowdown. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 --- Comment #1 from default_357-line(a)yahoo.de 2013-03-08 10:05:41 CST --- http://www.winehq.org/pipermail/wine-patches/2013-March/122718.html Submitted. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Michael Armbruster <lyxei.lp(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lyxei.lp(a)gmail.com --- Comment #2 from Michael Armbruster <lyxei.lp(a)gmail.com> 2013-03-08 14:45:07 CST --- I can confirm the existing bug without the patch. After I recompiled wine using the patch mentioned here (http://bugs.winehq.org/show_bug.cgi?id=33146#c1), i successfully had allocating the space in under one minute instead of several hours! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Marcel Stranak <marceel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marceel(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 jukkaho(a)mail.student.oulu.fi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jukkaho(a)mail.student.oulu.f | |i --- Comment #3 from jukkaho(a)mail.student.oulu.fi 2013-03-22 16:47:34 CDT --- I can also confirm this problem and that changing to MS_ASYNC fixes the performance issue. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Frédéric Delanoy <frederic.delanoy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |frederic.delanoy(a)gmail.com Ever Confirmed|0 |1 --- Comment #4 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-05-09 07:54:40 CDT --- Confirmed as per comment 2 and comment 3 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 --- Comment #5 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-05-09 07:57:54 CDT --- (In reply to comment #1)
http://www.winehq.org/pipermail/wine-patches/2013-March/122718.html Submitted.
You might want to attach your (rebased version of this) patch in this bug report -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 --- Comment #6 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-05-09 07:58:50 CDT --- (In reply to comment #5)
(In reply to comment #1)
http://www.winehq.org/pipermail/wine-patches/2013-March/122718.html Submitted.
You might want to attach your (rebased version of this) patch in this bug report
And also set the "version" field correctly -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 eroen <eroen(a)faith.eroen.eu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eroen(a)faith.eroen.eu --- Comment #7 from eroen <eroen(a)faith.eroen.eu> 2013-05-10 06:40:30 CDT --- Apparently, the patch mentioned several times above was re-written and resubmitted as http://www.winehq.org/pipermail/wine-patches/2013-March/122783.html after discussion on wine-devel. This revised version seems to have fallen through the review process unnoticed, though. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 spiralofhope(a)lavabit.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spiralofhope(a)lavabit.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |default_357-line(a)yahoo.de --- Comment #8 from Jerome Leclanche <adys.wh(a)gmail.com> 2013-06-19 17:07:09 CDT --- (In reply to comment #7) The patch was picked up and declined. This is the only comment it got on irc: [22:36:44] <julliard> the ifdefs need more work -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 --- Comment #9 from spiralofhope(a)lavabit.com 2013-06-20 03:11:09 CDT --- http://www.winehq.org/pipermail/wine-patches/2013-March/122783.html (In reply to comment #8)
(In reply to comment #7) The patch was picked up and declined. This is the only comment it got on irc:
[22:36:44] <julliard> the ifdefs need more work
I can imagine him being overworked.. but I looked at the patch and it's so trivial it could easily be adjusted before inclusion. *scratches head* -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 --- Comment #10 from FeepingCreature <default_357-line(a)yahoo.de> 2013-06-20 07:04:24 CDT --- Alright, submitted again. This time with more comments, and keeping the original ifdef in place. http://www.winehq.org/pipermail/wine-patches/2013-June/124884.html Here's to hope! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Xavier Vachon <xvachon(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xvachon(a)gmail.com --- Comment #11 from Xavier Vachon <xvachon(a)gmail.com> 2013-11-08 02:18:15 CST --- Still a bug in 1.7.5. Any updates regarding the patch in comment #10? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Frédéric Delanoy <frederic.delanoy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://webcdn.pathofexile.c | |om/downloads/PathOfExileIns | |taller.msi -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 --- Comment #12 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-11-25 08:40:13 CST --- (In reply to comment #10)
Alright, submitted again. This time with more comments, and keeping the original ifdef in place. http://www.winehq.org/pipermail/wine-patches/2013-June/124884.html Here's to hope!
Still in 1.7.7 ; you might want submit your (rebased) patch to wine-patches (or send it beforehand to wine-devel if you need a review). Also you should set the "Version" field of this bug to the earliest tested version that had the bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Kai Hiller <V02460(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |V02460(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Pekka Paalanen <pq(a)iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pq(a)iki.fi -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Jan Buecken <jb.faq(a)gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jb.faq(a)gmx.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33146 Jarkko K <jarkko_korpi(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jarkko_korpi(a)hotmail.com --- Comment #13 from Jarkko K <jarkko_korpi(a)hotmail.com> --- What's the current situation? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 --- Comment #14 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> --- (In reply to Jarkko K from comment #13)
What's the current situation?
No change. Note it's easily testable, just download the 7.2M installer wine msiexec /i PathOfExileInstaller.msi then run the game from its install directory ~/.wine/drive_c/Program Files/Grinding Gear Games/Path of Exile$ wine PathOfExile.exe (you might have to select a WINEPREFIX) After a short "Checking resources..." phase (< 1 min), the "Allocating Space..." should take a couple minutes at most, not hours. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33146 Frédéric Delanoy <frederic.delanoy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |693d6e48d775ba29a803ee04c34 | |4c4ba1e7cb274 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #15 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> --- Fixed in git -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=33146 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #16 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org