[Bug 26355] New: Webbrowser links don't work
http://bugs.winehq.org/show_bug.cgi?id=26355 Summary: Webbrowser links don't work Product: Wine Version: 1.3.15 Platform: x86 URL: http://netikka.net/dev/browser.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: shdocvw AssignedTo: wine-bugs(a)winehq.org ReportedBy: ocean04(a)suomi24.fi Example: http://netikka.net/dev/browser.exe If you click links -> nothing happens. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |nerv(a)dawncrow.de Ever Confirmed|0 |1 --- Comment #1 from André H. <nerv(a)dawncrow.de> 2011-03-08 14:18:22 CST --- confirming, but sounds familiar (might also be a duplicate) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|shdocvw |-unknown --- Comment #2 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2011-03-09 00:22:52 CST --- There is no need to guess the component. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 ocean04(a)suomi24.fi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |shlwapi --- Comment #3 from ocean04(a)suomi24.fi 2011-04-25 09:32:29 CDT --- Using native shlwapi.dll (from XP) fixes problem for me -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 ocean04(a)suomi24.fi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Webbrowser links don't work |Webbrowser WM_LBUTTONDOWN | |message don't work --- Comment #4 from ocean04(a)suomi24.fi 2011-06-08 10:00:24 CDT --- Application just never get WM_LBUTTONDOWN message. Example showing this, http://netikka.net/dev/browser2.exe Click link -> Wine: WM_LBUTTONUP Windows: WM_LBUTTONDOWN WM_LBUTTONUP procedure TForm1.FormCreate(Sender: TObject); begin Application.OnMessage := MsgHandler; end; procedure Tform1.MsgHandler(var Msg: TMsg; var Handled: Boolean); begin if (msg.message=WM_LBUTTONDOWN) then memo1.lines.add('Message: WM_LBUTTONDOWN'); if (msg.message=WM_LBUTTONUP) then memo1.lines.add('Message: WM_LBUTTONUP'); Handled:=false; end; -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 ocean04(a)suomi24.fi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|shlwapi |user32 --- Comment #5 from ocean04(a)suomi24.fi 2011-06-09 03:24:09 CDT --- Don't know why it works with native shlwapi? Message fails to register after shlwapi.167, SetParent(hWnd, hWndParent); Problem is really in user32, messages.c, process_mouse_message If delete this line, everything works! if (!FOCUS_MouseActivate( hwndTop )) eatMsg = TRUE; Could someone write proper patch, NOT eating the message in this case, thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 ocean04(a)suomi24.fi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|user32 |shlwapi --- Comment #6 from ocean04(a)suomi24.fi 2011-06-20 07:03:04 CDT --- Builtin shlwapi calls setparent with GWL_STYLE c6010000 and native 46010000. That is causing this bug. c6010000 is incorrect. These changes to shlwapi seem to do it: -LONG new_flags = (flags & mask) | (ret & ~mask); +LONG new_flags = (flags) | (ret & ~mask); - SHSetWindowBits(hWnd, GWL_STYLE, WS_CHILD, WS_CHILD); -else - SHSetWindowBits(hWnd, GWL_STYLE, WS_POPUP, WS_POPUP); + SHSetWindowBits(hWnd, GWL_STYLE, WS_POPUP, WS_CHILD); +else + SHSetWindowBits(hWnd, GWL_STYLE, WS_CHILD, WS_POPUP); -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 --- Comment #7 from ocean04(a)suomi24.fi 2011-10-21 10:03:47 CDT --- Still in 1.3.30. Solution looks too obvious? I wonder, is there some other problem, why nobody is interested in fixing shlwapi code? Affects all Delphi applications using Twebbrowser control -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-10-21 10:21:39 CDT --- (In reply to comment #6)
Builtin shlwapi calls setparent with GWL_STYLE c6010000 and native 46010000. That is causing this bug. c6010000 is incorrect.
How do you know what native uses? (In reply to comment #7)
Still in 1.3.30.
Solution looks too obvious? I wonder, is there some other problem, why nobody is interested in fixing shlwapi code?
This needs test obviously. Feel free to send patches. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 --- Comment #9 from ocean04(a)suomi24.fi 2011-10-21 11:15:30 CDT ---
How do you know what native uses?
Thanks for interest! I added some debug code to user32. Then run this sample with builtin / native shlwapi and got these different GWL_STYLE values. I don't remember exactly, but I think I can do it again, if it helps? Unfortunately, I don't think I can write test for this. I have never done anything with C. I can only write Pascal, Javascript and PHP. But that current setparent code just looks suspicious anyway -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 --- Comment #10 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-10-21 11:28:46 CDT --- Ok, I'll add some tests for that. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-10-21 16:52:16 CDT --- Created attachment 37048 --> http://bugs.winehq.org/attachment.cgi?id=37048 patch Try this one please. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 --- Comment #12 from ocean04(a)suomi24.fi 2011-10-22 10:58:57 CDT --- Patch works fine here, many thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs(a)winehq.org |bunglehead(a)gmail.com --- Comment #13 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-10-22 11:04:26 CDT --- Okay, will submit it next week. Thanks for testing. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |762aa854ca5cf720870ac61c7a3 | |370f289291dcc Status|NEW |RESOLVED Resolution| |FIXED --- Comment #14 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-10-24 13:55:20 CDT --- Should be fixed with 762aa854ca5cf720870ac61c7a3370f289291dcc. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amlopezalonso(a)gmail.com --- Comment #15 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-10-29 16:54:35 CDT --- *** Bug 14430 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=26355 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #16 from Alexandre Julliard <julliard(a)winehq.org> 2011-11-04 14:14:22 CDT --- Closing bugs fixed in 1.3.32. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=26355 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead(a)gmail.com |wine-bugs(a)winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org