[Bug 15833] New: TreeView control don't save item's state
http://bugs.winehq.org/show_bug.cgi?id=15833 Summary: TreeView control don't save item's state Product: Wine Version: 1.1.7 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P1 Component: comctl32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: iwarmouse(a)gmail.com Created an attachment (id=16963) --> (http://bugs.winehq.org/attachment.cgi?id=16963) patch that i offer to fix this bug Hi. BUG: TreeView sends TVS_GETDISPINFO notifycation. Main application catch it and change "mask","state" and "stateMask" in a TVITEM structure. After returning from message handler, item's state don't changed. TreeView don't save new item state in function TREEVIEW_UpdateDispInfo after calling TREEVIEW_SendRealNotify. This is Delphi code sample, TMyTreeView inherits from TCustomTreeView //----------------------------------------------------------------- procedure TMyTreeView.CNNotify(var Message: TWMNotify); var hNode: Integer; begin with Message do case NMHdr^.code of TVN_GETDISPINFO: with PTVDispInfo(NMHdr)^ do begin hNode := item.hItem; with PTVDispInfo(NMHdr)^.item do begin mask := mask or TVIF_STATE or TVIF_HANDLE; stateMask := stateMask or TVIS_STATEIMAGEMASK; state := (state and not TVIS_STATEIMAGEMASK) or UINT(IndexToStateImageMask(MyGetItemImageIndex(hNode))); end; end; end; inherited; end; //----------------------------------------------------------------- This's link to MSDN page, where described how it must work: http://msdn.microsoft.com/en-us/library/bb773456(VS.85).aspx I'm offer this patch (attached) to fix this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Priority|P1 |P2 --- Comment #1 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-10-29 06:38:49 --- Please send the patch to wine-patches(a)winehq.org with the reference to this bug. Thanks! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 --- Comment #2 from Zavgorodniy Vadim <iwarmouse(a)gmail.com> 2008-10-29 09:27:41 --- Ok, i did it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, source -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 --- Comment #3 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2008-10-30 10:36:23 --- Please resend with your real name in the From: field. Thanks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Zavgorodniy Vadim <iwarmouse(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iwarmouse(a)gmail.com --- Comment #4 from Zavgorodniy Vadim <iwarmouse(a)gmail.com> 2008-10-31 05:35:19 --- Ok. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 --- Comment #5 from Zavgorodniy Vadim <iwarmouse(a)gmail.com> 2009-01-11 01:06:20 --- Hi. Please tell me, what you think about this bug? Can you add my or different patch? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|iwarmouse(a)gmail.com | --- Comment #6 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2009-01-12 06:32:07 --- A commenter to your patch on wine-devel asked if you could provide a test case for the change. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2009-07-13 11:39:41 --- Still present. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-08-01 06:11:56 --- (In reply to comment #5)
Hi.
Please tell me, what you think about this bug? Can you add my or different patch?
Actually I can't confirm this behaviour yet with a basic test. Wine seems to act like native here. Only text, image indices and cChildren member are available through callback functionality: http://msdn.microsoft.com/en-us/library/bb773518%28VS.85%29.aspx Could you attach complete source code of your program to test? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 --- Comment #9 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-12-13 04:03:46 --- Hi, Vadim. Are you going to provide a test application for that report? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 --- Comment #10 from Zavgorodniy Vadim <iwarmouse(a)gmail.com> 2009-12-14 09:07:12 --- Hi. Yes, I do. But I am out of time lately. I am going to do it next month. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 --- Comment #11 from Zavgorodniy Vadim <iwarmouse(a)gmail.com> 2010-01-12 07:52:44 --- Created an attachment (id=25693) --> (http://bugs.winehq.org/attachment.cgi?id=25693) There is a simple test case. There is a simple Delphi project that looks different under wine and on windows. There are must be ticks in all checkboxes, but under wine there are not, because TreeView control doesn't save item's state. The patch I offer to apply fixes it. Should I send this test to someone else? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 --- Comment #12 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-01-12 07:55:45 --- (In reply to comment #11)
Created an attachment (id=25693) --> (http://bugs.winehq.org/attachment.cgi?id=25693) [details] There is a simple test case.
Thanks.
There is a simple Delphi project that looks different under wine and on windows. There are must be ticks in all checkboxes, but under wine there are not, because TreeView control doesn't save item's state. The patch I offer to apply fixes it.
Ok, I'll take a look.
Should I send this test to someone else?
No. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |ABANDONED --- Comment #13 from Austin English <austinenglish(a)gmail.com> 2011-03-29 21:58:15 CDT --- No response in over a year, marking abandoned. If this is still an issue in current (1.3.16 or newer) wine, and you can provide the needed information, feel free to reopen. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #14 from Austin English <austinenglish(a)gmail.com> 2011-03-29 21:59:01 CDT --- Closing. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Zavgorodniy Vadim <iwarmouse(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|ABANDONED | --- Comment #15 from Zavgorodniy Vadim <iwarmouse(a)gmail.com> 2011-05-13 05:15:48 CDT --- Still present in 1.3.19 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #16 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-05-13 16:59:08 CDT --- Ok, I can confirm that. Let's see what happens with state here (this time for real I hope, not like over a year ago). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs(a)winehq.org |bunglehead(a)gmail.com --- Comment #17 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-05-14 06:56:34 CDT --- I have some patches to fix that, will send next week. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #18 from Nikolay Sivov <bunglehead(a)gmail.com> 2011-05-16 14:03:43 CDT --- Fixed with f9b14fda026fe71cb055a20833069e1c16e328ba. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15833 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #19 from Alexandre Julliard <julliard(a)winehq.org> 2011-05-27 13:36:33 CDT --- Closing bugs fixed in 1.3.21. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=15833 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead(a)gmail.com |wine-bugs(a)winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org