[Bug 28582] New: MOVE-ing a file with cmd to current directory should be a no-op
http://bugs.winehq.org/show_bug.cgi?id=28582 Bug #: 28582 Summary: MOVE-ing a file with cmd to current directory should be a no-op Product: Wine Version: 1.3.29 Platform: x86-64 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: cmd AssignedTo: wine-bugs(a)winehq.org ReportedBy: frederic.delanoy(a)gmail.com Classification: Unclassified When using MOVE of a file/directory, bad things happen 'move file' or 'move file1' gives a confirmation dialog and deletes the file if the move/overwrite is confirmed. With directories, similar behaviour but you get an access denied and the dir isn't deleted. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28582 Jason Edmeades <us(a)edmeades.me.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |us(a)edmeades.me.uk --- Comment #1 from Jason Edmeades <us(a)edmeades.me.uk> 2012-09-05 18:32:38 CDT --- Trivial patch... http://www.winehq.org/pipermail/wine-patches/2012-September/117539.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28582 --- Comment #2 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2012-11-09 19:07:39 CST --- Still in 1.5.17 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28582 Frédéric Delanoy <frederic.delanoy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28582 --- Comment #3 from Jason Edmeades <us(a)edmeades.me.uk> 2013-06-11 16:29:54 CDT --- Try 2: http://www.winehq.org/pipermail/wine-patches/2013-June/124725.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28582 Jason Edmeades <us(a)edmeades.me.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=28582 Jason Edmeades <us(a)edmeades.me.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs(a)winehq.org |us(a)edmeades.me.uk -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28582 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #4 from super_man(a)post.com --- Not taking part of the correctness of the patch but it applies quite cleanly against current git. Maybe someone could rework with this? patch -p1 <move.patch patching file programs/cmd/builtins.c Hunk #1 succeeded at 2859 (offset 1 line). Hunk #2 succeeded at 2888 with fuzz 2 (offset 1 line). wine 1.7.50(git) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28582 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28582 --- Comment #5 from super_man(a)post.com --- You should send the patch into wine-patches list for review. Patch sitting here doesnt help anyone really... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28582 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #6 from winetest(a)luukku.com --- patching file programs/cmd/builtins.c Hunk #1 succeeded at 2901 (offset 43 lines). Hunk #2 succeeded at 2930 with fuzz 2 (offset 43 lines). Against wine 2.0rc4. So it's not committed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28582 Jason Edmeades <us(a)edmeades.me.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|us(a)edmeades.me.uk |wine-bugs(a)winehq.org --- Comment #7 from Jason Edmeades <us(a)edmeades.me.uk> --- Unassigning myself as I am not working on wine recently. The patch was submitted but rejected on try 1 as name comparison was not sufficient, and I changed to the try 2 version. I dont recall any rejection of it, although I may be wrong, it may have just slipped between cracks. Feel free to resubmit / get feedback and take it over, as I cant do so in the near-medium future -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28582 Mayyjacc <Romot0225(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Romot0225(a)gmail.com --- Comment #8 from Mayyjacc <Romot0225(a)gmail.com> --- Created attachment 66161 --> https://bugs.winehq.org/attachment.cgi?id=66161 Stupid ass bitch hit my car HitMyCar -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28582 --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> --- The content of attachment 66161 has been deleted for the following reason: spam -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=28582 --- Comment #10 from Janne <janne.kekkonen(a)gmail.com> --- Created attachment 77808 --> https://bugs.winehq.org/attachment.cgi?id=77808 move test log Tested with wine 9.0 Created file and directory with couple of files in it. Used following commands: move testfile.txt move testdir Both commands asked confirmation for overwrite. File and directory were unharmed by move commands. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs@winehq.org -
WineHQ Bugzilla