[Bug 35055] New: Incorrect SourceDir used for product update.
http://bugs.winehq.org/show_bug.cgi?id=35055 Bug #: 35055 Summary: Incorrect SourceDir used for product update. Product: Wine Version: 1.7.7 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msi AssignedTo: wine-bugs(a)winehq.org ReportedBy: serhio(a)etersoft.ru Classification: Unclassified There are two versions of some product, Lets name they as "old" and "new". There is an ability of upgrade old version to new by simple running of new version installer. Windows handles this scenario pretty fine, but under wine updating doesn't happen. I've tried to investigate this problem and got next results. * Old version is installed by MsiInstallProduct(old_package_path, "") (installed to clean prefix) * New version is installed above old by MsiInstallProduct(new_package_path), "REINSTALL=ALL REINSTALLMODE=vamus") * During new version installing, i've caught call to msi_set_sourcedir_props(), that set SourceDir to old_package_path, that obviously is incorrect. As result we have "updating" from old version to old, that seems like nothingh has changed. Also it seems as regression, that introduced by http://source.winehq.org/git/wine.git/commitdiff/dd305c3700c1b5b0de41b875589... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35055 Sergey Guralnik <serhio(a)etersoft.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans(a)meelstraat.net Regression SHA1| |dd305c3700c1b5b0de41b875589 | |30e08ba88bd68 --- Comment #1 from Sergey Guralnik <serhio(a)etersoft.ru> 2013-12-05 12:53:43 CST --- (In reply to comment #0)
Also it seems as regression, that introduced by http://source.winehq.org/git/wine.git/commitdiff/dd305c3700c1b5b0de41b875589...
Adding author to CC. P.S. Maybe msi_set_sourcedir_props() should have some version checks before fetching SourceDir from registry? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35055 --- Comment #2 from Hans Leidekker <hans(a)meelstraat.net> 2013-12-05 13:27:53 CST --- (In reply to comment #1)
(In reply to comment #0)
Also it seems as regression, that introduced by http://source.winehq.org/git/wine.git/commitdiff/dd305c3700c1b5b0de41b875589...
Adding author to CC. P.S. Maybe msi_set_sourcedir_props() should have some version checks before fetching SourceDir from registry?
Have you confirmed that reverting the patch fixes your bug? It fixes the case where a product is patched, which normally means that the product version is incremented. So a version check is probably not sufficient. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35055 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35055 --- Comment #3 from Sergey Guralnik <serhio(a)etersoft.ru> 2013-12-06 00:39:06 CST --- (In reply to comment #2)
Have you confirmed that reverting the patch fixes your bug? It fixes the case where a product is patched, which normally means that the product version is incremented. So a version check is probably not sufficient.
Yes, bug disappears after reverting. Maybe you have some another ideas related to SourceDir setting? Probably there should be some additional conditions for using registered value. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35055 --- Comment #4 from Hans Leidekker <hans(a)meelstraat.net> 2013-12-06 03:54:38 CST --- (In reply to comment #3)
(In reply to comment #2)
Have you confirmed that reverting the patch fixes your bug? It fixes the case where a product is patched, which normally means that the product version is incremented. So a version check is probably not sufficient.
Yes, bug disappears after reverting. Maybe you have some another ideas related to SourceDir setting? Probably there should be some additional conditions for using registered value.
I'm not sure, I would need to investigate. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35055 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |290d8a0f44a6c6fa46785b7e6db | |66ecb7fd99ea7 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Hans Leidekker <hans(a)meelstraat.net> --- Should be fixed by 290d8a0f44a6c6fa46785b7e6db66ecb7fd99ea7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=35055 --- Comment #6 from Sergey Guralnik <serhio(a)etersoft.ru> --- (In reply to comment #5)
Should be fixed by 290d8a0f44a6c6fa46785b7e6db66ecb7fd99ea7.
It works fine again. Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=35055 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.11. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org