[Bug 16845] New: Radio buttons not being checked on focus
http://bugs.winehq.org/show_bug.cgi?id=16845 Summary: Radio buttons not being checked on focus Product: Wine Version: CVS/GIT Platform: Other URL: http://www.chiark.greenend.org.uk/~sgtatham/putty/downlo ad.html OS/Version: other Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: user32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: munozferna(a)gmail.com Current wine behavior is to just assign the focus to the radio button, however, Windows checks the radio button when it gets focus through the keyboard arrows. Steps to reproduce: 1. Open putty 2. Click the Raw radio button 3. Press right arrow twice Actual results * Port textbox stays at 23 * Rlogin radio button is not checked Expected results (windows behavior) * Port textbox changes to 513 * Rlogin radio button is checked I'm attaching a patch that I believe fixes this, comments about it would be appreciated. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 --- Comment #1 from Fernando Muñoz <munozferna(a)gmail.com> 2009-01-08 01:50:54 --- Created an attachment (id=18574) --> (http://bugs.winehq.org/attachment.cgi?id=18574) Patch that fixes this problem -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 Dmitry Timoshkov <dmitry(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |1.1.12 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2009-01-08 02:27:01 --- A testcase would help. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 --- Comment #3 from Juan Lang <juan_lang(a)yahoo.com> 2009-01-08 10:31:16 --- You're also likely to get more comments on wine-devel than here. As Austin says, a test case would help a lot. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 --- Comment #4 from Fernando Muñoz <munozferna(a)gmail.com> 2009-01-09 08:19:04 --- I was trying to create my own case test, but failed. Then I noticed that I could add a new test to the current user32/tests/dialog.c, since some tests there already check focus stuff on controls. I will try this approach, but I am no Win32 Api programmer, so it's gonna take a while. Also, on this patch I'm only checking for BS_AUTORADIOBUTTON, not sure if this behavior applies to BS_RADIOBUTTON aswell. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 Reece Dunn <msclrhd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msclrhd(a)gmail.com --- Comment #5 from Reece Dunn <msclrhd(a)gmail.com> 2009-01-09 17:42:19 --- With BS_RADIOBUTTON, the program is responsible for setting the radio button state; for BS_AUTORADIOBUTTON, Windows handles this automatically. That covers keyboard handling, radio button cycling and so forth. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 --- Comment #6 from Fernando Muñoz <munozferna(a)gmail.com> 2009-01-10 13:06:09 --- This patch is wrong, it doesn't behave exactly as windows, it should select the radio buttons on keydown, because when you left the arrow key pressed and it keeps moving over the other controls, in the case of putty, windows selects all of them as they get focus, without needing the KEYUP event. So I tried moving my code to the WM_KEYDOWN case, however, that event doesn't seem to fire with the arrow keys. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2009-06-08 17:14:28 --- Still present in git. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #8 from Bruno Jesus <00cpxxx(a)gmail.com> 2011-12-10 21:41:44 CST --- Still present in 1.3.34. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 gat <gatlinsullivan(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gatlinsullivan(a)yahoo.com --- Comment #9 from gat <gatlinsullivan(a)yahoo.com> 2012-04-24 03:13:59 CDT --- Still present in Notepad++ 6.1.1 using Fedora 16 x86_64 with wine 1.5.1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 --- Comment #10 from gat <gatlinsullivan(a)yahoo.com> 2013-03-10 11:41:06 CDT --- Still present in Notepad++ 6.3 using Fedora 18 x86_64 with wine 1.5.25. Will somebody mark this as a duplicate of bug 12527? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 Simon <swdevelop1981(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |swdevelop1981(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #11 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Does this still occur in Wine 1.7.19 or later? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16845 --- Comment #12 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- *** Bug 12527 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 --- Comment #13 from gat <gatlinsullivan(a)yahoo.com> --- This is still present in Wine 1.9.5 with Fedora 23 using Notepad++ 6.9. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #14 from winetest(a)luukku.com --- Still valid wine 2.0.rc3. And staging 2.0.rc3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 --- Comment #15 from winetest(a)luukku.com --- Staging has a patch for this now. I already tested and it seems to fix this bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/user32-Auto_Ra | |dio_Button CC| |dmitry(a)baikal.ru, | |erich.e.hoover(a)wine-staging | |.com, michael(a)fds-team.de, | |sebastian(a)fds-team.de Status|NEW |STAGED -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 Sylvain Petreolle <spetreolle(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spetreolle(a)yahoo.fr -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 Sylvain Petreolle <spetreolle(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thestig(a)google.com --- Comment #16 from Sylvain Petreolle <spetreolle(a)yahoo.fr> --- *** Bug 11095 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv(a)dawncrow.de Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/user32-Auto_Ra |er/patches/user32-Auto_Radi |dio_Button |o_Button -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |b1b8fb77be5dd9a8754b04b2ef9 | |f703bbe393d59 Resolution|--- |FIXED Status|STAGED |RESOLVED --- Comment #17 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Committed as b1b8fb77be5dd9a8754b04b2ef9f703bbe393d59. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #18 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.0-rc1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |--- --- Comment #19 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 3.0.x milestone from bug fixes included in 3.0.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=16845 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://www.chiark.greenend. |https://web.archive.org/web |org.uk/~sgtatham/putty/down |/20170709192013/https://the |load.html |.earth.li/~sgtatham/putty/0 | |.67/x86/putty-0.67-installe | |r.msi Hardware|Other |x86 CC| |focht(a)gmx.net OS|other |Linux -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla