[Bug 57296] New: WineHQ-devel-9.19: Renders Distorted Radio Buttons on WinXP Spider Solitaire
https://bugs.winehq.org/show_bug.cgi?id=57296 Bug ID: 57296 Summary: WineHQ-devel-9.19: Renders Distorted Radio Buttons on WinXP Spider Solitaire Product: Wine Version: 9.19 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: garrettm4(a)protonmail.com Distribution: --- Setup: Fedora 40, WineHQ-devel-9.19, with stock winecfg settings (96dpi, etc.). $ wine spider.exe Windows XP Spider Solitaire's "Difficulty" window now renders distorted "radio" buttons in the options list. This does not occur in Fedora 39 with default Wine 9.1 package. This happens with or with out using gamescope. I use gamescope to nearest neighbor / integer scale the game to playable size on a 4k display. Opening the game normally ($ wine spider.exe) shows the exact same issue with the radio buttons. This happens with both the 64bit and 32bit versions of the game. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #1 from garrett m <garrettm4(a)protonmail.com> --- Created attachment 77240 --> https://bugs.winehq.org/attachment.cgi?id=77240 distorted radio buttons (using gamescope to upscale image with integer/nearest neighbor scaling) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #2 from garrett m <garrettm4(a)protonmail.com> --- Created attachment 77241 --> https://bugs.winehq.org/attachment.cgi?id=77241 wine 9.1, radio buttons render fine -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression --- Comment #3 from Austin English <austinenglish(a)gmail.com> --- Please run a regression test: https://gitlab.winehq.org/wine/wine/-/wikis/Regression-Testing -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 garrett m <garrettm4(a)protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|WineHQ-devel-9.19: Renders |WineHQ-devel-9.19: Renders |Distorted Radio Buttons on |Distorted Radio Buttons on |WinXP Spider Solitaire |WinXP Solitaire -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 77245 --> https://bugs.winehq.org/attachment.cgi?id=77245 Screenshot (Working, but different) I assume the pictures are from "Solitaire", not "Spider Solitaire"? Also, my image looks pretty different, see attachment -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #5 from garrett m <garrettm4(a)protonmail.com> --- Ah, it looks like I changed the winecfg Theme from "Light" to "No Theme". Sorry, for the confusion. It looks fine with "Light" but distorted with "No Theme". And yeah, the images are for Solitare, I don't know how I mixed up the screen shots. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #6 from garrett m <garrettm4(a)protonmail.com> --- Created attachment 77246 --> https://bugs.winehq.org/attachment.cgi?id=77246 No Theme wine 9.19, distorted radio buttons, spider solitare -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 garrett m <garrettm4(a)protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77240|0 |1 is obsolete| | --- Comment #7 from garrett m <garrettm4(a)protonmail.com> --- Created attachment 77247 --> https://bugs.winehq.org/attachment.cgi?id=77247 No Theme wine 9.19, distorted radio buttons, solitare -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Component|-unknown |win32u Ever confirmed|0 |1 --- Comment #8 from Fabian Maurer <dark.shadow4(a)web.de> --- Confirming, bisected to commit 5924ab4c5155d97f4b23a33e97258c1ec382ea02 Author: Elizabeth Figura <zfigura(a)codeweavers.com> Date: Fri Sep 27 23:00:56 2024 -0500 win32u: Implement drawing transformed round rectangles. Wine-Bug: http://bugs.winehq.org/show_bug.cgi?id=35331 I'd add the author to CC, but bugzilla won't let me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #9 from garrett m <garrettm4(a)protonmail.com> --- Thank you, Fabian! Hopefully this regression gets fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair(a)hotmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |5924ab4c5155d97f4b23a33e972 | |58c1ec382ea02 CC| |alexhenrie24(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=57306 --- Comment #10 from Fabian Maurer <dark.shadow4(a)web.de> --- Same regression as from bug 57306, but no crash here. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 Vijay Kamuju <infyquest(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |7e80632d46c9558bb8057a79d59 | |ee0daff74d9a1 CC| |infyquest(a)gmail.com --- Comment #11 from Vijay Kamuju <infyquest(a)gmail.com> --- Fix committed, please test with wine 9.20 https://gitlab.winehq.org/wine/wine/-/commit/7e80632d46c9558bb8057a79d59ee0d... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #12 from Fabian Maurer <dark.shadow4(a)web.de> --- Yes, works great - thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #13 from garrett m <garrettm4(a)protonmail.com> --- I just tested this on Wine 9.20, and the issue has improved, but isn't fixed yet: The new radio buttons are too large when compared to previous version of wine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #14 from garrett m <garrettm4(a)protonmail.com> --- Created attachment 77308 --> https://bugs.winehq.org/attachment.cgi?id=77308 solitaire with Wine 9.20, radio buttons are now larger than Wine 9.1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #15 from garrett m <garrettm4(a)protonmail.com> --- Created attachment 77309 --> https://bugs.winehq.org/attachment.cgi?id=77309 Upscaled images of the radio buttons for Wine 9.1, 9.19 and 9.20. We are getting closer, but the new buttons are slightly too large -- when compared to previous Wine 9.1 behavior. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #16 from Zeb Figura <z.figura12(a)gmail.com> --- (In reply to garrett m from comment #15)
Created attachment 77309 [details] Upscaled images of the radio buttons for Wine 9.1, 9.19 and 9.20.
We are getting closer, but the new buttons are slightly too large -- when compared to previous Wine 9.1 behavior.
Is this a meaningful regression? For that matter, is it even certainly wrong? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #17 from Fabian Maurer <dark.shadow4(a)web.de> --- I can confirm that WinXP looks like wine-9.1, and wine-9.20 looks different. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #18 from garrett m <garrettm4(a)protonmail.com> --- Created attachment 77312 --> https://bugs.winehq.org/attachment.cgi?id=77312 Original WinXP "Classic Theme" Behavior (In reply to Zeb Figura from comment #16)
(In reply to garrett m from comment #15)
Created attachment 77309 [details] Upscaled images of the radio buttons for Wine 9.1, 9.19 and 9.20.
We are getting closer, but the new buttons are slightly too large -- when compared to previous Wine 9.1 behavior.
Is this a meaningful regression? For that matter, is it even certainly wrong?
Objectively, the new buttons in 9.20 looks worse than 9.1 -- they still look slightly distorted. But, to be fair, even 9.1 was slightly different than classic Windows behavior, but much closer than than 9.20. I realize this is nitpicking, but the original 9.1 rendering looked good and this recent change affects NotePad++ and other modern apps that also use "classic" Windows radio buttons. So it's not just Windows XP card games that are affected by this regression. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #19 from Zeb Figura <z.figura12(a)gmail.com> --- I guess I'm not sure I see what's distorted about them? They're one pixel larger, but the circle seems fine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 --- Comment #20 from garrett m <garrettm4(a)protonmail.com> --- Yes, but that "one" pixel enlargement in 9.20 causes the radio buttons look like "plus signs" rather than circles. There is a delicate balance in the pixel layout / coloring needed for them to look circular at the new size. Its much like mouse cursors: One can't simply enlarge everything by one pixel and have it look the same, integer amounts sure, but arbitrary scaling of UI elements is tricky -- as we can see here with classic radio buttons. Anyways, I think the primary issue comes from the "center dot" being made too large. This then causes the "outer ring" of the button to be expanded in a way that causes the overall button to look like a + and, hence, distorted. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57296 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #21 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 9.21. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla