[Bug 19562] New: Guitar Hero World Tour crashes after dinput GetProperty
http://bugs.winehq.org/show_bug.cgi?id=19562 Summary: Guitar Hero World Tour crashes after dinput GetProperty Product: Wine Version: 1.1.26 Platform: PC URL: http://worldtour.guitarhero.com/uk/ OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: directx-dinput AssignedTo: wine-bugs(a)winehq.org ReportedBy: andras(a)csevego.net After I set a fake paging file in regedit, game will crash after this line: warn:dinput:IDirectInputDevice2AImpl_GetProperty Unknown property <guid-0x0018> The problem is, we return DI_OK instead of an error code. It can be fixed with this: diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c index 941206c..cb66b03 100644 --- a/dlls/dinput/device.c +++ b/dlls/dinput/device.c @@ -888,6 +896,7 @@ HRESULT WINAPI IDirectInputDevice2AImpl_GetProperty( } default: WARN("Unknown property %s\n", debugstr_guid(rguid)); + return DIERR_INVALIDPARAM; break; } -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19562 Andras Kovacs <andras(a)csevego.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19563 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19562 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19562 --- Comment #1 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-08-06 00:38:05 --- The patch looks ok in principle. The problem is - lots of programs will break because of this. Be ready to implement every single missing property handling, if you send this patch in. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19562 --- Comment #2 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-08-17 00:41:01 --- Go ahead and send this patch. Make sure to change WARN into FIXME it will help fixing resulting problems. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19562 --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2010-09-07 16:16:54 CDT --- I sent the patch in: http://source.winehq.org/patches/data/65862 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19562 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #4 from Austin English <austinenglish(a)gmail.com> 2010-09-16 15:03:02 CDT --- Patch committed: http://source.winehq.org/git/wine.git/?a=commitdiff;h=cde699b286789a5dc56333... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19562 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> 2010-09-18 13:05:56 CDT --- Closing bugs fixed in 1.3.3. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org