[Bug 58108] New: Viewing attachments as 'Raw Unified' corrupts patches.

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58108

            Bug ID: 58108
           Summary: Viewing attachments as 'Raw Unified' corrupts patches.
           Product: WineHQ Bugzilla
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: bugzilla-unknown
          Assignee: wine-bugs(a)winehq.org
          Reporter: chiitoo(a)gentoo.org
                CC: austinenglish(a)gmail.com
      Distribution: Gentoo

This is a pretty old issue, but I can't find anyone else having reported it.

Viewing an attached patch as 'Raw Unified' mangles the patch above filenames so
that it looks like this example:

----

@@ -, +, @@ 
    mshtml HACK: Do not expose MutationObserver stub.

    FFXIV Launcher breaks with MutationObserver stub so it needs a proper
    implementation.
--- a/dlls/mshtml/mutation.c    
+++ a/dlls/mshtml/mutation.c    
@@ -1217,7 +1217,7 @@ dispex_static_data_t MutationObserver_dispex = {
     .vtbl             = &mutation_observer_dispex_vtbl,
     .disp_tid         = IWineMSHTMLMutationObserver_tid,
     .iface_tids       = mutation_observer_iface_tids,
-    .min_compat_mode  = COMPAT_MODE_IE11,
+    .min_compat_mode  = COMPAT_MODE_IE11 + 1,  /* FIXME HACK: Not exposed as
FFXIV Launcher breaks with MutationObserver stub */
 };

 static HRESULT create_mutation_observer(DispatchEx *owner, IDispatch
*callback,

----

The 'Details' option displays the diff correctly:

----

commit 200935d77464cd4eaf9733ec9c0003236ef22524
Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com>
Date:   Wed Mar 19 23:39:09 2025 +0200

    mshtml HACK: Do not expose MutationObserver stub.

    FFXIV Launcher breaks with MutationObserver stub so it needs a proper
    implementation.

diff --git a/dlls/mshtml/mutation.c b/dlls/mshtml/mutation.c
index a203c03e2dc..b5ce4b6755b 100644
--- a/dlls/mshtml/mutation.c
+++ b/dlls/mshtml/mutation.c
@@ -1217,7 +1217,7 @@ dispex_static_data_t MutationObserver_dispex = {
     .vtbl             = &mutation_observer_dispex_vtbl,
     .disp_tid         = IWineMSHTMLMutationObserver_tid,
     .iface_tids       = mutation_observer_iface_tids,
-    .min_compat_mode  = COMPAT_MODE_IE11,
+    .min_compat_mode  = COMPAT_MODE_IE11 + 1,  /* FIXME HACK: Not exposed as
FFXIV Launcher breaks with MutationObserver stub */
 };

 static HRESULT create_mutation_observer(DispatchEx *owner, IDispatch
*callback,

----

Attachment source: https://bugs.winehq.org/show_bug.cgi?id=48006#c58

Click on 'attachment 78365' and then 'Raw Unified'.

Thank you!

-- 
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.