[Bug 36201] New: valgrind shows a definite leak under crypt32/tests/store.c
https://bugs.winehq.org/show_bug.cgi?id=36201 Bug ID: 36201 Summary: valgrind shows a definite leak under crypt32/tests/store.c Product: Wine Version: 1.7.17 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: crypt32 Assignee: wine-bugs(a)winehq.org Reporter: austinenglish(a)gmail.com Created attachment 48322 --> https://bugs.winehq.org/attachment.cgi?id=48322 valgrind log ==18714== 48 bytes in 1 blocks are definitely lost in loss record 215 of 443 ==18714== at 0x7BC4C6B7: notify_alloc (heap.c:255) ==18714== by 0x7BC50EFB: RtlAllocateHeap (heap.c:1716) ==18714== by 0x514398B: CryptMemAlloc (main.c:124) ==18714== by 0x511E5A6: Context_CreateLinkContext (context.c:60) ==18714== by 0x510AB00: Cert_clone (cert.c:127) ==18714== by 0x511D199: CRYPT_CollectionCreateContextFromChild (collectionstore.c:85) ==18714== by 0x511D5C9: Collection_addCert (collectionstore.c:215) ==18714== by 0x510B119: add_cert_to_store (cert.c:263) ==18714== by 0x510B27F: CertAddCertificateContextToStore (cert.c:287) ==18714== by 0x510A852: CertAddEncodedCertificateToStore (cert.c:65) ==18714== by 0x4EA953F: testCollectionStore (store.c:670) ==18714== by 0x4EB2BF4: func_store (store.c:2790) ==18714== by 0x4EB7F67: run_test (test.h:584) ==18714== by 0x4EB8356: main (test.h:654) ==18714== and several potential leaks, e.g.,: ==18714== 20 bytes in 1 blocks are possibly lost in loss record 53 of 443 ==18714== at 0x7BC4C6B7: notify_alloc (heap.c:255) ==18714== by 0x7BC50EFB: RtlAllocateHeap (heap.c:1716) ==18714== by 0x514398B: CryptMemAlloc (main.c:124) ==18714== by 0x511E0A9: CertAddStoreToCollection (collectionstore.c:519) ==18714== by 0x5164B4B: CRYPT_SysOpenStoreW (store.c:592) ==18714== by 0x5164D74: CRYPT_SysOpenStoreA (store.c:644) ==18714== by 0x5165ADF: CertOpenStore (store.c:907) ==18714== by 0x5165B53: CertOpenSystemStoreA (store.c:919) ==18714== by 0x4EA9419: testCollectionStore (store.c:658) ==18714== by 0x4EB2BF4: func_store (store.c:2790) ==18714== by 0x4EB7F67: run_test (test.h:584) ==18714== by 0x4EB8356: main (test.h:654) ==18714== full log attached -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 --- Comment #1 from Austin English <austinenglish(a)gmail.com> --- Another one: ==18776== 48 bytes in 1 blocks are definitely lost in loss record 217 of 458 ==18776== at 0x7BC4C6B7: notify_alloc (heap.c:255) ==18776== by 0x7BC50EFB: RtlAllocateHeap (heap.c:1716) ==18776== by 0x514398B: CryptMemAlloc (main.c:124) ==18776== by 0x511E5A6: Context_CreateLinkContext (context.c:60) ==18776== by 0x510AB00: Cert_clone (cert.c:127) ==18776== by 0x511D199: CRYPT_CollectionCreateContextFromChild (collectionstore.c:85) ==18776== by 0x511D485: CRYPT_CollectionAdvanceEnum (collectionstore.c:174) ==18776== by 0x511D6EE: Collection_enumCert (collectionstore.c:247) ==18776== by 0x5165CB9: CertEnumCertificatesInStore (store.c:946) ==18776== by 0x4EA9007: testCollectionStore (store.c:602) ==18776== by 0x4EB2BF4: func_store (store.c:2790) ==18776== by 0x4EB7F67: run_test (test.h:584) ==18776== by 0x4EB8356: main (test.h:654) ==18776== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |valgrind -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 donanykey(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |donanykey(a)gmail.com --- Comment #2 from donanykey(a)gmail.com --- Hi Austin, You might want to re-test this, I am not reported any leaks in `store` tests with 1.9.22 and wineserver running in a separate process -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 --- Comment #3 from donanykey(a)gmail.com --- Please read "wineserver launched beforehand and kept running to check leaks in tests only" in my previous comment where "separate process", sorry for typo -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 --- Comment #4 from Austin English <austinenglish(a)gmail.com> --- I see: ==17365== 48 bytes in 1 blocks are definitely lost in loss record 246 of 538 ==17365== at 0x7BC50754: notify_alloc (heap.c:254) ==17365== by 0x7BC54BD5: RtlAllocateHeap (heap.c:1716) ==17365== by 0x4DA434F: CryptMemAlloc (main.c:123) ==17365== by 0x4D7CDDE: Context_CreateDataContext (context.c:32) ==17365== by 0x4D6B2BD: CertCreateCertificateContext (cert.c:334) ==17365== by 0x4C105CA: testEmptyStore (store.c:2945) ==17365== by 0x4C119BC: func_store (store.c:3208) ==17365== by 0x4C1619E: run_test (test.h:589) ==17365== by 0x4C165CA: main (test.h:671) ==17365== with 2.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 --- Comment #5 from Austin English <austinenglish(a)gmail.com> --- (In reply to Austin English from comment #4)
I see: ==17365== 48 bytes in 1 blocks are definitely lost in loss record 246 of 538 ==17365== at 0x7BC50754: notify_alloc (heap.c:254) ==17365== by 0x7BC54BD5: RtlAllocateHeap (heap.c:1716) ==17365== by 0x4DA434F: CryptMemAlloc (main.c:123) ==17365== by 0x4D7CDDE: Context_CreateDataContext (context.c:32) ==17365== by 0x4D6B2BD: CertCreateCertificateContext (cert.c:334) ==17365== by 0x4C105CA: testEmptyStore (store.c:2945) ==17365== by 0x4C119BC: func_store (store.c:3208) ==17365== by 0x4C1619E: run_test (test.h:589) ==17365== by 0x4C165CA: main (test.h:671) ==17365==
with 2.1.
Still in 2.12: ../../../tools/runtest -q -P wine -T ../../.. -M crypt32.dll -p crypt32_test.exe.so store && touch store.ok ==16985== 48 bytes in 1 blocks are definitely lost in loss record 255 of 547 ==16985== at 0x7BC50812: notify_alloc (heap.c:254) ==16985== by 0x7BC54C93: RtlAllocateHeap (heap.c:1716) ==16985== by 0x4C13BCA: CryptMemAlloc (main.c:123) ==16985== by 0x4BEC659: Context_CreateDataContext (context.c:32) ==16985== by 0x4BDAB38: CertCreateCertificateContext (cert.c:334) ==16985== by 0x4A78E19: testEmptyStore (store.c:2921) ==16985== by 0x4A7A1F0: func_store (store.c:3183) ==16985== by 0x4A7EA74: run_test (test.h:603) ==16985== by 0x4A7EEC6: main (test.h:687) ==16985== -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 --- Comment #6 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- Created attachment 63275 --> https://bugs.winehq.org/attachment.cgi?id=63275 test patch (In reply to Austin English from comment #5)
-snip-
Does this patch work? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 --- Comment #7 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #6)
Created attachment 63275 [details] test patch
(In reply to Austin English from comment #5)
-snip-
Does this patch work?
https://source.winehq.org/git/wine.git/commit/a15d4de557ac2ba3b2418cb39fc608... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |a15d4de557ac2ba3b2418cb39fc | |6080a7523e604 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Austin English <austinenglish(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #7)
(In reply to Gijs Vermeulen from comment #6)
Created attachment 63275 [details] test patch
(In reply to Austin English from comment #5)
-snip-
Does this patch work?
https://source.winehq.org/git/wine.git/commit/ a15d4de557ac2ba3b2418cb39fc6080a7523e604
Thanks, fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=36201 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org