[Bug 15201] New: Google Chrom crashes when downloading an exe file
http://bugs.winehq.org/show_bug.cgi?id=15201 Summary: Google Chrom crashes when downloading an exe file Product: Wine Version: CVS/GIT Platform: Other URL: http://chrome.google.com OS/Version: other Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: royshea(a)gmail.com Created an attachment (id=15956) --> (http://bugs.winehq.org/attachment.cgi?id=15956) Terminal output after crash running chrome with --no-sandbox --new-http Google Chrome crashes when downloading an executable file. Other types of downloads appear to be fine. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com Summary|Google Chrom crashes when |Google Chrome crashes when |downloading an exe file |downloading an exe file -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 Vincent Povirk <madewokherd(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd(a)gmail.com --- Comment #1 from Vincent Povirk <madewokherd(a)gmail.com> 2008-09-09 20:39:54 --- This is because Google Chrom calls SHGetFileInfo with the SHGFI_ICON flag set and expects that it will always get an icon. With Wine's implementation of SHGetFileInfo, that doesn't happen for .exe files that do not contain icons (I think that Wine should return an icon for any file, but I don't know how to fix this case). Google Chrom calls SHGetFileInfo with partially downloaded .exe files that may not contain an icon yet (or ever). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 --- Comment #2 from Roy Shea <royshea(a)gmail.com> 2008-09-10 16:10:14 --- Created an attachment (id=15997) --> (http://bugs.winehq.org/attachment.cgi?id=15997) Patch allowing SHGetFileInfoW to use default icons when PrivateExtractIconsW fails (In reply to comment #1)
calls SHGetFileInfo with the SHGFI_ICON flag set and expects that it will always get an icon. With Wine's implementation of SHGetFileInfo, that doesn't happen
Looks like there was problem with wine not checking the return value of PrivateExtractIconsW. The attached patch fixs this problem. I'll send it off to wine-patches momentarily. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, patch, source -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 Roy Shea <royshea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from Roy Shea <royshea(a)gmail.com> 2008-09-11 12:28:54 --- Patch committed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 Roy Shea <royshea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Roy Shea <royshea(a)gmail.com> 2008-09-11 12:31:20 --- Closing bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |UNCONFIRMED Resolution|FIXED | --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> 2008-09-11 12:47:51 --- Please don't close fixed bugs until they have made it into a release. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> 2008-09-11 12:48:02 --- Fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> 2008-09-19 11:17:48 --- Closing bugs fixed in 1.1.5. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=15201 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org