[Bug 50020] New: mf:mf tests crash on Windows 7
https://bugs.winehq.org/show_bug.cgi?id=50020 Bug ID: 50020 Summary: mf:mf tests crash on Windows 7 Product: Wine Version: 5.19 Hardware: x86-64 OS: Windows Status: UNCONFIRMED Severity: normal Priority: P2 Component: mfplat Assignee: wine-bugs(a)winehq.org Reporter: sven.wine(a)gmail.com I feel like these tests don't actually test the right thing. If I change https://source.winehq.org/git/wine.git/blob/0c249e6125fc9dc6ee86b4ef6ae0d9fa... to hr = IMFMediaTypeHandler_GetMediaTypeByIndex(handler, count-1, &mediatype2); ok(hr == S_OK, "Failed to get media type, hr %#x.\n", hr); hr = IMFMediaTypeHandler_GetMediaTypeByIndex(handler, count-1, &mediatype3); ok(hr == S_OK, "Failed to get media type, hr %#x.\n", hr); I get Windows 7: mf.c:3017: Test failed: Unexpected hr 0. mf.c:3049: Test failed: Failed to set current type, hr 0xc00d36b4. mf.c:3053: Test failed: Unexpected instance. mf.c:3125: Test failed: Failed to get interface, hr 0. Windows 8: mf.c:3017: Test failed: Unexpected hr 0. mf.c:3049: Test failed: Failed to set current type, hr 0xc00d4650. mf.c:3053: Test failed: Unexpected instance. mf.c:3125: Test failed: Failed to get interface, hr 0. Windows 10 1507: mf.c:3017: Test failed: Unexpected hr 0. mf.c:3049: Test failed: Failed to set current type, hr 0xc00d4650. mf.c:3053: Test failed: Unexpected instance. mf.c:3125: Test failed: Failed to get interface, hr 0. Windows 10 1809: mf.c:3017: Test failed: Unexpected hr 0. This is sort of consistent across all versions. So I feel like Wine is currently mimicking behaviour that holds only for some random media type which happens to not work on Windows 7 (Wine currently only has one media type available from GetMediaTypeByIndex). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50020 Sven <sven.wine(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source, testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50020 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- Yes, it is messed up. Type handler is supposed to return what it can support, and then there is this inconsistency when type is accepted but IsMediaTypeSupported() fails for it. To fix the tests we could iterate until we find first type that passes IsMediaTypeSupported() probably. I'll take a look, I vaguely remember that SAR returns some very similar types only differing in presence of additional attributes, maybe that's what happens. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50020 Sven Baars <sven.wine(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |f6a5a3d03c1eb914444af96352c | |a54eec79d7e2c --- Comment #2 from Sven Baars <sven.wine(a)gmail.com> --- This was fixed by f6a5a3d03c1eb914444af96352ca54eec79d7e2c. Thanks Nikolay! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=50020 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #3 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.20. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla