[Bug 44845] New: Bankperfect plugins installation regression
https://bugs.winehq.org/show_bug.cgi?id=44845 Bug ID: 44845 Summary: Bankperfect plugins installation regression Product: Wine Version: 3.4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: blocker Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: gdpo22(a)orange.fr Distribution: --- Created attachment 60898 --> https://bugs.winehq.org/attachment.cgi?id=60898 self-install-plugin that can be used without bankperfect installed When trying to install free auto-install-plugins in Bankperfect (just an extraction in the 'Scripts' subfolder of Bankperfect), the installer block on files (especially .png ones) It worked on ubuntu artful but no more on Bionic Beaver. In attachment an exemple from http://www.chelly.net/?page=bp_plugins named "Echéancier" Tried in win64 and win32. Same behavior. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal --- Comment #1 from Austin English <austinenglish(a)gmail.com> --- Not a blocker, please attach the terminal output. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #2 from Austin English <austinenglish(a)gmail.com> --- The content of attachment 60898 has been deleted for the following reason: Don't attach copyrighted binaries -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- Your description makes it sound like an Ubuntu upgrade broke it. Is this the case? Or was it rather a wine update that broke it? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Summary|Bankperfect plugins |Bankperfect plugin |installation regression |installater Echéancier | |hangs during install Keywords| |download, Installer, | |regression CC| |xerox.xerox2000x(a)gmail.com URL| |http://www.chelly.net/?page | |=bp_plugins --- Comment #4 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Confirming. What helped for me is ``winetricks cc580`` I tried in old wine-version wine-1.7.50 and there it works (tried 5 times) So somehow a regression. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #5 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Created attachment 60903 --> https://bugs.winehq.org/attachment.cgi?id=60903 revert comctl32 to wine-2.1 The attached patch reverts comctl32 back to wine-2.1 status. This makes the installer succeed, so somewhere between then and now it regressed. Generated with git diff 4256f6ebc641c4c5e3bdc1bec1684da1d511cb3b..afef57f872433bcd3032c2ccbc0453bef5b62178 -- dlls/comctl32 >z -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |comctl32 --- Comment #6 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- set component to comctl32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #7 from Guilmort <gdpo22(a)orange.fr> --- (In reply to Austin English from comment #2)
The content of attachment 60898 [details] has been deleted for the following reason:
Don't attach copyrighted binaries
OK but it is free to download from Chelly.net -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> --- Flickering list is the problem, right? I don't immediately see how this could be related to comctl32 changes. Ideally we'll need to do full regression test. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #9 from Guilmort <gdpo22(a)orange.fr> --- (In reply to Nikolay Sivov from comment #8)
Flickering list is the problem, right? I don't immediately see how this could be related to comctl32 changes. Ideally we'll need to do full regression test.
That's right. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #10 from Nikolay Sivov <bunglehead(a)gmail.com> --- Okay, thanks. I'll try to bisect it myself. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> --- This appears to be an older regression: 5fe449307f6604a781bcb9fe1b81185e3ea1cf51 is the first bad commit commit 5fe449307f6604a781bcb9fe1b81185e3ea1cf51 Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Thu May 18 13:11:04 2017 +0300 comctl32/listview: When adding a scrollbar, update the other one. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> :040000 040000 d18e10ade728d5cea90cf6cc3adc03a1fdbb6c90 a19d3945725c0164888369017a21503fb00f8796 M dlls -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |5fe449307f6604a781bcb9fe1b8 | |1185e3ea1cf51 CC| |alexhenrie24(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #12 from Alex Henrie <alexhenrie24(a)gmail.com> --- Created attachment 60958 --> https://bugs.winehq.org/attachment.cgi?id=60958 [PATCH] comctl32: Ensure that nPage <= nMax when calling SetScrollInfo This is the best explanation I've come up with for this bug: 1. The installer patches SetScrollbarInfo. 2. LISTVIEW_UpdateHScroll calls SetScrollbarInfo with a page number greater than the maximum. 3. The custom SetScrollbarInfo tries to correct the page number by doing something that ultimately results in LISTVIEW_UpdateHScroll being called again. The solution might be to make sure that the page number is less than or equal to the maximum before calling SetScrollbarInfo (patch attached). The bug disappears if you do that. Nikolay, what do you think? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #13 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Alex Henrie from comment #12)
The solution might be to make sure that the page number is less than or equal to the maximum before calling SetScrollbarInfo (patch attached). The bug disappears if you do that. Nikolay, what do you think?
This breaks things, unfortunately. With this patch scrollbars are always visible, even when control size is sufficiently large. I only tried LVS_ICON and LVS_REPORT, both are broken. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60958|0 |1 is obsolete| | --- Comment #14 from Alex Henrie <alexhenrie24(a)gmail.com> --- Created attachment 61169 --> https://bugs.winehq.org/attachment.cgi?id=61169 [PATCH] comctl32: Reduce listview detail view scroll width by 1px Thanks Nikolay. Could this be an off-by-one error? With this patch, the horizontal scrollbar doesn't appear at all, just like on Windows, and the installer completes successfully. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 --- Comment #15 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Alex Henrie from comment #14)
Created attachment 61169 [details] [PATCH] comctl32: Reduce listview detail view scroll width by 1px
Thanks Nikolay. Could this be an off-by-one error? With this patch, the horizontal scrollbar doesn't appear at all, just like on Windows, and the installer completes successfully.
We have this part a bit down: --- horzInfo.fMask = SIF_RANGE | SIF_PAGE; horzInfo.nMax = max(horzInfo.nMax - 1, 0); --- so with your change it will do -2, that looks strange to me. Is it possible it's scrollbar logic issue instead? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 tokktokk <fdsfgs(a)krutt.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs(a)krutt.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61169|0 |1 is obsolete| | --- Comment #16 from Alex Henrie <alexhenrie24(a)gmail.com> --- Comment on attachment 61169 --> https://bugs.winehq.org/attachment.cgi?id=61169 [PATCH] comctl32: Reduce listview detail view scroll width by 1px I wrote a test program and determined that there is no off-by-one error in our computation of the report listview horizontal scroll maximum. On both Windows and Wine, the horizontal scrollbar appears exactly when the item width is greater than the client area width. In other words, my patch is wrong and would create more problems. The bug is definitely somewhere in comctl32 though, because the installer works perfectly after running `winetricks comctl32`. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=35529 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |8e9ea7a8a163147012908bad696 | |a539454654d8f --- Comment #17 from Alex Henrie <alexhenrie24(a)gmail.com> --- I'm marking this bug as fixed because the installer works as of https://source.winehq.org/git/wine.git/commitdiff/8e9ea7a8a163147012908bad69... There is one small problem remaining: The installer shows a horizontal scrollbar when there should not be one. If this bothers you, please open a new bug report and CC me on it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #18 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.9. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44845 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.0.x |--- --- Comment #19 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 3.0.x milestone from bugs included in 3.0.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org