[Bug 57306] New: Commit 5924ab4c515 breaks Nikon NX studio due to memory corruption
https://bugs.winehq.org/show_bug.cgi?id=57306 Bug ID: 57306 Summary: Commit 5924ab4c515 breaks Nikon NX studio due to memory corruption Product: Wine Version: 9.19 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: christoph.bartoschek(a)gmail.com Distribution: --- Nikion NX Studio is crashing with errors like the following one since commit 5924ab4c515: 0024:fixme:uxtheme:BufferedPaintInit Stub () double free or corruption (out) 0024:err:seh:call_seh_handlers invalid frame 00007FFFFE0FECD0 (0000000000022000-0000000000120000) 0024:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception. By adding enough debug logs I see that: - In function dibdrv_RoundRect from dlls/win32u/dibdrv/graphics.c max_points becomes 30. - Then top_points is allocated at size 15. - The first call to get_arc_points returns 4: count = get_arc_points( dc, AD_CLOCKWISE, &rect, start, end, top_points ); - The second call time it is called with top_points + counter which is &top_points[4]. - Inside get_arc_points count becomes 8: count = generate_ellipse_top_half( dc, width, height, points ); - Then the loop to calculate points starts with pos = count and it has 4 iterations. - The last write is to points[8+3] = points[11] = top_points[11 + 4] = top_points[15]. - top_points[15] is beyond the allocated array and it corrupts memory metadata. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |5924ab4c5155d97f4b23a33e972 | |58c1ec382ea02 CC| |z.figura12(a)gmail.com Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de Summary|Commit 5924ab4c515 breaks |Multiple programs crash due |Nikon NX studio due to |to memory corruption since |memory corruption |5924ab4c515 (Nikon NX | |studio, Profit, Falcosoft's | |Soundfont Midi Player, | |IBExpert) Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Confirming and collecting duplicates. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielbermond(a)yahoo.com --- Comment #2 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 57307 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |1293660441(a)qq.com --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 57298 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msmucr(a)gmail.com --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 57299 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.winehq.org/sho | |w_bug.cgi?id=57296 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #5 from Fabian Maurer <dark.shadow4(a)web.de> --- Same regression in bug 57296, but no crash there. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #6 from Jactry Zeng <jactry92(a)gmail.com> --- Bug 57301 probably is another duplication. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #7 from sondre.husevold(a)tietoevry.com --- Created attachment 77266 --> https://bugs.winehq.org/attachment.cgi?id=77266 dib trace of proprietary application for 5924ab4c515 regression Partial application log (dib trace) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #8 from sondre.husevold(a)tietoevry.com --- Comment on attachment 77266 --> https://bugs.winehq.org/attachment.cgi?id=77266 dib trace of proprietary application for 5924ab4c515 regression Our proprietary application also crashes due to this commit (5924ab4c515). By opening any internal "browse" MDI window the application will promptly crash due to an assert in win32u/dibdrv/objects.c:812 in the function solid_pen_lines. Reverting the commit 5924ab4c515 on the latest HEAD will resolve the issue and make the application work properly again. If this is not related to this issue, I can make another bug report. Or if you need a more detailed log I can flesh out the details. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #9 from sondre.husevold(a)tietoevry.com --- Comment on attachment 77266 --> https://bugs.winehq.org/attachment.cgi?id=77266 dib trace of proprietary application for 5924ab4c515 regression Our proprietary application also crashes due to this commit (5924ab4c515). By opening any internal "browse" MDI window the application will promptly crash due to an assert in win32u/dibdrv/objects.c:812 in the function solid_pen_lines. Reverting the commit 5924ab4c515 on the latest HEAD will resolve the issue and make the application work properly again. If this is not related to this issue, I can make another bug report. Or if you need a more detailed log I can flesh out the details. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.franz(a)arcor.de --- Comment #10 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 57301 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #11 from Rafał Mużyło <galtgendo(a)o2.pl> --- Given what was said in OP, perhaps sufficient solution would be something like from: top_points = malloc( max_points / 2 * sizeof(*points) ); to: top_points = malloc( (max_points + 1) / 2 * sizeof(*points) ); What do you think ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #12 from Rafał Mużyło <galtgendo(a)o2.pl> --- The way I see it, generate_ellipse_top_half is just badly commented - it seem to make some implicit assumptions about its inputs, but doesn't seem to state those assumptions anywhere. The algorithm is likely correct is all but 'points[pos++] = pt;' line, that is it never states what size it expects that array to be - well, the original algorithm likely just drawn a point at that point, instead of storing it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #13 from Zeb Figura <z.figura12(a)gmail.com> --- Thanks for the feedback, Rafał. What exactly would you do differently? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #14 from Rafał Mużyło <galtgendo(a)o2.pl> --- (In reply to Zeb Figura from comment #13)
Thanks for the feedback, Rafał. What exactly would you do differently?
Gee, I don't know, pass the size of that array ? Do we really need to have a sarcasm spar ? Or did I perhaps miss a commit where you did explicitly state the assumptions the code makes, given that as the original algorithm was made for drawing, not storing, so doesn't have any inherent limits on how many points it would be able to handle ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |asciioct146125103153g00gle@ | |gmail.com --- Comment #15 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 57317 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #16 from Zeb Figura <z.figura12(a)gmail.com> --- Well, Rafał, I think if you read the surrounding code, it becomes clear that the "max_points" variable, returned by a function called "get_arc_max_points", is supposed to hold the maximum possible number of points returned from get_arc_points(). I think if you're familiar with code idioms, you might understand that this kind of pattern is not uncommon, and it's typically used when you want to avoid allocating more than once (an expensive action) and performing an expensive calculation more than once. I think if you read the regression commit, you might notice that the code used this pattern already. Is the pattern fragile? Probably. Is it to blame for the regression in this case? I would say so. Did I consider this possibility when writing it? Why, yes, I did, and I decided to leave the code as-is, because I'm not about to change more than I absolutely need to. But yet another wildly uninformed, wildly incorrect diagnosis, that demonstrates little to no understanding of the code in question, given with a know-it-all attitude, really irks me. I must nevertheless apologize for letting it get to me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #17 from Rafał Mużyło <galtgendo(a)o2.pl> --- If 'it becomes clear' could you explain the existence of mr6662 ? Cause it seems even more frequent contributors got confused by this code... And frankly, you've just wrote the code, how certain are you you'll still understand it in 4-5 years ? That's my point on why an additional comment would be welcome. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 DarkOK <dark(a)darkok.xyz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark(a)darkok.xyz --- Comment #18 from DarkOK <dark(a)darkok.xyz> --- I'm also experiencing this issue with Viena, where I get the following assertion after clicking the sidebar to select samples, instruments or presets: wine-9.19/dlls/win32u/dibdrv/objects.c:812: solid_pen_lines: Assertion `num >= 2' failed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #19 from Zeb Figura <z.figura12(a)gmail.com> --- (In reply to Rafał Mużyło from comment #17)
If 'it becomes clear' could you explain the existence of mr6662 ? Cause it seems even more frequent contributors got confused by this code...
If you read the merge request, you'll note that what's confusing Aida is clearly not the fact that the overallocation pattern is used. She's guessing at the way in which get_arc_max_points() is not returning a high enough value.
And frankly, you've just wrote the code, how certain are you you'll still understand it in 4-5 years ? That's my point on why an additional comment would be welcome.
Pretty certain, given that I understood the pattern when I first approached it to make this change. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #20 from Rafał Mużyło <galtgendo(a)o2.pl> --- ...are you aware of that that little thing called 'bus factor' ? You know, that thing that metaphorically happen at least once in wine history. Or if you were to quit the project for whatever the reason. But you do you, whatevs... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Vijay Kamuju <infyquest(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest(a)gmail.com --- Comment #21 from Vijay Kamuju <infyquest(a)gmail.com> --- Can we close this as fix is committed - https://gitlab.winehq.org/wine/wine/-/commit/f4b46cef3fa7db1dbca332049d4b14b... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #22 from Fabian Maurer <dark.shadow4(a)web.de> --- Even with latest git I can reproduce a crash with HeidiSQL 7.0: https://web.archive.org/web/20130612145220/http://heidisql.googlecode.com/fi... Just run the heidisql.exe, and click the "New" button. Reverting 5924ab4c5155d97f4b23a33e97258c1ec382ea02 fixes the issue, so this is not yet fully fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wpha(a)aol.com --- Comment #23 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 57352 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #24 from Fabian Maurer <dark.shadow4(a)web.de> --- Also still affects mspaint from WinXP, see bug 57306. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #25 from Fabian Maurer <dark.shadow4(a)web.de> --- I mean, bug 57352. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #26 from Michal Smucr <msmucr(a)gmail.com> --- (In reply to Fabian Maurer from comment #22)
Even with latest git I can reproduce a crash with HeidiSQL 7.0:
I can confirm the exact same behavior also with the last stable version of HeidiSQL 12.8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Jérôme Groven <jerome.groven(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jerome.groven(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #27 from Christoph Bartoschek <christoph.bartoschek(a)gmail.com> --- HeidSQL calls the function BOOL dibdrv_RoundRect( PHYSDEV dev, INT left, INT top, INT right, INT bottom, INT ellipse_width, INT ellipse_height ) with ellipse_width == 0 and ellipse_height == 0, resulting in max_points == 0. Then in get_arc_poitns the empty top_points array is written to. I guess, either the function has to return early in such a case or one needs to check why the ellipse_width and ellipse_height are both 0 and fix the calling location. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #28 from Zeb Figura <z.figura12(a)gmail.com> --- (In reply to Christoph Bartoschek from comment #27)
HeidSQL calls the function
BOOL dibdrv_RoundRect( PHYSDEV dev, INT left, INT top, INT right, INT bottom, INT ellipse_width, INT ellipse_height )
with ellipse_width == 0 and ellipse_height == 0, resulting in max_points == 0. Then in get_arc_poitns the empty top_points array is written to.
I guess, either the function has to return early in such a case or one needs to check why the ellipse_width and ellipse_height are both 0 and fix the calling location.
We should probably restore the forward to Rectangle() in this case. Previously it was applied when the width/height was <= 2, but this is incorrect if there is scaling. But forwarding for 0 is still correct. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francisco278herrera(a)gmail.c | |om --- Comment #29 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 57350 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Zeb Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpleonard12(a)gmail.com --- Comment #30 from Zeb Figura <z.figura12(a)gmail.com> --- *** Bug 57316 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 aug <augusto7744(a)aol.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |augusto7744(a)aol.com --- Comment #31 from aug <augusto7744(a)aol.com> --- Happen exactly that same bug when starting Visual Pinball X and Visual PinMAME settings menu too. I have created an bug report about it with screenshot. https://bugs.winehq.org/show_bug.cgi?id=57379#c0 Thanks very much WINE developers for making WINE. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #32 from Zeb Figura <z.figura12(a)gmail.com> --- *** Bug 57379 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #33 from aug <augusto7744(a)aol.com> --- Please what is the WINE version was done commit 5924ab4c515 ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #34 from F H <francisco278herrera(a)gmail.com> --- As of the latest git commit the issue seems to be fixed for notepad++. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #35 from aug <augusto7744(a)aol.com> --- WINE 9.21 has fixed thet bug below ? Anyone has tested it ? 0024:fixme:system:SetDisplayAutoRotationPreferences (1): stub dlls/win32u/dibdrv/objects.c:812: solid_pen_lines: Assertion `num >= 2' failed. 0024:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 fhb33435b(a)postedmail.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fhb33435b(a)postedmail.net --- Comment #36 from fhb33435b(a)postedmail.net --- Pradis6.exe still crashes on 9.21: 0244:err:ole:marshal_object Failed to create an IRpcStubBuffer from IPSFactory for {df0b3d60-548f-101b-8e65-08002b2bd119} with error 0x80004002 OND~5A4\Pradis\pradis6.exe: dlls/win32u/dibdrv/objects.c:812: solid_pen_lines: Assertion `num >= 2' failed. 0228:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #37 from aug <augusto7744(a)aol.com> --- @fhb33435b(a)postedmail.net Thanks very for replying ! I have go back to 9.28 and not more errors crashing and menu settings buttons with wrong graphics. In WINE 9.21 changelog not has any fixes for that bug. About that commit has details about done more code to run "correctly" so that commit not was reverted and not was done test. Return to 9.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Dimitrios <temp2417(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |temp2417(a)gmail.com --- Comment #38 from Dimitrios <temp2417(a)gmail.com> --- Also affects "Paintshop Pro 7", since Wine version 9.18 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #39 from Dimitrios <temp2417(a)gmail.com> --- Created attachment 77467 --> https://bugs.winehq.org/attachment.cgi?id=77467 Terminal output Paintshop Pro 7, can attach debug trace if needed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #40 from fhb33435b(a)postedmail.net --- Pradis6.exe still crashes on initiation on WINE 9.22 but without the error messages about solid pen lines or frame not in stack limits. Something seems to have been fixed, but a problem remains which prevents the program from running: 01b4:err:ole:marshal_object Failed to create an IRpcStubBuffer from IPSFactory for {df0b3d60-548f-101b-8e65-08002b2bd119} with error 0x80004002 017c:err:ole:CoReleaseMarshalData StdMarshal ReleaseMarshalData failed with error 0x8001011d 01a0:err:ole:CoReleaseMarshalData StdMarshal ReleaseMarshalData failed with error 0x8001011d -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 GDD71 <gdd71(a)abv.bg> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gdd71(a)abv.bg --- Comment #41 from GDD71 <gdd71(a)abv.bg> --- Multisim also still crashes on WINE 9.22 /.wine/drive_c/Program Files (x86)/National Instruments/Circuit Design Suite 14.3/multisim.exe: dlls/win32u/dibdrv/objects.c:812: solid_pen_lines: Пропадна проверката за истина - 'num >= 2'. 0024:err:seh:call_seh_handlers invalid frame 00000001000FF8A0 (0000000100102000-00000001001FFD20) 0024:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception. I saw that Proteus and LTSpice are also affected from this bug. https://www.reddit.com/r/winehq/comments/1ggdeiu/comment/lv8tiwr/ https://bbs.archlinux.org/viewtopic.php?id=300388 This happens when reading a graph or running an oscilloscope. Other CAD software may also be affected... I hope this gets fixed soon. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #42 from Dimitrios <temp2417(a)gmail.com> --- Paintshop Pro 7 is working now with Wine staging 9.22 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #43 from GDD71 <gdd71(a)abv.bg> --- I don't know if it's correct, (I have no experience writing code.)but I changed the file dlls/win32u/dibdrv/objects.c Line 812 assert( num >= 2 ); to be: assert( num >= 0 ); Then I compiled WINE 9.22 with this change and Multisim works again. No more error:.wine/drive_c/Program Files (x86)/National Instruments/Circuit Design Suite 14.3/multisim.exe: dlls/win32u/dibdrv/objects.c:812: solid_pen_lines: Пропадна проверката за истина - 'num >= 2'. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 bugs-winehq(a)sl.vagnarelli.dev changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs-winehq(a)sl.vagnarelli.d | |ev --- Comment #44 from bugs-winehq(a)sl.vagnarelli.dev --- On wine 9.18 Enterprise Architect works flawlessly. From wine 9.19 onwards the program crashes in some specific scenarios consistently (such as opening a certain type of diagram), making the program unusable. I also tried wine 9.22 but the bug is still present. I leave the last two lines of the crash log below. ../wine/dlls/win32u/dibdrv/objects.c:812: solid_pen_lines: Assertion `num >= 2' failed. 0024:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #45 from Fabian Maurer <dark.shadow4(a)web.de> --- (In reply to GDD71 from comment #43)
I don't know if it's correct, (I have no experience writing code.)but I changed the file dlls/win32u/dibdrv/objects.c Line 812 assert( num >= 2 ); to be: assert( num >= 0 );
I'm 99% sure it's wrong, there is still corruption, just unnoticed. For those who experience still crashes on wine-9.22, can you link a download (if possible) so we can test this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #46 from GDD71 <gdd71(a)abv.bg> --- Unfortunately, Multisim is difficult to install... winetrics, jet40, gdi+ net ftamework, vcrun, instalations problem and more. And there is no download link. But I was able to reproduce the same crash with MSPaint (XP). Download link For test: https://archive.org/details/MSPaintWinXP https://archive.org/download/MSPaintWinXP/mspaint%20WinXP%20English.zip Open mspaint.exe with Latest WINE 9.22. Press the "Ellipse" button and draw/paint in the window. Here is the output from the terminal: ---------------------------------------------------------------- wine '/home/gdd71/Плот/WinXP English/mspaint.exe' 002c:fixme:winediag:loader_init wine-staging 9.22 is a testing version containing experimental patches. 002c:fixme:winediag:loader_init Please mention your exact version when filing bug reports on winehq.org. 00e0:err:winebth:bluez_dbus_loop Error getting object list from BlueZ: 'org.freedesktop.DBus.Error.ServiceUnknown': 'The name org.bluez was not provided by any .service files' 0024:err:environ:init_peb starting L"D:\\home\\gdd71\\\041f\043b\043e\0442\\WinXP English\\mspaint.exe" in experimental wow64 mode 0140:fixme:ole:CoInitializeSecurity 0000000000000000, -1, 0000000000000000, 0000000000000000, 1, 3, 0000000000000000, 0, 0000000000000000 stub 0154:fixme:wia:wiadevmgr_QueryInterface interface {00000003-0000-0000-c000-000000000046} not implemented 0154:fixme:wia:wiadevmgr_QueryInterface interface {00000003-0000-0000-c000-000000000046} not implemented 0154:fixme:wia:wiadevmgr_QueryInterface interface {00000019-0000-0000-c000-000000000046} not implemented 0154:fixme:wia:enumwiadevinfo_QueryInterface interface {00000003-0000-0000-c000-000000000046} not implemented 0154:fixme:wia:enumwiadevinfo_QueryInterface interface {00000003-0000-0000-c000-000000000046} not implemented 0154:fixme:wia:enumwiadevinfo_QueryInterface interface {00000019-0000-0000-c000-000000000046} not implemented 0154:fixme:wia:enumwiadevinfo_GetCount (0000000000DCB200, 0000000000DCB1A0): stub 016c:fixme:seh:WerSetFlags (2) stub 016c:fixme:heap:RtlSetHeapInformation HEAP_INFORMATION_CLASS 1 not implemented! 0188:err:environ:init_peb starting L"C:\\windows\\Microsoft.NET\\Framework\\v4.0.30319\\mscorsvw.exe" in experimental wow64 mode 0188:fixme:ntdll:NtQuerySystemInformation info_class SYSTEM_PERFORMANCE_INFORMATION 0188:fixme:seh:WerSetFlags (2) stub 0188:fixme:heap:RtlSetHeapInformation HEAP_INFORMATION_CLASS 1 not implemented! 71/Плот/WinXP English/mspaint.exe: dlls/win32u/dibdrv/objects.c:812: solid_pen_lines: Пропадна проверката за истина - 'num >= 2'. 0024:err:seh:call_seh_handlers invalid frame 00000001000FF8F0 (0000000100102000-00000001001FFD20) 0024:err:seh:NtRaiseException Exception frame is not in stack limits => unable to dispatch exception. --------------------------------------------------------------- -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #47 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 77514 --> https://bugs.winehq.org/attachment.cgi?id=77514 Patch for mspaint Attached patch should prevent crashes in mspaint. There might be more issues though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #48 from GDD71 <gdd71(a)abv.bg> --- (In reply to Fabian Maurer from comment #47)
Created attachment 77514 [details] Patch for mspaint
I have now tested this patch, Multisim also works with it. No more crashes. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #49 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77516 --> https://bugs.winehq.org/attachment.cgi?id=77516 pictures for comparison I saw that now Multisim it's not drawing a circle in the elements, but a square Something's still not right.. I am attaching two pictures for comparison. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #50 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77517 --> https://bugs.winehq.org/attachment.cgi?id=77517 Also affects the DipTrace program too, so it's global. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #51 from Fabian Maurer <dark.shadow4(a)web.de> ---
I saw that now Multisim it's not drawing a circle in the elements, but a square Something's still not right..
Can you open a separate bug for that? I don't think that's the same issue. A +gdi log would be good I think, or a way to reproduce it myself. I'd also like to have tests for that, but not sure how that would work. Do we still got any crashes with my last patch? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |antonytheodorakis(a)yahoo.com --- Comment #52 from Fabian Maurer <dark.shadow4(a)web.de> --- *** Bug 57490 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #53 from GDD71 <gdd71(a)abv.bg> --- (In reply to Fabian Maurer from comment #51) ...Do we still got any crashes with my last patch? I installed WINE 9.22 without the last patch. DipTrace, which is not affected by this bug, displays the components correctly and they are round, as they should be. Multisim, PaintXP etc.. crash. ..dlls/win32u/dibdrv/objects.c:812: solid_pen_lines... The last patch fixes the crashes. Multisim, PaintXP.. work, but the effect appears with the circles being drawn incorrectly as squares, as I showed with the pictures. It is likely/logical that the effect is caused by it. You can use DipTrace for a test: https://diptrace.com/downloads/dipfree_en64.exe to test the last patch for the effect with the squares. When you start Pcb Layout (Pcb.exe) when selecting housings, the circles are displayed incorrectly at the bottom left., and this happens after applying the last patch, it's ok without it. - if (!ellipse_width || !ellipse_height) + if (ellipse_width < 2 || !ellipse_height) - last patch What would happen if we did: if (ellipse_width < 2 || ellipse_height < 2) to be symmetrical/equal in height and width? Do you think it will work like this? I can test such an option for an experiment. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #54 from GDD71 <gdd71(a)abv.bg> --- if (ellipse_width < 2 || ellipse_height < 2) not work. fixes drawing circles, but reverts back erorr ..dlls/win32u/dibdrv/objects.c:812: solid_pen_lines... For now, VINE 9.18 remains my favorite. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #55 from Fabian Maurer <dark.shadow4(a)web.de> ---
What would happen if we did:
if (ellipse_width < 2 || ellipse_height < 2)
to be symmetrical/equal in height and width? Do you think it will work like this? I can test such an option for an experiment.
It shouldn't behave like that, it looks like a rectangle in my tests.
if (ellipse_width < 2 || ellipse_height < 2) not work. fixes drawing circles, but reverts back erorr ..dlls/win32u/dibdrv/objects.c:812: solid_pen_lines...
I don't get an error with that, but it's not correct. Can you tell me where exactly the error is reproduced? I'm not familiar with DipTrace. I guess it should be
if (abs(ellipse_width) < 2 || !ellipse_height)
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #56 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77523 --> https://bugs.winehq.org/attachment.cgi?id=77523 DipTrace wine test -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #57 from GDD71 <gdd71(a)abv.bg> --- ------------------------------------------------ New test: latest Wine + This patch:
if (abs(ellipse_width) < 2 || !ellipse_height) It doesn't work for me. DipTrace - OK PaintXP - Not crash, but it draws choppy/but draws in a fragmented manner + window resizing problems Multisim - Crash with ...objects.c:812: solid_pen_lines: ....
WINE 9.22 - 3c50afd2 GPU - NVIDIA GeForce RTX 2080 SUPER OS - EndeavourOS - Arch Linux DE - GNOME 47.1 on x11 ---------------------------------------------- WINE 9.22 - Overall- Decreased speed/performance vs WINE 9.18 ---------------------------------------------- -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #58 from Fabian Maurer <dark.shadow4(a)web.de> --- (In reply to GDD71 from comment #56)
Created attachment 77523 [details] DipTrace wine test
It seems like the bottom left is always drawn with gdi, so there's that. I can't reproduce the squares you see with my path, are you sure you applied the patch correctly? (In reply to GDD71 from comment #57)
New test: latest Wine + This patch:
if (abs(ellipse_width) < 2 || !ellipse_height) It doesn't work for me. PaintXP - Not crash, but it draws choppy/but draws in a fragmented manner + window resizing problems Multisim - Crash with ...objects.c:812: solid_pen_lines: .... WINE 9.22 - Overall- Decreased speed/performance vs WINE 9.18
That's a lot of things that should not be related to that patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #59 from GDD71 <gdd71(a)abv.bg> --- Yes, I provided a little more info. in general - it fixes PaintXP but not fixes the basic error ..objects.c:812: solid_pen_lines:.. wholly Multisim - still Crash.
I can't reproduce the squares you see with my path With this option "if (ellipse_width < 2 || !ellipse_height)" right?
..are you sure you applied the patch correctly? I think so, but that was 3 days ago, and since then there have been changes in the source code. OK, I'll try again, this option: if (ellipse_width < 2 || !ellipse_height) if something happened then or influenced now, let's see if there will be a difference.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Dimitrios <temp2417(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|temp2417(a)gmail.com | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #60 from GDD71 <gdd71(a)abv.bg> --- ---------------------------------------------- New test: latest WINE 9.22 - b0a34b39 + This patch: if (ellipse_width < 2 || !ellipse_height) DipTrace - OK no squares PaintXP - Not crash, but it draws choppy Multisim - Crash with ...objects.c:812: solid_pen_lines: .... ---------------------------------------------- No idea why this happens...? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #61 from Fabian Maurer <dark.shadow4(a)web.de> ---
if (ellipse_width < 2 || !ellipse_height) DipTrace - OK no squares
So it works now? Because you reported back it having squares last time.
PaintXP - Not crash, but it draws choppy
Caused by this patch or happens anyways? Should happen always.
Multisim - Crash with ...objects.c:812: solid_pen_lines: ....
Caused by this patch or happens anyways? Should happen always. Would need to reproduce or have logs to fix. I created a branch to test: https://gitlab.winehq.org/DarkShadow44/wine/-/tree/win32u_dib If you still have crashes with that branch, please provide a +dib log and I can take a look. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #62 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77530 --> https://bugs.winehq.org/attachment.cgi?id=77530 multisim-winedbg-terminalout I downlod source code wine-9.22-add0b65a "git clone -b win32u_dib https://gitlab.winehq.org/DarkShadow44/wine....." I compiled and installed.. The result is exactly the same as the last test. Multisim - Crash with ...objects.c:812: solid_pen_lines: .... I am attaching you winedbg log file. What is it "+dib log" ? I couldn't find any information about what it is. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #63 from Fabian Maurer <dark.shadow4(a)web.de> ---
What is it "+dib log" ? I couldn't find any information about what it is.
It's a log created with "WINEDEBUG=+dib wine program.exe" -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #64 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77531 --> https://bugs.winehq.org/attachment.cgi?id=77531 Multisim_WINEDEBUG=+dib -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #65 from Fabian Maurer <dark.shadow4(a)web.de> --- (In reply to GDD71 from comment #64)
Created attachment 77531 [details] Multisim_WINEDEBUG=+dib
Sorry, I don't understand what is going wrong. There doesn't seem to be something wrong with the parameters, since that on its own works. Maybe a WINEDEBUG=+region,+dib,+gdi,+clipping,+dc log would help. Otherwise, a way to reproduce myself would be really useful. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #66 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 77533 --> https://bugs.winehq.org/attachment.cgi?id=77533 Test that crashes Wine So, I found an issue. Not sure if it's the same as yours, but it might have the same roots. In generate_ellipse_top_half we do as follows:
const double a = (hsq * xform->eM11 * xform->eM11) + (wsq * xform->eM12 * xform->eM12); ... const double d = (hsq * wsq); ... pt.x = -sqrt(d / a); ... while (pt.y > 0 || (pt.y == 0 && pt.x != -start_x))
When pt.x is 0, the functions returns a count of 0, leading to the assertion and crash. No idea how to fix this though... @Zeb, do you have an idea? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #67 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77580 --> https://bugs.winehq.org/attachment.cgi?id=77580 Multisim_WINEDEBUG=+region,+dib,+gdi,+clipping,+dc -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #68 from Rafał Mużyło <galtgendo(a)o2.pl> --- (In reply to Fabian Maurer from comment #66)
So, I found an issue. Not sure if it's the same as yours, but it might have the same roots.
const double a = (hsq * xform->eM11 * xform->eM11) + (wsq * xform->eM12 * xform->eM12); ... const double d = (hsq * wsq); ... pt.x = -sqrt(d / a); ... while (pt.y > 0 || (pt.y == 0 && pt.x != -start_x))
When pt.x is 0, the functions returns a count of 0, leading to the assertion and crash. No idea how to fix this though...
If pt.x is 0, then either width or height is 0, so there's nothing to draw, so we shouldn't be in this function in the first place. As such, a proposition - let's cut this shit at the earliest opportunity: in draw_arc right after width and height are calculated, let's just add if (!(width*height)) return TRUE; Unless this code is actually do anything when the passed rectangle has 0 width/height, that seems a sane solution, doesn't it ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #69 from Rafał Mużyło <galtgendo(a)o2.pl> --- ...or perhaps call dibdrv_LineTo, if that's what's supposed to happen in the degenerate case... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #70 from Fabian Maurer <dark.shadow4(a)web.de> ---
If pt.x is 0, then either width or height is 0, so there's nothing to draw, so we shouldn't be in this function in the first place.
I'm not so sure about that. The test sample I linked draws a tiny circle, but scaling this up, it seems to be a rect with just one pixel missing in the corners.
As such, a proposition - let's cut this shit at the earliest opportunity:
in draw_arc right after width and height are calculated, let's just add
We're not in draw_arc there.
Unless this code is actually do anything when the passed rectangle has 0 width/height, that seems a sane solution, doesn't it ?
...or perhaps call dibdrv_LineTo, if that's what's supposed to happen in the degenerate case...
I think drawing a rectangle is the best compromise. It's not pixel perfect, but the entire thing is very much not pixel perfect. As I said, writing tests is hard. Could you test my updated branch? See https://gitlab.winehq.org/DarkShadow44/wine/-/tree/win32u_dib This is would I propose as a fix, at least for now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #71 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77588 --> https://bugs.winehq.org/attachment.cgi?id=77588 TEST
Could you test my updated branch? Latest test:
MSPaintXP - Instead of an ellipse, it draws a square. + problem resizing window Diptrace - Instead of an ellipse, it draws a square. in GDI mode - same as Comment 49/50 + window problem Multisim - Instead of an ellipse, it draws a square. - same as Comment 49/50 + 30% CPU load Тhere is no difference in behavior in Wayland or X11 session. No crashes... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #72 from Rafał Mużyło <galtgendo(a)o2.pl> ---
We're not in draw_arc there.
my bad - get_arc_points/get_arc_max_points is called from there too, though. I think I'm going down the same rabbit hole, you did from comment 53 onwards... See you on the other side. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #73 from Rafał Mużyło <galtgendo(a)o2.pl> --- That it draws rectangles instead of ellipses with this patch is unsurprising - generate_ellipse_top_half can only return 0 if called that way. GDD71: out of curiosity, does mspaintxp has all those drawing artifacts when drawing round rects under 9.18 ? I mean those when you drag the rectangle to size...(normal rectangles aren't affected) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #74 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77591 --> https://bugs.winehq.org/attachment.cgi?id=77591 mspaint.exe_9.18 I don't understand what exactly you have in mind, but there are some artifacts.. yes :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #75 from Rafał Mużyło <galtgendo(a)o2.pl> --- Created attachment 77593 --> https://bugs.winehq.org/attachment.cgi?id=77593 a rubbish hack ...ah, no, I've meant the horizontal/vertical extra lines that are being drawn as you drag the round rect (and sometimes elipse) to size. Anyway, this attachment is rubbish, yet it just might help with the crash - do check. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #76 from Rafał Mużyło <galtgendo(a)o2.pl> --- ...the first chunk of the patch is likely redundant (it doesn't seem to affect the crash). The WARN lines are likely too noisy and don't work with Paint (it seems to trash all output). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #77 from Fabian Maurer <dark.shadow4(a)web.de> --- (In reply to GDD71 from comment #71)
Created attachment 77588 [details] TEST
Could you test my updated branch? Latest test:
MSPaintXP - Instead of an ellipse, it draws a square. + problem resizing window Diptrace - Instead of an ellipse, it draws a square. in GDI mode - same as Comment 49/50 + window problem Multisim - Instead of an ellipse, it draws a square. - same as Comment 49/50 + 30% CPU load
Тhere is no difference in behavior in Wayland or X11 session. No crashes...
Sorry, I made a stupid mistake here, I pushed an update here: https://gitlab.winehq.org/DarkShadow44/wine/-/tree/win32u_dib Can you check that for graphical glitches and crashes? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #78 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77595 --> https://bugs.winehq.org/attachment.cgi?id=77595 Test
Can you check that for graphical glitches and crashes?
Now it draws correctly, better than 9.18, like in native Windows and no crashes The remaining issues are still available. MSPaintXP - problem resizing window, stuttering/chopping and artifacts Diptrace - window problem in GDI mode Multisim - High CPU load -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #79 from Fabian Maurer <dark.shadow4(a)web.de> ---
Now it draws correctly, better than 9.18, like in native Windows and no crashes
Thanks, not 100% sure where to go from here though.
The remaining issues are still available.
MSPaintXP - problem resizing window, stuttering/chopping and artifacts Diptrace - window problem in GDI mode Multisim - High CPU load
I'm afraid this is different issues. Yes they should be fixed, but a separate issue should be create for each. Unless something is caused by my patch?! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #80 from GDD71 <gdd71(a)abv.bg> --- now.. I installed the latest Wine to check what it is due to.. The listed issues are still present without this patch. so it could be due to something else this patch fixing the crash ...objects.c:812: solid_pen_lines: .... and the drawing is correct, which is great -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #81 from Rafał Mużyło <galtgendo(a)o2.pl> --- So, I'll ask again, those artifacts (extra lines drawn for round rects / ellipses) in Paint, were they there in 9.18 ? Cause if not, that would still be a valid regression to potentially be addressed before 10.0.... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #82 from Rafał Mużyło <galtgendo(a)o2.pl> --- ...then again, never mind; let's see a better patch first... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #83 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77599 --> https://bugs.winehq.org/attachment.cgi?id=77599 picture for comparison
So, I'll ask again, those artifacts (extra lines drawn for round rects / ellipses) in Paint, were they there in 9.18 ?
Cause if not, that would still be a valid regression to potentially be addressed before 10.0....
In 9.18 the listed problems + shown in the video (Comment 78) do not exist. Although the rounding drawing is better in 10.0 + patch. - attached picture for comparison -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #84 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77745 --> https://bugs.winehq.org/attachment.cgi?id=77745 test latest zfigura mr4 Test https://gitlab.winehq.org/zfigura/wine/-/tree/mr4 50116b7dcc91cd366be4437931d82542c6756f89 Multisim - crash -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #85 from Rafał Mużyło <galtgendo(a)o2.pl> --- (In reply to GDD71 from comment #84)
Created attachment 77745 [details] test latest zfigura mr4
... I must say, personally I've committed multiple acts of cargo-culting, yet approaching a clear incoming heap overflow with simply a debug printf instead of an emergency bailout is quite a bold move.... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #86 from Rafał Mużyło <galtgendo(a)o2.pl> --- ...oh, sorry, it's not an *incoming* heap overflow, it went effective during second get_arc_points run... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #87 from Rafał Mużyło <galtgendo(a)o2.pl> ---
0024:err:dib:dibdrv_RoundRect point count 11 * 2 exceeds max points 16 ... 0024:err:dib:dibdrv_RoundRect point count 13 * 2 exceeds max points 16
Now, could there be something off about get_arc_max_points ? Cause while the first line is off only by a little (+1 to both width and height), the second would need +2 over that... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #88 from Zeb Figura <z.figura12(a)gmail.com> --- (In reply to GDD71 from comment #84)
Created attachment 77745 [details] test latest zfigura mr4
Test https://gitlab.winehq.org/zfigura/wine/-/tree/mr4 50116b7dcc91cd366be4437931d82542c6756f89
Multisim - crash
Can you please attach a log with +gdi,+dib? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #89 from GDD71 <gdd71(a)abv.bg> --- Created attachment 77751 --> https://bugs.winehq.org/attachment.cgi?id=77751 Test +gdi,+dib
Multisim - crash Can you please attach a log with +gdi,+dib?
multisim WINEDEBUG=+gdi,+dib and MSPaint wrong drawing all window resizing issues are also available -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #90 from Zeb Figura <z.figura12(a)gmail.com> --- Created attachment 77766 --> https://bugs.winehq.org/attachment.cgi?id=77766 traces Sorry, I need more tracing. Can you please apply this patch and take another trace with the same flags? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 --- Comment #91 from Zeb Figura <z.figura12(a)gmail.com> --- I can't reproduce those visual errors with Microsoft Paint from Windows XP, either. Using the round rect tool works fine for me. What are you doing exactly? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Zeb Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |gdi32 Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |bc029e08b7d949d90c4509f17a8 | |c5ef60c8d0f88 --- Comment #92 from Zeb Figura <z.figura12(a)gmail.com> --- Transformed arc support has been entirely reverted as of bc029e08b7d949d90c4509f17a8c5ef60c8d0f88. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57306 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #93 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.0-rc5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla