[Bug 44016] New: Improve path handling in Open and Save dialogs
https://bugs.winehq.org/show_bug.cgi?id=44016 Bug ID: 44016 Summary: Improve path handling in Open and Save dialogs Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: comdlg32 Assignee: wine-bugs(a)winehq.org Reporter: kolan_n(a)mail.ru Distribution: --- Current open and save dialogs have large usability issues. 1 When I paste a path of a folder into it to make it open that folder in itself it doesn't work and writes an error. 2 I also expect this dialog to accept the absolute path in linux rootfs. 3 I also expect it to show a drop-down menu as in Windows. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Are you talking about GetOpenFileNameA or CLSID_FileOpenDialog? Mind providing more information to each point, about what behavior you want? Because I don't fully understand it yet. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 --- Comment #2 from KOLANICH <kolan_n(a)mail.ru> ---
Are you talking about GetOpenFileNameA or CLSID_FileOpenDialog?
About GetOpenFileName. I haven't used any apps using CLSID_FileOpenDialog in wine, so I don't know if this issue touches that API.
Mind providing more information to each point, about what behavior you want? Because I don't fully understand it yet.
1 a) I copy a windows path of some folder b) I open "open" dialog of some application, for example Notepad++ c) I paste the path there d) I hit enter/click the "open" button. Wine writes an error. Windows opens that folder in the dialog. 2 I also expect this dialog to accept the absolute path in linux rootfs. a) I copy a rootfs path of some file b) I open "open" dialog of some application, for example Notepad++ c) I paste the path there d) I hit enter/click the "open" button. Wine writes an error, but IMHO it should convert open that path into windows one (and, optionally, just introduce direct support of sysfs paths) , because it's a big inconvenience to paste the path into a text editor and convert it manually. 3 a) I open an "open" dialog of some application, for example Notepad++ c) I paste the full pathname prefix there, for example "Z:\" or "Z:\a". In windows a drop-down menu appers allowing me to select a file from the opened folder, filtered by the prefix I have typed. Assuming that there are an "a" folder and "aa.txt", "ab.txt" and "b.txt" files in Z, in the first case it should suggest them all, in the latter one the first three ones. In wine it doesn't. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- 1) What error does wine give? I paste "C:\windows\system32" in notepad++ open and it works as expected. 2) I a agree, but I'm not sure if that's planned to be possible. 3) Ah, yes. I get what you mean, that would be very useful indeed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 --- Comment #4 from KOLANICH <kolan_n(a)mail.ru> ---
1) What error does wine give? I paste "C:\windows\system32" in notepad++ open and it works as expected.
In fact I worked with that system a half year ago, I just have recently remembered that I had wanted to create a ticket. If it works, it's fine.
2) I a agree, but I'm not sure if that's planned to be possible.
What's the problem? Wine knows all the mounted windows drives so in the case of a rootfs path it can check if any mounted windows drive path is a prefix of a rootfs path and then replace. 4 Could you also check if everything works with shashes instead of backslashes? (in Windows autocomplete doesn't work for that paths (but in Wine I think it should), but they are valid). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 --- Comment #5 from Austin English <austinenglish(a)gmail.com> --- (In reply to KOLANICH from comment #4)
1) What error does wine give? I paste "C:\windows\system32" in notepad++ open and it works as expected.
In fact I worked with that system a half year ago, I just have recently remembered that I had wanted to create a ticket. If it works, it's fine.
2) I a agree, but I'm not sure if that's planned to be possible.
What's the problem? Wine knows all the mounted windows drives so in the case of a rootfs path it can check if any mounted windows drive path is a prefix of a rootfs path and then replace.
Wine will map / to Z:\ normally, so you can access files in your file system. comdlg32 doesn't understand unix paths, and it's doubtful it should. The DLL can be used on windows, which doesn't support that. You can use `winepath` to converte unix/windows paths. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- It's unlikely that dialog logic has to deal with display names or paths on its own, all that should go through shell interfaces. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 Gabriel Ivăncescu <gabrielopcode(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |gabrielopcode(a)gmail.com Status|UNCONFIRMED |ASSIGNED CC| |gabrielopcode(a)gmail.com Ever confirmed|0 |1 --- Comment #7 from Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- Visiting this bug. Summary: (1) is not an issue and fixed for a while. (2) gives an error on Windows on purpose (even using path like windows/win.ini) (3) requires implementing missing classes first (ACList_ISF) I think this bug should be focused around (3). It's on my TODO list for after Wine 4.0 (now it's in code freeze), after I implement more of the autocomplete dropdown and make it like Windows some more. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 Kyle_Katarn <contact(a)kcsoftwares.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |contact(a)kcsoftwares.com --- Comment #8 from Kyle_Katarn <contact(a)kcsoftwares.com> --- Will this include fix for https://bugs.winehq.org/show_bug.cgi?id=39867 and https://bugs.winehq.org/show_bug.cgi?id=48980 ? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 Gabriel Ivăncescu <gabrielopcode(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gabrielopcode(a)gmail.com |wine-bugs(a)winehq.org Status|ASSIGNED |NEW --- Comment #9 from Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- (In reply to Kyle_Katarn from comment #8)
Will this include fix for https://bugs.winehq.org/show_bug.cgi?id=39867 and https://bugs.winehq.org/show_bug.cgi?id=48980 ?
Hi, sorry, I completely forgot about finishing up the autocomplete stuff, so I'll unassign myself for now as I don't know when I'll be able to. But no, it shouldn't have anything to do with the bugs you mentioned—it's about the drop-down popup that shows up to autocomplete a file or directory name. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 --- Comment #10 from Kyle_Katarn <contact(a)kcsoftwares.com> --- (In reply to Gabriel Ivăncescu from comment #9)
(In reply to Kyle_Katarn from comment #8)
Will this include fix for https://bugs.winehq.org/show_bug.cgi?id=39867 and https://bugs.winehq.org/show_bug.cgi?id=48980 ?
Hi, sorry, I completely forgot about finishing up the autocomplete stuff, so I'll unassign myself for now as I don't know when I'll be able to. But no, it shouldn't have anything to do with the bugs you mentioned—it's about the drop-down popup that shows up to autocomplete a file or directory name.
OK -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44016 doiyhah7q(a)relay.firefox.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |doiyhah7q(a)relay.firefox.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla