[Bug 47621] New: Buttons too small in height
https://bugs.winehq.org/show_bug.cgi?id=47621 Bug ID: 47621 Summary: Buttons too small in height Product: Wine Version: 4.13 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: Bjoern(a)Kautler.net Distribution: --- Created attachment 65052 --> https://bugs.winehq.org/attachment.cgi?id=65052 screenshot If you try to install Inno Setup 6.0.2 from http://www.jrsoftware.org/isdl.php via wine on Ubuntu Disco with the default package 4.0-1, the initial dialog that asks on whether to install for all users or current user, is only as big as the titlebar and not resizable. It is still usable via keyboard if you know what it shows or can be prevented by using commandline options. I then tried as advised with the latest development buid, which is 4.13~disco from dl.winehq.org. With that it improved significantly, so now the dialog is better sized and usable. But as can be seen in the attached screenshot, the buttons are too narrow in the height dimension. The text on the buttons is halfway cut. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |comctl32 Ever confirmed|0 |1 Severity|normal |minor Status|UNCONFIRMED |NEW --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- I can confirm. It's using Task Dialog, which is a relatively recent addition. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |zzhang(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 --- Comment #2 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- The Task Dialog implementation was written before Command Link implementation. https://source.winehq.org/patches/data/169017 should make it better. And also the first command link is changed to a push button at start because of WM_NEXTDLGCTL and DM_SETDEFID implementation doesn't have Command Link in mind either. v5 and v6 common control have different behavior. See https://source.winehq.org/patches/data/169019 for details. I will write a patch once I figure out a proper way to implement it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://files.jrsoftware.org | |/is/6/innosetup-6.0.2.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Buttons too small in height |Command link buttons in | |task dialog are displayed | |in wrong style -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Fixed by 463482a8295fad657b7fa22ea145551f63547238 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |463482a8295fad657b7fa22ea14 | |5551f63547238 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47621 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #5 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla