[Bug 25453] New: LXR falsifies source code at http://source.winehq.org/source/
http://bugs.winehq.org/show_bug.cgi?id=25453 Summary: LXR falsifies source code at http://source.winehq.org/source/ Product: WineHQ.org Version: unspecified Platform: All OS/Version: All Status: UNCONFIRMED Severity: normal Priority: P2 Component: www-unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: hoehle(a)users.sourceforge.net Please compare http://source.winehq.org/source/dlls/winmm/tests/mci.c?v=wine-1.3.8#l288 if(!err) ok(!strcmp(buf,"")... with http://source.winehq.org/git/wine.git/?a=blob;f=dlls/winmm/tests/mci.c;hb=c1... if(!err) ok(!strcmp(buf,"0")... See the missing 0? The source code never said "". At Wineconf it was suggested that the LXR package that is said to generate the source listings be updated to see if the bug would still be present then. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25453 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2010-12-07 13:15:48 CST --- Confirming. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25453 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jnewman(a)codeweavers.com, | |nerv(a)dawncrow.de --- Comment #2 from André H. <nerv(a)dawncrow.de> 2011-02-16 12:17:22 CST --- wineconf 2010 is a while ago now adding Mr. Newman :) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25453 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Platform|All |Other OS/Version|All |other --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2012-02-23 15:20:01 CST --- Removing deprecated 'All' Platform/OS. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25453 --- Comment #4 from André H. <nerv(a)dawncrow.de> 2012-03-03 06:56:51 CST --- Jeremy is not the maintainer of LXR, but i'm not sure who is... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25453 --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> 2012-03-03 08:31:23 CST --- We use the Debian packages, so it would have to be reported and fixed there. However I don't think it's being maintained in Debian any longer either. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25453 --- Comment #6 from André H. <nerv(a)dawncrow.de> 2012-03-03 08:44:22 CST --- debian has lxr 0.3.1-5 upstream is lxr 0.10.2 atm http://sourceforge.net/projects/lxr/files/stable/lxr-0.10.2/ maybe we should switch to the cvs version or at least use http://packages.debian.org/de/lenny/lxr-cvs in the meantime, but that needs apache. not sure if that's a problem -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25453 --- Comment #7 from Austin English <austinenglish(a)gmail.com> 2012-03-03 23:04:41 CST --- It was removed for not being maintained, see: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588138 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=591059 I filed a request for packaging, see: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=662104 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25453 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=25453 Jerome Leclanche <adys.wh(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh(a)gmail.com See Also| |http://bugs.debian.org/6621 | |04 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25453 --- Comment #8 from André H. <nerv(a)dawncrow.de> --- winehq was moved to a new machine this week and it seems some software was maybe updated (gitweb), so i just rechecked and can still confirm this bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25453 --- Comment #9 from Jeremy Newman <jnewman(a)codeweavers.com> --- The source website is based off of very very ancient tools/scripts that are not even available in the Debian repositories anymore. We just keep migrating the tools over to each Debian release manually. Unfortunately, each update we do to the server is not going to fix this issue. If anyone is going to fix this, it probably should be AJ. He has the best understanding of what these tools actually do. Hard to believe but this website was setup even before my time, > 14 years ago. It might simply be time to migrate these tools over to something else, python or PHP maybe. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25453 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick(a)piezo-forte.be --- Comment #10 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- (In reply to Jörg Höhle from comment #0)
Please compare http://source.winehq.org/source/dlls/winmm/tests/mci.c?v=wine-1.3.8#l288 if(!err) ok(!strcmp(buf,"")... with http://source.winehq.org/git/wine.git/?a=blob;f=dlls/winmm/tests/mci.c; hb=c138970ea2ce0661ebb80a5e0079e284a19d3176#l288 if(!err) ok(!strcmp(buf,"0")... See the missing 0? The source code never said "".
I don't see those differences. Is there something else to fix? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25453 --- Comment #11 from Jörg Höhle <hoehle(a)users.sourceforge.net> ---
(In reply to Olivier F. R. Dierick from comment #10)
http://source.winehq.org/source/dlls/winmm/tests/mci.c?v=wine-1.3.8#0023 The code looks correct now, indeed. Thank you.
Is there something else to fix? Well, at least in my browser, there's an indentation or rather an I18N issue: Every line whose author's name contains umlauts is misindented:
4aa5f5bc Jörg *0023 #include "windows.h" 6698e9e0 Jan Ze*0024 #include "mmsystem.h"
Perhaps the string length function that LXR uses to calculate the display width produces incorrect values for "Jörg", e.g. 5 instead of 4. That would explain what I see. But that would warrant another bug entry. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25453 Matteo Bruni <matteo.mystral(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #12 from Matteo Bruni <matteo.mystral(a)gmail.com> --- (In reply to Jörg Höhle from comment #11)
(In reply to Olivier F. R. Dierick from comment #10)
http://source.winehq.org/source/dlls/winmm/tests/mci.c?v=wine-1.3.8#0023 The code looks correct now, indeed. Thank you.
Let's resolve it fixed then. You can open a new bug for the other issue if you want. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=25453 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- As above -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla