[Bug 45136] New: Wine does not behave as Windows when using TBM_SETPAGESIZE call before TBM_SETRANGE
https://bugs.winehq.org/show_bug.cgi?id=45136 Bug ID: 45136 Summary: Wine does not behave as Windows when using TBM_SETPAGESIZE call before TBM_SETRANGE Product: Wine Version: unspecified Hardware: x86 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: patrick.maillot(a)gmail.com The TBM_SETPAGESIZE message can be called before a TBM_SETRANGE message in Windows and this will not affect the value or behavior of the TBM_SETPAGESIZE parameter. Wine's function 'TRACKBAR_SetRangeMin', at line 1288 of file https://github.com/wine-mirror/wine/blob/master/dlls/comctl32/trackbar.c force sets the Wine 'lPageSize' value ( infoPtr->lPageSize = (infoPtr->lRangeMax - infoPtr->lRangeMin) / 5;). So when TBM_SETRANGE message is sent after a TBM_SETPAGESIZE message, the TBM_SETPAGESIZE parameter is reset. This is not the Windows behavior. A quick fix is to ensure in Windows one always calls TBM_SETPAGESIZE parameter after TBM_SETRANGE. A better fix would be not to force update the lPageSize variable in the TRACKBAR_SetRangeMin function. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45136 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- Hi, Patrick-Gilles. I sent a patch that fixes this, see https://www.winehq.org/pipermail/wine-devel/2018-May/126568.html. Thanks for the report. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45136 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.7 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45136 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> --- Confirming. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45136 tokktokk <fdsfgs(a)krutt.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs(a)krutt.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45136 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- This should work correctly now, with https://source.winehq.org/git/wine.git/commit/6dc3c6ba879b79fac7e4c9c0693539.... Please retest. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45136 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |6dc3c6ba879b79fac7e4c9c0693 | |539a614229978 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- Marking fixed, 6dc3c6ba879b79fac7e4c9c0693539a614229978 38e715387da75458874a22efb34419cc469f9624 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=45136 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 3.8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org