[Bug 17633] New: Zoner Photo Studio has broken computer tree
http://bugs.winehq.org/show_bug.cgi?id=17633 Summary: Zoner Photo Studio has broken computer tree Product: Wine Version: 1.1.16 Platform: PC OS/Version: Solaris Status: UNCONFIRMED Severity: normal Priority: P2 Component: shell32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: petr.sumbera(a)sun.com Created an attachment (id=19816) --> (http://bugs.winehq.org/attachment.cgi?id=19816) patch Zoner Photo Studio has broken computer tree (instead directory names just strange/empty characters/boxes). This is regression after: --- cf164785afac461a84e23d1e370205c28de73e0a is first bad commit commit cf164785afac461a84e23d1e370205c28de73e0a Author: Aric Stewart <aric(a)codeweavers.com> Date: Mon Nov 3 10:14:53 2008 -0600 shell32: Do not automatically fail in SHGetFileInfo if the flag SHGFI_USEFILEATTRIBUTES is combined with SHGFI_ATTRIBUTES, SHGFI_EXETYPE, or SHGFI_PIDL. :040000 040000 6d94577d69fa143f0911de5fa1336c4d6c698d63 81a41666dac7553414bff76b73f986f7b15580ab M dlls --- It seems that szFullPath is needed even for SHGFI_PIDL and SHGFI_USEFILEATTRIBUTES flags combination (ZPS uses flags=0x20e18). See attached patch which fixes this. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 Petr Sumbera <petr.sumbera(a)sun.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19816|0 |1 is patch| | -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 Petr Sumbera <petr.sumbera(a)sun.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-03-06 11:56:00 --- Please send patches to wine-patches(a)winehq.org -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2009-09-08 11:44:02 --- Is this still an issue in current (1.1.29 or newer) wine? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 --- Comment #3 from Petr Sumbera <petr.sumbera(a)sun.com> 2009-09-29 11:46:15 --- The issue is still present. Tested with latest git sources (wine-1.1.30-54-g404aecb) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 --- Comment #4 from Vincent Povirk <madewokherd(a)gmail.com> 2009-12-26 16:17:01 --- The patch is likely wrong. ILGetDisplayNameExW will not always return a real filename. Probably the later code should be fixed to not rely on szFullPath in this case. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aric(a)codeweavers.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 --- Comment #5 from Vincent Povirk <madewokherd(a)gmail.com> 2010-07-16 15:42:46 --- Patch sent: http://www.winehq.org/pipermail/wine-patches/2010-July/090522.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 Petr Sumbera <petr.sumbera(a)sun.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #6 from Petr Sumbera <petr.sumbera(a)sun.com> 2010-07-23 10:04:48 --- I can confirm that the following commit resolved the issue: http://source.winehq.org/git/wine.git/?a=commit;h=537bfbf4946837ce8739b5722c... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17633 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> 2010-07-30 12:56:49 --- Closing bugs fixed in 1.3.0. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org