[Bug 14749] New: riched20: Fix vertical scrolling
http://bugs.winehq.org/show_bug.cgi?id=14749 Summary: riched20: Fix vertical scrolling Product: Wine Version: CVS/GIT Platform: Other OS/Version: other Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: comctl32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: bugzilla(a)tut.by Created an attachment (id=15248) --> (http://bugs.winehq.org/attachment.cgi?id=15248) riched20: Fix vertical scrolling The acfb6ea210c92ef9ff41dc6828f9482e9c6d6516 commit introduced new bug, that can be reproduced by any program that uses RichEd20: if control has less than one page of text, it can be scrolled past the last line of text, hiding all of it completely. The following patch fixes this. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 --- Comment #1 from Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> 2008-08-04 06:20:42 --- hmm. this needs to be fixed little more. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 --- Comment #2 from Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> 2008-08-04 07:11:19 --- sorry, patch is totally wrong, but bug is still there -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a_villacis(a)palosanto.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15248|0 |1 is obsolete| | --- Comment #3 from Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> 2008-08-04 07:55:59 --- Created an attachment (id=15253) --> (http://bugs.winehq.org/attachment.cgi?id=15253) riched20: Fix vertical scrolling This patch seems to work -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|comctl32 |richedit -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 --- Comment #4 from Vijay Kamuju <infyquest(a)gmail.com> 2008-08-04 09:47:32 --- please send the patch to wine-patches(a)winehq.org -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #5 from Austin English <austinenglish(a)gmail.com> 2008-08-04 10:09:17 --- Please use the patch keyword in the future. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 --- Comment #6 from Alex Villacís Lasso <a_villacis(a)palosanto.com> 2008-08-04 13:15:18 --- Hello, I am the author of the patch mentioned as causing the (possible) regression. Could the reporter please state which particular app exposed the bug? Do you have a download link? I have tried raddecay (richedit 1.0) and Perfect! Text Edit (richedit 2.0) with current git and I am unable to reproduce the symptoms indicated in the bug report. Can you provide a testcase? Do current testcases still succeed with the proposed fix applied? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 --- Comment #7 from Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> 2008-08-04 13:35:18 --- (In reply to comment #6)
Hello, I am the author of the patch mentioned as causing the (possible) regression.
Greetings :-)
Could the reporter please state which particular app exposed the bug? Do you have a download link?
The first was Miranda IM with SRMM messaging module. Second was winehelp from WINE.
Can you provide a testcase? Do current testcases still succeed with the proposed fix applied?
Not sure about testcases, but: 1) with SRMM, when you turn on option "show last N messages", if length of backlog is less than page, richedit looks as if it was empty, but I can scroll up and see the text. 2) with WINE winhelp, open any .hlp, open any page with length less than vertical screen page size. Then try to scroll up using wheel. Got it? :-) And again about test cases. Not sure if this right, but I think that when nPage>nMax, nPos should be 0. Didn't test it yet, so no guarantees about it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 --- Comment #8 from Alex Villacís Lasso <a_villacis(a)palosanto.com> 2008-08-04 15:29:12 ---
And again about test cases. Not sure if this right, but I think that when nPage>nMax, nPos should be 0. Didn't test it yet, so no guarantees about it.
Tests fail with your patch applied: [alex(a)srv64 tests]$ make test ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.exe.so editor.c && touch editor.ok editor.c:2521: Test failed: Vertical scrollbar is invisible, should be visible. editor.c:2535: Test failed: Vertical scrollbar is invisible, should be visible. fixme:richedit:RichEditWndProc_common WM_STYLECHANGING: stub fixme:richedit:RichEditWndProc_common WM_STYLECHANGED: stub editor.c:2748: Test failed: Vertical scrollbar is invisible, should be visible. editor.c:2750: Test failed: reported page/range is 33 (0..32) expected all 0 editor.c:2760: Test failed: Vertical scrollbar is invisible, should be visible. editor.c:2762: Test failed: reported page/range is 17 (0..16) expected all 0 ... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 --- Comment #9 from Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> 2008-08-05 04:39:29 --- (In reply to comment #8)
Tests fail with your patch applied:
Yes, I know. I'm trying to find out how to fix visual regression and not to break tests. Did you reproduce the bug or not? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Dylan Smith <dylan.ah.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs(a)winehq.org |dylan.ah.smith(a)gmail.com Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1 --- Comment #10 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2009-01-11 01:33:04 --- Created an attachment (id=18632) --> (http://bugs.winehq.org/attachment.cgi?id=18632) Fix a bug in calculating whether the vertical scrollbar was visible. The calculation to see if the scrollbar was visible was subtracting from an unsigned integer that is initially 0, so this would cause the value to wrap around. This calculation should be the same as the calculating to find out the scrollbar will be visible, so I changed it accordingly. The bug this patch fixes can be seen by opening winhlp32 with a small help file specified on the command line. The vertical scrollbar would initially be visible, even though there is less than a page of text. I think the other bugs with vertical scrolling have already been fixed. I have already made some changes to scrolling recently that have been committed, and I still need to submit (including implementing the horizontal scrollbar). Let me know if this bug seems fixed, or provide a clear series of steps to reproduce remaining bugs. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Dylan Smith <dylan.ah.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18632|0 |1 is obsolete| | --- Comment #11 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2009-01-14 15:23:34 --- (From update of attachment 18632) In git tree as commit ee19ec056a417fbd705f62b3ccd392023bcfe8ae -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 --- Comment #12 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2009-01-16 13:23:12 --- (In reply to comment #11)
(From update of attachment 18632 [details]) In git tree as commit ee19ec056a417fbd705f62b3ccd392023bcfe8ae
Please test my fix on the latest wine release (wine-1.1.13). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #13 from Andrew O. Shadoura (I DO NOT USE COMPIZ) <bugzilla(a)tut.by> 2009-01-19 03:33:24 --- (In reply to comment #12)
Please test my fix on the latest wine release (wine-1.1.13).
Looks like you fixed the bug. Thanks. -- WBR, Andrew -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14749 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #14 from Alexandre Julliard <julliard(a)winehq.org> 2009-01-30 11:04:20 --- Closing bugs fixed in 1.1.14. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org